| Message ID | 513BF001.30204@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10 March 2013 07:59, Chen Gang <gang.chen@asianux.com> wrote: > > better using 'static const' instead of 'const static' > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm/mach-vexpress/platsmp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c > index dc1ace5..9152bf7 100644 > --- a/arch/arm/mach-vexpress/platsmp.c > +++ b/arch/arm/mach-vexpress/platsmp.c > @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { > > static void *vexpress_dt_cortex_a9_scu_base __initdata; > > -const static char *vexpress_dt_cortex_a9_match[] __initconst = { > +static const char *vexpress_dt_cortex_a9_match[] __initconst = { Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
? 2013?03?10? 10:57, Viresh Kumar ??: > On 10 March 2013 07:59, Chen Gang <gang.chen@asianux.com> wrote: >> > >> > better using 'static const' instead of 'const static' >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> >> > --- >> > arch/arm/mach-vexpress/platsmp.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c >> > index dc1ace5..9152bf7 100644 >> > --- a/arch/arm/mach-vexpress/platsmp.c >> > +++ b/arch/arm/mach-vexpress/platsmp.c >> > @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { >> > >> > static void *vexpress_dt_cortex_a9_scu_base __initdata; >> > >> > -const static char *vexpress_dt_cortex_a9_match[] __initconst = { >> > +static const char *vexpress_dt_cortex_a9_match[] __initconst = { > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > thank you. :-)
On Sun, 2013-03-10 at 02:29 +0000, Chen Gang wrote: > better using 'static const' instead of 'const static' > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm/mach-vexpress/platsmp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c > index dc1ace5..9152bf7 100644 > --- a/arch/arm/mach-vexpress/platsmp.c > +++ b/arch/arm/mach-vexpress/platsmp.c > @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { > > static void *vexpress_dt_cortex_a9_scu_base __initdata; > > -const static char *vexpress_dt_cortex_a9_match[] __initconst = { > +static const char *vexpress_dt_cortex_a9_match[] __initconst = { > "arm,cortex-a5-scu", > "arm,cortex-a9-scu", > NULL Thanks for spotting this. I will keep this in mind, but I can't promise to take this patch as it goes, because the platsmp.c is likely to change (shrink) in near future. Either way I'll make sure you get due credit :-) Cheers! Pawel
diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c index dc1ace5..9152bf7 100644 --- a/arch/arm/mach-vexpress/platsmp.c +++ b/arch/arm/mach-vexpress/platsmp.c @@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { static void *vexpress_dt_cortex_a9_scu_base __initdata; -const static char *vexpress_dt_cortex_a9_match[] __initconst = { +static const char *vexpress_dt_cortex_a9_match[] __initconst = { "arm,cortex-a5-scu", "arm,cortex-a9-scu", NULL
better using 'static const' instead of 'const static' Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/arm/mach-vexpress/platsmp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)