| Message ID | 1363007760.3137.69.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 11-03-2013 17:16, Paul Bolle wrote: > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Tested by grepping the tree. > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART > was intended here. Should probably be in the changelog instead. WBR, Sergei
Paul, On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote: > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Tested by grepping the tree. > > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART > was intended here. Thanks for the fixing. Above comment should really be in the commit log. I just applied the patch as below. Shawn commit 0c52db7e681678f9b2a3fb96c3dd557168b4e025 Author: Paul Bolle <pebolle@tiscali.nl> Date: Mon Mar 11 14:16:00 2013 +0100 ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART" Commit f8c95fe (ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs) had a typo that DEBUG_IMX50_IMX53_UART should be DEBUG_IMX53_UART. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
On Mon, 2013-03-11 at 17:34 +0400, Sergei Shtylyov wrote: > On 11-03-2013 17:16, Paul Bolle wrote: > > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b > > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). > > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART > > was intended here. > > Should probably be in the changelog instead. I feared being to verbose. But putting it in the commit explanation is fine with me. I'll try to send an updated patch later this day. Paul Bolle
On Mon, Mar 11, 2013 at 10:37 AM, Shawn Guo <shawn.guo@linaro.org> wrote: > Paul, > > On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote: >> Signed-off-by: Paul Bolle <pebolle@tiscali.nl> >> --- >> 0) Tested by grepping the tree. >> >> 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b >> ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). >> Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART >> was intended here. > > Thanks for the fixing. Above comment should really be in the commit > log. I just applied the patch as below. Please see my commit: commit 7356420cd34e40fe27bf26555b0bf3f2849a43dd Author: Fabio Estevam <fabio.estevam@freescale.com> Date: Tue Jan 22 10:40:55 2013 -0200 ARM: imx: Remove mx508 support Only mx508 based board is mach-mx50_rdp and it has been marked as BROKEN for several releases. mx508 currently lacks clock support. In case someone needs to add mx508 support back, then the recommended approach is to use device tree. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Shawn Guo <shawn.guo@linaro.org> ,it does remove the MX50 reference, so this patch is not needed.
On Mon, 2013-03-11 at 21:37 +0800, Shawn Guo wrote: > On Mon, Mar 11, 2013 at 02:16:00PM +0100, Paul Bolle wrote: > > 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b > > ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). > > Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART > > was intended here. > > Thanks for the fixing. Above comment should really be in the commit > log. I just applied the patch as below. Thanks for updating the commit explanation. I guess I'll have to reserve the "one line commit summary only" style for the really obvious typos. Paul Bolle
On Mon, 2013-03-11 at 10:41 -0300, Fabio Estevam wrote: > Please see my commit: > > commit 7356420cd34e40fe27bf26555b0bf3f2849a43dd > Author: Fabio Estevam <fabio.estevam@freescale.com> > Date: Tue Jan 22 10:40:55 2013 -0200 > > ARM: imx: Remove mx508 support > > Only mx508 based board is mach-mx50_rdp and it has been marked as BROKEN > for several releases. > > mx508 currently lacks clock support. > > In case someone needs to add mx508 support back, then the > recommended approach > is to use device tree. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > ,it does remove the MX50 reference, so this patch is not needed. That's not correct: $ git grep -n DEBUG_IMX50_IMX53_UART v3.9-rc2 v3.9-rc2:arch/arm/Kconfig.debug:495: DEBUG_IMX50_IMX53_UART || \ Paul Bolle
On Mon, Mar 11, 2013 at 10:47 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > That's not correct: > $ git grep -n DEBUG_IMX50_IMX53_UART v3.9-rc2 > v3.9-rc2:arch/arm/Kconfig.debug:495: DEBUG_IMX50_IMX53_UART || \ Yes, you are right. I missed to remove one entry.
On Mon, 2013-03-11 at 10:50 -0300, Fabio Estevam wrote:
> I missed to remove one entry.
Actually, your patch was fine. DEBUG_IMX50_IMX53_UART returned a bit
later - and by accident - in commit
f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b ("ARM: imx: support DEBUG_LL
uart port selection for all i.MX SoCs").
Paul Bolle
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index acdddda..ecfcdba 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -492,7 +492,7 @@ config DEBUG_IMX_UART_PORT DEBUG_IMX31_UART || \ DEBUG_IMX35_UART || \ DEBUG_IMX51_UART || \ - DEBUG_IMX50_IMX53_UART || \ + DEBUG_IMX53_UART || \ DEBUG_IMX6Q_UART default 1 help
Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Tested by grepping the tree. 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). Looking at that patch and at the tree makes clear that DEBUG_IMX53_UART was intended here. arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)