| Message ID | 1362940391-8338-2-git-send-email-mpa@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Markus, On Sun, Mar 10, 2013 at 3:33 PM, Markus Pargmann <mpa@pengutronix.de> wrote: > From: Sascha Hauer <s.hauer@pengutronix.de> > > This device supports multiple rates as described in later AC97 > standards. This patch allows playback of different sample frequencies > without conversion. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > --- > sound/soc/fsl/imx-ssi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Currently we have the following ssi drivers for imx: sound/soc/fsl/imx-ssi.c: for i.mx SoCs running on non-dt platform sound/soc/fsl/fsl_ssi.c: for PowerPC and i.mx SoCs running on dt platforms I see that in this series you convert sound/soc/fsl/imx-ssi.c into dt. Shouldn't we use sound/soc/fsl/fsl_ssi.c instead and maybe even get rid of sound/soc/fsl/imx-ssi.c when all imx become converted to dt?
Hi Fabio, On Sun, Mar 10, 2013 at 03:47:10PM -0300, Fabio Estevam wrote: > Hi Markus, > > On Sun, Mar 10, 2013 at 3:33 PM, Markus Pargmann <mpa@pengutronix.de> wrote: > > From: Sascha Hauer <s.hauer@pengutronix.de> > > > > This device supports multiple rates as described in later AC97 > > standards. This patch allows playback of different sample frequencies > > without conversion. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > --- > > sound/soc/fsl/imx-ssi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Currently we have the following ssi drivers for imx: > > sound/soc/fsl/imx-ssi.c: for i.mx SoCs running on non-dt platform > sound/soc/fsl/fsl_ssi.c: for PowerPC and i.mx SoCs running on dt platforms > > I see that in this series you convert sound/soc/fsl/imx-ssi.c into dt. > > Shouldn't we use sound/soc/fsl/fsl_ssi.c instead and maybe even get > rid of sound/soc/fsl/imx-ssi.c when all imx become converted to dt? > At the moment fsl-ssi and imx-ssi don't seem to have very much in common. However I could try to merge the imx-ssi driver code into fsl_ssi and make it handle imx27-ssi differently. Regards, Markus
On Sun, Mar 10, 2013 at 07:33:02PM +0100, Markus Pargmann wrote: > From: Sascha Hauer <s.hauer@pengutronix.de> > > This device supports multiple rates as described in later AC97 > standards. This patch allows playback of different sample frequencies > without conversion. Applied, but some notes about why this is already supported would be useful and *always* use subject lines appropriate for the subsystem.
On Mon, Mar 11, 2013 at 2:51 PM, Markus Pargmann <mpa@pengutronix.de> wrote: > > At the moment fsl-ssi and imx-ssi don't seem to have very much in > common. However I could try to merge the imx-ssi driver code into > fsl_ssi and make it handle imx27-ssi differently. imx-ssi is the legacy driver that supports older, non-DT IMX platforms. fsl-ssi is the "new" driver that supports PowerPC and IMX DT-enabled platforms.
On Wed, Mar 13, 2013 at 05:55:24PM -0500, Timur Tabi wrote: > On Mon, Mar 11, 2013 at 2:51 PM, Markus Pargmann <mpa@pengutronix.de> wrote: > > > > At the moment fsl-ssi and imx-ssi don't seem to have very much in > > common. However I could try to merge the imx-ssi driver code into > > fsl_ssi and make it handle imx27-ssi differently. > > imx-ssi is the legacy driver that supports older, non-DT IMX platforms. > fsl-ssi is the "new" driver that supports PowerPC and IMX DT-enabled platforms. Okay, I will use the fsl-ssi driver then. Thanks Markus
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c index 55464a5..7ee0147 100644 --- a/sound/soc/fsl/imx-ssi.c +++ b/sound/soc/fsl/imx-ssi.c @@ -400,7 +400,7 @@ static struct snd_soc_dai_driver imx_ac97_dai = { .stream_name = "AC97 Playback", .channels_min = 2, .channels_max = 2, - .rates = SNDRV_PCM_RATE_48000, + .rates = SNDRV_PCM_RATE_8000_48000, .formats = SNDRV_PCM_FMTBIT_S16_LE, }, .capture = {