diff mbox

OMAP OneNAND: add missing __devexit_p wrappers

Message ID 49F852EB.1080701@nokia.com (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Adrian Hunter April 29, 2009, 1:15 p.m. UTC 
Mika Korhonen wrote:
> The patch follows as attachment as gmail damages whitespaces and
> git-send-mail is right now out of question.

This goes via MTD mailing list.

Comments

David Brownell April 29, 2009, 5:55 p.m. UTC | #1 
On Wednesday 29 April 2009, Adrian Hunter wrote:
> +       .shutdown       = __devexit_p(omap2_onenand_shutdown),

That looks wrong.  Shutdown functions shouldn't get discarded
like exit functions.  I'd think the fix for that would be taking
away any __devexit annotation on the shutdown function.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

From b72b537ff229a8d62540569bc543c419702ecb05 Mon Sep 17 00:00:00 2001
From: Mika Korhonen <mika.j.korhonen@gmail.com>
Date: Wed, 29 Apr 2009 14:10:34 +0300
Subject: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers

Fixes build in configurations where devexit functions get discarded

Signed-off-by: Mika Korhonen <mika.j.korhonen@gmail.com>
---
 drivers/mtd/onenand/omap2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index f2e9de1..4882935 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -778,8 +778,8 @@  static int __devexit omap2_onenand_remove(struct platform_device *pdev)
 
 static struct platform_driver omap2_onenand_driver = {
 	.probe		= omap2_onenand_probe,
-	.remove		= omap2_onenand_remove,
-	.shutdown	= omap2_onenand_shutdown,
+	.remove		= __devexit_p(omap2_onenand_remove),
+	.shutdown	= __devexit_p(omap2_onenand_shutdown),
 	.driver		= {
 		.name	= DRIVER_NAME,
 		.owner  = THIS_MODULE,
-- 
1.5.6.5