| Message ID | 513C0280.7040004@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
is there any member to help checking and applying it ? this issue is repeated again by randconfig make, today. ? 2013?03?10? 11:48, Chen Gang ??: > > prate is not defined, will cause compiling issue. > need use parent_rate instead of prate. > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > drivers/clk/clk-vt8500.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > index b5538bb..09c6331 100644 > --- a/drivers/clk/clk-vt8500.c > +++ b/drivers/clk/clk-vt8500.c > @@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, > divisor = parent_rate / rate; > > /* If prate / rate would be decimal, incr the divisor */ > - if (rate * divisor < *prate) > + if (rate * divisor < parent_rate) > divisor++; > > if (divisor == cdev->div_mask + 1) >
On Thu, 2013-03-14 at 17:01 +0800, Chen Gang wrote: > is there any member to help checking and applying it ? > > this issue is repeated again by randconfig make, today. > > > ? 2013?03?10? 11:48, Chen Gang ??: > > > > prate is not defined, will cause compiling issue. > > need use parent_rate instead of prate. > > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > > --- > > drivers/clk/clk-vt8500.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > > index b5538bb..09c6331 100644 > > --- a/drivers/clk/clk-vt8500.c > > +++ b/drivers/clk/clk-vt8500.c > > @@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, > > divisor = parent_rate / rate; > > > > /* If prate / rate would be decimal, incr the divisor */ > > - if (rate * divisor < *prate) > > + if (rate * divisor < parent_rate) > > divisor++; > > > > if (divisor == cdev->div_mask + 1) > > > > The patch for this is in Mike's clk-fixes branch. Regards Tony Prisk
? 2013?03?15? 01:48, Tony Prisk ??: > On Thu, 2013-03-14 at 17:01 +0800, Chen Gang wrote: >> > is there any member to help checking and applying it ? >> > >> > this issue is repeated again by randconfig make, today. >> > >> > >> > ? 2013?03?10? 11:48, Chen Gang ??: >>> > > >>> > > prate is not defined, will cause compiling issue. >>> > > need use parent_rate instead of prate. >>> > > >>> > > Signed-off-by: Chen Gang <gang.chen@asianux.com> >>> > > --- >>> > > drivers/clk/clk-vt8500.c | 2 +- >>> > > 1 files changed, 1 insertions(+), 1 deletions(-) >>> > > >>> > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c >>> > > index b5538bb..09c6331 100644 >>> > > --- a/drivers/clk/clk-vt8500.c >>> > > +++ b/drivers/clk/clk-vt8500.c >>> > > @@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, >>> > > divisor = parent_rate / rate; >>> > > >>> > > /* If prate / rate would be decimal, incr the divisor */ >>> > > - if (rate * divisor < *prate) >>> > > + if (rate * divisor < parent_rate) >>> > > divisor++; >>> > > >>> > > if (divisor == cdev->div_mask + 1) >>> > > >> > >> > > The patch for this is in Mike's clk-fixes branch. thanks. hope to integrate next-* tree soon. :-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index b5538bb..09c6331 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, divisor = parent_rate / rate; /* If prate / rate would be decimal, incr the divisor */ - if (rate * divisor < *prate) + if (rate * divisor < parent_rate) divisor++; if (divisor == cdev->div_mask + 1)
prate is not defined, will cause compiling issue. need use parent_rate instead of prate. Signed-off-by: Chen Gang <gang.chen@asianux.com> --- drivers/clk/clk-vt8500.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)