diff mbox

[1/3] backlight: ep93xx_bl: fix section mismatch

Message ID 201303151803.08774.hartleys@visionengravers.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hartley Sweeten March 16, 2013, 1:03 a.m. UTC
Remove the __init tag from ep93xxbl_probe() to fix the section
mismatch warning.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ryan Mallon <rmallon@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
 drivers/video/backlight/ep93xx_bl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ryan Mallon March 16, 2013, 2:19 a.m. UTC | #1
On 16/03/13 12:03, H Hartley Sweeten wrote:

> Remove the __init tag from ep93xxbl_probe() to fix the section
> mismatch warning.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>


There is a patch for this already queued in Andrew Morton's tree.

~Ryan

> ---
>  drivers/video/backlight/ep93xx_bl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index ef3e21e..17b8abb 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
>  	.get_brightness	= ep93xxbl_get_brightness,
>  };
>  
> -static int __init ep93xxbl_probe(struct platform_device *dev)
> +static int ep93xxbl_probe(struct platform_device *dev)
>  {
>  	struct ep93xxbl *ep93xxbl;
>  	struct backlight_device *bl;
> @@ -145,7 +145,6 @@ static struct platform_driver ep93xxbl_driver = {
>  	.suspend	= ep93xxbl_suspend,
>  	.resume		= ep93xxbl_resume,
>  };
> -
>  module_platform_driver(ep93xxbl_driver);
>  
>  MODULE_DESCRIPTION("EP93xx Backlight Driver");


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hartley Sweeten March 18, 2013, 5:51 p.m. UTC | #2
On Friday, March 15, 2013 7:20 PM, Ryan Mallon wrote:
> On 16/03/13 12:03, H Hartley Sweeten wrote:

>

>> Remove the __init tag from ep93xxbl_probe() to fix the section

>> mismatch warning.

>> 

>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

>> Cc: Ryan Mallon <rmallon@gmail.com>

>> Cc: Richard Purdie <rpurdie@rpsys.net>

>> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

>

>

> There is a patch for this already queued in Andrew Morton's tree.


Ah, missed that one. Please drop patch 1/3.

The other two, as well as the compile bug fix for ep93xx_fb.c should still
be ok. The bug fix patch is probably valid for stable as appropriate.

[PATCH] video: ep93xx_fb: include <linux/io.h> for devm_ioremap()
[PATCH 2/3] video: ep93xx-fb.c: fix section mismatch and use module_platform_driver
[PATCH 3/3] misc: ep93xx_pwm.c: fix section mismatch and use module_platform_driver

Thanks,
Hartley
diff mbox

Patch

diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index ef3e21e..17b8abb 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -60,7 +60,7 @@  static const struct backlight_ops ep93xxbl_ops = {
 	.get_brightness	= ep93xxbl_get_brightness,
 };
 
-static int __init ep93xxbl_probe(struct platform_device *dev)
+static int ep93xxbl_probe(struct platform_device *dev)
 {
 	struct ep93xxbl *ep93xxbl;
 	struct backlight_device *bl;
@@ -145,7 +145,6 @@  static struct platform_driver ep93xxbl_driver = {
 	.suspend	= ep93xxbl_suspend,
 	.resume		= ep93xxbl_resume,
 };
-
 module_platform_driver(ep93xxbl_driver);
 
 MODULE_DESCRIPTION("EP93xx Backlight Driver");