| Message ID | 1363719573-20926-9-git-send-email-achew@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/19/2013 12:59 PM, Andrew Chew wrote: > The pwm-backlight driver now takes a mandatory regulator that is gotten > during driver probe. Initialize a dummy regulator to satisfy this > requirement. I assume these patches will get merged through the PWM tree? If so, Acked-by: Stephen Warren <swarren@nvidia.com>
On Tue, Mar 19, 2013 at 11:59:32AM -0700, Andrew Chew wrote: > The pwm-backlight driver now takes a mandatory regulator that is gotten > during driver probe. Initialize a dummy regulator to satisfy this > requirement. > > Signed-off-by: Andrew Chew <achew@nvidia.com> > --- > arch/arm/boot/dts/tegra20-medcom-wide.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/tegra20-medcom-wide.dts b/arch/arm/boot/dts/tegra20-medcom-wide.dts > index a2d6d65..bf7fdd7 100644 > --- a/arch/arm/boot/dts/tegra20-medcom-wide.dts > +++ b/arch/arm/boot/dts/tegra20-medcom-wide.dts > @@ -26,12 +26,18 @@ > }; > }; > > + bl_en: fixed-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "bl-en-supply"; > + }; This should go into the top-level regulators node which this DTS inherits from tegra20-tamonten.dtsi. I think it'd be nice to rename it to something like backlight_reg for consistency with other regulators in that node. Thierry
diff --git a/arch/arm/boot/dts/tegra20-medcom-wide.dts b/arch/arm/boot/dts/tegra20-medcom-wide.dts index a2d6d65..bf7fdd7 100644 --- a/arch/arm/boot/dts/tegra20-medcom-wide.dts +++ b/arch/arm/boot/dts/tegra20-medcom-wide.dts @@ -26,12 +26,18 @@ }; }; + bl_en: fixed-regulator { + compatible = "regulator-fixed"; + regulator-name = "bl-en-supply"; + }; + backlight { compatible = "pwm-backlight"; pwms = <&pwm 0 5000000>; brightness-levels = <0 4 8 16 32 64 128 255>; default-brightness-level = <6>; + enable-supply = <&bl_en>; }; sound {
The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. Signed-off-by: Andrew Chew <achew@nvidia.com> --- arch/arm/boot/dts/tegra20-medcom-wide.dts | 6 ++++++ 1 file changed, 6 insertions(+)