| Message ID | 1361373527-21695-5-git-send-email-santosh.shilimkar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > This was added with intial port where OMAP PM support wasn't existing > and only simple WFI based hooks were used. > > This should have been cleaned up while adding the PM support but some > how fall through cracks. Changelog describes a bit of history, but does not it's no longer needed. Kevin > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > --- > arch/arm/mach-omap2/omap-hotplug.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c > index e712d17..458f72f 100644 > --- a/arch/arm/mach-omap2/omap-hotplug.c > +++ b/arch/arm/mach-omap2/omap-hotplug.c > @@ -19,11 +19,8 @@ > #include <linux/smp.h> > #include <linux/io.h> > > -#include <asm/cacheflush.h> > #include "omap-wakeupgen.h" > - > #include "common.h" > - > #include "powerdomain.h" > > /* > @@ -35,9 +32,6 @@ void __ref omap4_cpu_die(unsigned int cpu) > unsigned int boot_cpu = 0; > void __iomem *base = omap_get_wakeupgen_base(); > > - flush_cache_all(); > - dsb(); > - > /* > * we're ready for shutdown now, so do it > */
On Thursday 28 March 2013 12:13 AM, Kevin Hilman wrote: > Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > >> This was added with intial port where OMAP PM support wasn't existing >> and only simple WFI based hooks were used. >> >> This should have been cleaned up while adding the PM support but some >> how fall through cracks. > > Changelog describes a bit of history, but does not it's no longer > needed. > I thought "This should have been cleaned up while adding PM support" means its no longer needed. At least I meant that way. Anyway I will just make it explicit. Regards, Santosh
diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c index e712d17..458f72f 100644 --- a/arch/arm/mach-omap2/omap-hotplug.c +++ b/arch/arm/mach-omap2/omap-hotplug.c @@ -19,11 +19,8 @@ #include <linux/smp.h> #include <linux/io.h> -#include <asm/cacheflush.h> #include "omap-wakeupgen.h" - #include "common.h" - #include "powerdomain.h" /* @@ -35,9 +32,6 @@ void __ref omap4_cpu_die(unsigned int cpu) unsigned int boot_cpu = 0; void __iomem *base = omap_get_wakeupgen_base(); - flush_cache_all(); - dsb(); - /* * we're ready for shutdown now, so do it */
This was added with intial port where OMAP PM support wasn't existing and only simple WFI based hooks were used. This should have been cleaned up while adding the PM support but some how fall through cracks. Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/mach-omap2/omap-hotplug.c | 6 ------ 1 file changed, 6 deletions(-)