diff mbox

[v2,10/11] ARM i.MX53: Add LDB device to device tree

Message ID 1364405445-5271-11-git-send-email-p.zabel@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Philipp Zabel March 27, 2013, 5:30 p.m. UTC 
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 arch/arm/boot/dts/imx53.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Comments

Martin Fuzzey March 27, 2013, 6:43 p.m. UTC | #1 
On 27/03/13 18:30, Philipp Zabel wrote:
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>   arch/arm/boot/dts/imx53.dtsi | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index b07bbdcc..30aed40 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -511,6 +511,33 @@
>   				reg = <0x53fa8000 0xc>;
>   			};
>   
> +			ldb: ldb@53fa8008 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,imx53-ldb";
> +				reg = <0x53fa8008 0x4>;
> +				gpr = <&gpr>;
> +				clocks = <&clks 122>, <&clks 120>,
> +					 <&clks 115>, <&clks 116>,
> +					 <&clks 123>, <&clks 85>;
> +				clock-names = "di0_pll", "di1_pll",
> +					      "di0_sel", "di1_sel",
> +					      "di0", "di1";
> +				status = "disabled";
> +
> +				lvds-channel@0 {
> +					reg = <0>;
> +					crtcs = <&ipu 0>;
> +					status = "disabled";
> +				};
> +
> +				lvds-channel@1 {
> +					reg = <1>;
> +					crtcs = <&ipu 1>;
> +					status = "disabled";
> +				};
> +			};
> +
>   			pwm1: pwm@53fb4000 {
>   				#pwm-cells = <2>;
>   				compatible = "fsl,imx53-pwm", "fsl,imx27-pwm";
Maybe pinctrl entries should also be added?

Regards,

Martin
Shawn Guo March 28, 2013, 7:32 a.m. UTC | #2 
On Wed, Mar 27, 2013 at 07:43:40PM +0100, Martin Fuzzey wrote:
> On 27/03/13 18:30, Philipp Zabel wrote:
> >Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >---
> >  arch/arm/boot/dts/imx53.dtsi | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> >index b07bbdcc..30aed40 100644
> >--- a/arch/arm/boot/dts/imx53.dtsi
> >+++ b/arch/arm/boot/dts/imx53.dtsi
> >@@ -511,6 +511,33 @@
> >  				reg = <0x53fa8000 0xc>;
> >  			};
> >+			ldb: ldb@53fa8008 {
> >+				#address-cells = <1>;
> >+				#size-cells = <0>;
> >+				compatible = "fsl,imx53-ldb";
> >+				reg = <0x53fa8008 0x4>;
> >+				gpr = <&gpr>;
> >+				clocks = <&clks 122>, <&clks 120>,
> >+					 <&clks 115>, <&clks 116>,
> >+					 <&clks 123>, <&clks 85>;
> >+				clock-names = "di0_pll", "di1_pll",
> >+					      "di0_sel", "di1_sel",
> >+					      "di0", "di1";
> >+				status = "disabled";
> >+
> >+				lvds-channel@0 {
> >+					reg = <0>;
> >+					crtcs = <&ipu 0>;
> >+					status = "disabled";
> >+				};
> >+
> >+				lvds-channel@1 {
> >+					reg = <1>;
> >+					crtcs = <&ipu 1>;
> >+					status = "disabled";
> >+				};
> >+			};
> >+
> >  			pwm1: pwm@53fb4000 {
> >  				#pwm-cells = <2>;
> >  				compatible = "fsl,imx53-pwm", "fsl,imx27-pwm";
> Maybe pinctrl entries should also be added?

Generally, the pinctrl entries should be added in <board>.dts.

Shawn
Martin Fuzzey March 28, 2013, 8:41 a.m. UTC | #3 
On 28/03/13 08:32, Shawn Guo wrote:
> On Wed, Mar 27, 2013 at 07:43:40PM +0100, Martin Fuzzey wrote:
>>
>> Maybe pinctrl entries should also be added?
> Generally, the pinctrl entries should be added in <board>.dts.

Yes sorry I meant the pinctrl groups under the iomuxc node.

Regards,
Martin
Philipp Zabel March 28, 2013, 9:58 a.m. UTC | #4 
Am Donnerstag, den 28.03.2013, 09:41 +0100 schrieb Martin Fuzzey:
> On 28/03/13 08:32, Shawn Guo wrote:
> > On Wed, Mar 27, 2013 at 07:43:40PM +0100, Martin Fuzzey wrote:
> >>
> >> Maybe pinctrl entries should also be added?
> > Generally, the pinctrl entries should be added in <board>.dts.
> 
> Yes sorry I meant the pinctrl groups under the iomuxc node.

I'm not fond of putting each and every possible pin group configuration
into the dtsi. But since there is only one possibility to multiplex each
of the LVDS0 and LVDS1 pads on i.MX53, I wouldn't resist:

ldb {
	pinctrl_lvds0_1: lvds0grp-1 {
		fsl,pins = <
			730 0x80000000	/* MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3 */
			732 0x80000000	/* MX53_PAD_LVDS0_CLK_P__LDB_LVDS0_CLK */
			734 0x80000000	/* MX53_PAD_LVDS0_TX2_P__LDB_LVDS0_TX2 */
			736 0x80000000	/* MX53_PAD_LVDS0_TX1_P__LDB_LVDS0_TX1 */
			738 0x80000000	/* MX53_PAD_LVDS0_TX0_P__LDB_LVDS0_TX0 */
		>;
	};

	pinctrl_lvds1_1: lvds1grp-1 {
		fsl,pins = <
			720 0x80000000	/* MX53_PAD_LVDS1_TX3_P__LDB_LVDS1_TX3 */
			722 0x80000000	/* MX53_PAD_LVDS1_TX2_P__LDB_LVDS1_TX2 */
			724 0x80000000	/* MX53_PAD_LVDS1_CLK_P__LDB_LVDS1_CLK */
			726 0x80000000	/* MX53_PAD_LVDS1_TX1_P__LDB_LVDS1_TX1 */
			728 0x80000000	/* MX53_PAD_LVDS1_TX0_P__LDB_LVDS1_TX0 */
		>;
	};
};

regards
Philipp
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index b07bbdcc..30aed40 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -511,6 +511,33 @@ 
 				reg = <0x53fa8000 0xc>;
 			};
 
+			ldb: ldb@53fa8008 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,imx53-ldb";
+				reg = <0x53fa8008 0x4>;
+				gpr = <&gpr>;
+				clocks = <&clks 122>, <&clks 120>,
+					 <&clks 115>, <&clks 116>,
+					 <&clks 123>, <&clks 85>;
+				clock-names = "di0_pll", "di1_pll",
+					      "di0_sel", "di1_sel",
+					      "di0", "di1";
+				status = "disabled";
+
+				lvds-channel@0 {
+					reg = <0>;
+					crtcs = <&ipu 0>;
+					status = "disabled";
+				};
+
+				lvds-channel@1 {
+					reg = <1>;
+					crtcs = <&ipu 1>;
+					status = "disabled";
+				};
+			};
+
 			pwm1: pwm@53fb4000 {
 				#pwm-cells = <2>;
 				compatible = "fsl,imx53-pwm", "fsl,imx27-pwm";