diff mbox

arm: mvebu: Add GPIO LEDs to Mirabox board

Message ID 1364523024-20306-1-git-send-email-ryan@presslab.us (mailing list archive)
State New, archived
Headers show

Commit Message

Ryan Press March 29, 2013, 2:10 a.m. UTC
Add the three external LED definitions to the device tree file on
the Mirabox.

The Mirabox user guide calls out one as a power LED, and the other
two are defined for WiFi, but as the current mwifiex drivers don't
have LED support, we make them status LEDs.

These have been tested working by writing to the appropriate
/sys/class/leds trigger.

Signed-off-by: Ryan Press <ryan@presslab.us>
---
 arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

Comments

Neil Greatorex March 29, 2013, 7:24 a.m. UTC | #1
On Thu, 28 Mar 2013, Ryan Press wrote:

> Add the three external LED definitions to the device tree file on
> the Mirabox.
>
> The Mirabox user guide calls out one as a power LED, and the other
> two are defined for WiFi, but as the current mwifiex drivers don't
> have LED support, we make them status LEDs.
>
> These have been tested working by writing to the appropriate
> /sys/class/leds trigger.
>
> Signed-off-by: Ryan Press <ryan@presslab.us>
> ---
> arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)

Tested-by: Neil Greatorex <neil@fatboyfat.co.uk>

Cheers,
Neil
Ezequiel Garcia March 29, 2013, 6:13 p.m. UTC | #2
On Fri, Mar 29, 2013 at 07:24:04AM +0000, Neil Greatorex wrote:
> 
> On Thu, 28 Mar 2013, Ryan Press wrote:
> 
> > Add the three external LED definitions to the device tree file on
> > the Mirabox.
> >
> > The Mirabox user guide calls out one as a power LED, and the other
> > two are defined for WiFi, but as the current mwifiex drivers don't
> > have LED support, we make them status LEDs.
> >
> > These have been tested working by writing to the appropriate
> > /sys/class/leds trigger.
> >
> > Signed-off-by: Ryan Press <ryan@presslab.us>
> > ---
> > arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> 
> Tested-by: Neil Greatorex <neil@fatboyfat.co.uk>
> 

Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Jason Cooper March 31, 2013, 12:24 a.m. UTC | #3
On Thu, Mar 28, 2013 at 07:10:24PM -0700, Ryan Press wrote:
> Add the three external LED definitions to the device tree file on
> the Mirabox.
> 
> The Mirabox user guide calls out one as a power LED, and the other
> two are defined for WiFi, but as the current mwifiex drivers don't
> have LED support, we make them status LEDs.
> 
> These have been tested working by writing to the appropriate
> /sys/class/leds trigger.
> 
> Signed-off-by: Ryan Press <ryan@presslab.us>
> ---
>  arch/arm/boot/dts/armada-370-mirabox.dts | 37 ++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)

Applied to mvebu/dt

thx,

Jason.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/armada-370-mirabox.dts b/arch/arm/boot/dts/armada-370-mirabox.dts
index dd0c57d..242796e 100644
--- a/arch/arm/boot/dts/armada-370-mirabox.dts
+++ b/arch/arm/boot/dts/armada-370-mirabox.dts
@@ -33,6 +33,43 @@ 
 			clock-frequency = <600000000>;
 			status = "okay";
 		};
+
+		pinctrl {
+			pwr_led_pin: pwr-led-pin {
+				marvell,pins = "mpp63";
+				marvell,function = "gpo";
+			};
+
+			stat_led_pins: stat-led-pins {
+				marvell,pins = "mpp64", "mpp65";
+				marvell,function = "gpio";
+			};
+		};
+
+		gpio_leds {
+			compatible = "gpio-leds";
+			pinctrl-names = "default";
+			pinctrl-0 = <&pwr_led_pin &stat_led_pins>;
+
+			green_pwr_led {
+				label = "mirabox:green:pwr";
+				gpios = <&gpio1 31 1>;
+				linux,default-trigger = "heartbeat";
+			};
+
+			blue_stat_led {
+				label = "mirabox:blue:stat";
+				gpios = <&gpio2 0 1>;
+				linux,default-trigger = "cpu0";
+			};
+
+			green_stat_led {
+				label = "mirabox:green:stat";
+				gpios = <&gpio2 1 1>;
+				default-state = "off";
+			};
+		};
+
 		mdio {
 			phy0: ethernet-phy@0 {
 				reg = <0>;