| Message ID | 1361354444-18230-1-git-send-email-santosh.shilimkar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > UART IP slave idle handling now taken care by runtime pm backend(hwmod layer) > so remove the hackery from the driver. > > Tested-by: Vaibhav Bedia <vaibhav.bedia@ti.com> > Tested-by: Sourav Poddar <sourav.poddar@ti.com> > Signed-off-by: Rajendra nayak <rnayak@ti.com> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > > --- > drivers/tty/serial/omap-serial.c | 23 ----------------------- > 1 file changed, 23 deletions(-) This patch should also remove the hooks from <linux/platform_data/serial-omap.h> Kevin
On Wednesday 20 February 2013 08:54 PM, Kevin Hilman wrote: > Santosh Shilimkar <santosh.shilimkar@ti.com> writes: > >> UART IP slave idle handling now taken care by runtime pm backend(hwmod layer) >> so remove the hackery from the driver. >> >> Tested-by: Vaibhav Bedia <vaibhav.bedia@ti.com> >> Tested-by: Sourav Poddar <sourav.poddar@ti.com> >> Signed-off-by: Rajendra nayak <rnayak@ti.com> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> >> >> --- >> drivers/tty/serial/omap-serial.c | 23 ----------------------- >> 1 file changed, 23 deletions(-) > > This patch should also remove the hooks from > <linux/platform_data/serial-omap.h> > Right. Will fix that in next version. Thanks. Regards, Santosh
Hi On Wed, 20 Feb 2013, Santosh Shilimkar wrote: > UART IP slave idle handling now taken care by runtime pm backend(hwmod layer) > so remove the hackery from the driver. > > Tested-by: Vaibhav Bedia <vaibhav.bedia@ti.com> > Tested-by: Sourav Poddar <sourav.poddar@ti.com> > Signed-off-by: Rajendra nayak <rnayak@ti.com> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> I'm fine with the basic idea. But based on rmk's and your subsequent comments, please add some comments to the driver in this patch that encapsulates what needs to be done to get DMA working again properly, including the idle mode switching, in the unlikely event that someone will try to get that working again. - Paul
(and also please add Greg's ack when this is reposted) - Paul
On Sunday 31 March 2013 07:10 AM, Paul Walmsley wrote: > > (and also please add Greg's ack when this is reposted) > > Yes. His ack is already picked up in the pull request I sent. Will add a note about DMA support in the commit. Regards, Santosh
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 57d6b29..5722eaf 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -201,26 +201,6 @@ static int serial_omap_get_context_loss_count(struct uart_omap_port *up) return pdata->get_context_loss_count(up->dev); } -static void serial_omap_set_forceidle(struct uart_omap_port *up) -{ - struct omap_uart_port_info *pdata = up->dev->platform_data; - - if (!pdata || !pdata->set_forceidle) - return; - - pdata->set_forceidle(up->dev); -} - -static void serial_omap_set_noidle(struct uart_omap_port *up) -{ - struct omap_uart_port_info *pdata = up->dev->platform_data; - - if (!pdata || !pdata->set_noidle) - return; - - pdata->set_noidle(up->dev); -} - static void serial_omap_enable_wakeup(struct uart_omap_port *up, bool enable) { struct omap_uart_port_info *pdata = up->dev->platform_data; @@ -279,8 +259,6 @@ static void serial_omap_stop_tx(struct uart_port *port) serial_out(up, UART_IER, up->ier); } - serial_omap_set_forceidle(up); - pm_runtime_mark_last_busy(up->dev); pm_runtime_put_autosuspend(up->dev); } @@ -348,7 +326,6 @@ static void serial_omap_start_tx(struct uart_port *port) pm_runtime_get_sync(up->dev); serial_omap_enable_ier_thri(up); - serial_omap_set_noidle(up); pm_runtime_mark_last_busy(up->dev); pm_runtime_put_autosuspend(up->dev); }