| Message ID | 51529E77.2010906@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello maintainers: when you have time, please help to check this patch whether is OK. thanks. gchen. On 2013?03?27? 15:23, Chen Gang wrote: > > need remove semicolon, or always return true. > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > drivers/gpu/drm/nouveau/nv50_display.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c > index 7f0e6c3..1ddc03e 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.c > +++ b/drivers/gpu/drm/nouveau/nv50_display.c > @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data) > { > struct nv50_display_flip *flip = data; > if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) == > - flip->chan->data); > + flip->chan->data) > return true; > usleep_range(1, 2); > return false; >
Hello Greg KH: when you have time, can you help to check this patch whether OK ? thanks. gchen. On 2013?04?03? 16:01, Chen Gang wrote: > Hello maintainers: > > when you have time, please help to check this patch whether is OK. > > thanks. > > gchen. > > > On 2013?03?27? 15:23, Chen Gang wrote: >> >> need remove semicolon, or always return true. >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> --- >> drivers/gpu/drm/nouveau/nv50_display.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c >> index 7f0e6c3..1ddc03e 100644 >> --- a/drivers/gpu/drm/nouveau/nv50_display.c >> +++ b/drivers/gpu/drm/nouveau/nv50_display.c >> @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data) >> { >> struct nv50_display_flip *flip = data; >> if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) == >> - flip->chan->data); >> + flip->chan->data) >> return true; >> usleep_range(1, 2); >> return false; >> > >
On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > Hello Greg KH: > > when you have time, can you help to check this patch whether OK ? No.
On 2013?04?07? 11:49, Greg KH wrote: > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: >> Hello Greg KH: >> >> when you have time, can you help to check this patch whether OK ? > > No. > > Why ? does it also need a test ??
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: > On 2013?04?07? 11:49, Greg KH wrote: > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > >> Hello Greg KH: > >> when you have time, can you help to check this patch whether OK ? > > No. > Why ? does it also need a test ?? Greg's not the nouveau maintainer/babysitter and likely doesn't have the time/hardware/desire to test it. The patch should be simply be sent to David Airlie and dri-devel. It is a pretty obvious typo though.
thank you very much for your reply, firstly. On 2013?04?07? 12:09, Joe Perches wrote: > On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: >> > On 2013?04?07? 11:49, Greg KH wrote: >>> > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: >>>> > >> Hello Greg KH: >>>> > >> when you have time, can you help to check this patch whether OK ? >>> > > No. >> > Why ? does it also need a test ?? > Greg's not the nouveau maintainer/babysitter and > likely doesn't have the time/hardware/desire to > test it. > > The patch should be simply be sent to David Airlie > and dri-devel. > ok, thanks, it seems, I need a little more patience. :-) > It is a pretty obvious typo though. > I guess so, too. :-)
Dear Chen, Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang: > need remove semicolon, or always return true. do you know if this cause any problems? Did you find this reading the code or by using some tools? > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > drivers/gpu/drm/nouveau/nv50_display.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c > index 7f0e6c3..1ddc03e 100644 > --- a/drivers/gpu/drm/nouveau/nv50_display.c > +++ b/drivers/gpu/drm/nouveau/nv50_display.c > @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data) > { > struct nv50_display_flip *flip = data; > if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) == > - flip->chan->data); > + flip->chan->data) > return true; > usleep_range(1, 2); > return false; Acked-by: Paul Menzel <paulepanter@users.sourceforge.net> Thanks, Paul
On 2013?04?07? 19:24, Paul Menzel wrote: > do you know if this cause any problems? Did you find this reading the > code or by using some tools? sorry, I do not know if this can cause any problems. for this issue, I did not find it by reading code. I find it by using compiler warnings with EXTRA_CFLAGS=-W thanks. :-)
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index 7f0e6c3..1ddc03e 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data) { struct nv50_display_flip *flip = data; if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) == - flip->chan->data); + flip->chan->data) return true; usleep_range(1, 2); return false;
need remove semicolon, or always return true. Signed-off-by: Chen Gang <gang.chen@asianux.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)