| Message ID | 20130408014444.18767.64441.sendpatchset@w520 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 08, 2013 at 10:44:44AM +0900, Magnus Damm wrote: > From: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > > Add 1GiB of DRAM at 0x2_0000_0000 > > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > Signed-off-by: Magnus Damm <damm@opensource.se> Thanks, queued up in the boards-ape6evm branch. > --- > > This patch simply updates the DTS to describe the actual board > hardware. If we want to make use of the memory we also need to > enable LPAE in the kernel configuration, but that is seen as a > separate step. > > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > --- 0001/arch/arm/boot/dts/r8a73a4-ape6evm.dts > +++ work/arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-04-08 10:27:20.000000000 +0900 > @@ -24,6 +24,11 @@ > reg = <0 0x40000000 0 0x40000000>; > }; > > + memory@200000000 { > + device_type = "memory"; > + reg = <2 0x00000000 0 0x40000000>; > + }; > + > ape6evm_fixed_3v3: fixedregulator@0 { > compatible = "regulator-fixed"; > regulator-name = "3V3"; >
On Tue, Apr 09, 2013 at 09:34:34PM +0900, Simon Horman wrote: > On Mon, Apr 08, 2013 at 10:44:44AM +0900, Magnus Damm wrote: > > From: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > > > > Add 1GiB of DRAM at 0x2_0000_0000 > > > > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > > Signed-off-by: Magnus Damm <damm@opensource.se> > > Thanks, queued up in the boards-ape6evm branch. I have dropped this patch as it appears to prevent the board from booting. > > > --- > > > > This patch simply updates the DTS to describe the actual board > > hardware. If we want to make use of the memory we also need to > > enable LPAE in the kernel configuration, but that is seen as a > > separate step. > > > > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > --- 0001/arch/arm/boot/dts/r8a73a4-ape6evm.dts > > +++ work/arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-04-08 10:27:20.000000000 +0900 > > @@ -24,6 +24,11 @@ > > reg = <0 0x40000000 0 0x40000000>; > > }; > > > > + memory@200000000 { > > + device_type = "memory"; > > + reg = <2 0x00000000 0 0x40000000>; > > + }; > > + > > ape6evm_fixed_3v3: fixedregulator@0 { > > compatible = "regulator-fixed"; > > regulator-name = "3V3"; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi Simon, On Wed, Apr 10, 2013 at 1:14 AM, Simon Horman <horms@verge.net.au> wrote: > On Tue, Apr 09, 2013 at 09:34:34PM +0900, Simon Horman wrote: >> On Mon, Apr 08, 2013 at 10:44:44AM +0900, Magnus Damm wrote: >> > From: Takashi Yoshii <takashi.yoshii.zj@renesas.com> >> > >> > Add 1GiB of DRAM at 0x2_0000_0000 >> > >> > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> >> > Signed-off-by: Magnus Damm <damm@opensource.se> >> >> Thanks, queued up in the boards-ape6evm branch. > > I have dropped this patch as it appears to prevent > the board from booting. Is it possible that LPAE=n and HIGHMEM=y in your particular kernel configuration? From what I can tell HIGHMEM is broken in cases of large amounts of memory. Try disabling that as a short-term workaround. Then of course someone needs to track down why the generic code doesn't work as expected. Thanks, / magnus
On Wed, Apr 10, 2013 at 07:27:41AM +0900, Magnus Damm wrote: > Hi Simon, > > On Wed, Apr 10, 2013 at 1:14 AM, Simon Horman <horms@verge.net.au> wrote: > > On Tue, Apr 09, 2013 at 09:34:34PM +0900, Simon Horman wrote: > >> On Mon, Apr 08, 2013 at 10:44:44AM +0900, Magnus Damm wrote: > >> > From: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > >> > > >> > Add 1GiB of DRAM at 0x2_0000_0000 > >> > > >> > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > >> > Signed-off-by: Magnus Damm <damm@opensource.se> > >> > >> Thanks, queued up in the boards-ape6evm branch. > > > > I have dropped this patch as it appears to prevent > > the board from booting. > > Is it possible that LPAE=n and HIGHMEM=y in your particular kernel > configuration? Yes, I have confirmed that is what using the ape6evm_defconfig results in. > >From what I can tell HIGHMEM is broken in cases of large amounts of > memory. Try disabling that as a short-term workaround. Then of course > someone needs to track down why the generic code doesn't work as > expected. I have confirmed that disabling HIGHMEM allows the board to boot with this patch applied. Should I prepare a patch to the defconfig to accompany this patch?
Hi Simon, Arnd, On Wed, Apr 10, 2013 at 9:35 AM, Simon Horman <horms@verge.net.au> wrote: > On Wed, Apr 10, 2013 at 07:27:41AM +0900, Magnus Damm wrote: >> Hi Simon, >> >> On Wed, Apr 10, 2013 at 1:14 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Tue, Apr 09, 2013 at 09:34:34PM +0900, Simon Horman wrote: >> >> On Mon, Apr 08, 2013 at 10:44:44AM +0900, Magnus Damm wrote: >> >> > From: Takashi Yoshii <takashi.yoshii.zj@renesas.com> >> >> > >> >> > Add 1GiB of DRAM at 0x2_0000_0000 >> >> > >> >> > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> >> >> > Signed-off-by: Magnus Damm <damm@opensource.se> >> >> >> >> Thanks, queued up in the boards-ape6evm branch. >> > >> > I have dropped this patch as it appears to prevent >> > the board from booting. >> >> Is it possible that LPAE=n and HIGHMEM=y in your particular kernel >> configuration? > > Yes, I have confirmed that is what using the ape6evm_defconfig results in. > >> >From what I can tell HIGHMEM is broken in cases of large amounts of >> memory. Try disabling that as a short-term workaround. Then of course >> someone needs to track down why the generic code doesn't work as >> expected. > > I have confirmed that disabling HIGHMEM allows the board to boot > with this patch applied. Thanks for checking. So HIGHMEM without LPAE seems busted on boards using more than 32-bits for memory. I'd like to help out fixing this issue, but I'd like to make sure that no one else is working on this. Arnd, are you aware on any work related to making HIGHMEM work without LPAE? > Should I prepare a patch to the defconfig to accompany this patch? I believe that would affect a bunch of boards so I don't think that is necessary at this point. Thanks anyway. Would it be possible for you to queue up this change in a APE6EVM topic branch? Thanks, / magnus
On Wed, Apr 10, 2013 at 10:38:49AM +0900, Magnus Damm wrote: > Hi Simon, Arnd, > > On Wed, Apr 10, 2013 at 9:35 AM, Simon Horman <horms@verge.net.au> wrote: > > On Wed, Apr 10, 2013 at 07:27:41AM +0900, Magnus Damm wrote: > >> Hi Simon, > >> > >> On Wed, Apr 10, 2013 at 1:14 AM, Simon Horman <horms@verge.net.au> wrote: > >> > On Tue, Apr 09, 2013 at 09:34:34PM +0900, Simon Horman wrote: > >> >> On Mon, Apr 08, 2013 at 10:44:44AM +0900, Magnus Damm wrote: > >> >> > From: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > >> >> > > >> >> > Add 1GiB of DRAM at 0x2_0000_0000 > >> >> > > >> >> > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > >> >> > Signed-off-by: Magnus Damm <damm@opensource.se> > >> >> > >> >> Thanks, queued up in the boards-ape6evm branch. > >> > > >> > I have dropped this patch as it appears to prevent > >> > the board from booting. > >> > >> Is it possible that LPAE=n and HIGHMEM=y in your particular kernel > >> configuration? > > > > Yes, I have confirmed that is what using the ape6evm_defconfig results in. oup > > >> >From what I can tell HIGHMEM is broken in cases of large amounts of > >> memory. Try disabling that as a short-term workaround. Then of course > >> someone needs to track down why the generic code doesn't work as > >> expected. > > > > I have confirmed that disabling HIGHMEM allows the board to boot > > with this patch applied. > > Thanks for checking. > > So HIGHMEM without LPAE seems busted on boards using more than 32-bits > for memory. > > I'd like to help out fixing this issue, but I'd like to make sure that > no one else is working on this. > > Arnd, are you aware on any work related to making HIGHMEM work without LPAE? > > > Should I prepare a patch to the defconfig to accompany this patch? > > I believe that would affect a bunch of boards so I don't think that is > necessary at this point. Thanks anyway. > > Would it be possible for you to queue up this change in a APE6EVM topic branch? Sure, I have pushed topic/ape6evm-2gb. I also plan to push topic/ape6evm-2gb+renesas-next-20130410v2 once I have finalised renesas-next-20130410v2.
--- 0001/arch/arm/boot/dts/r8a73a4-ape6evm.dts +++ work/arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-04-08 10:27:20.000000000 +0900 @@ -24,6 +24,11 @@ reg = <0 0x40000000 0 0x40000000>; }; + memory@200000000 { + device_type = "memory"; + reg = <2 0x00000000 0 0x40000000>; + }; + ape6evm_fixed_3v3: fixedregulator@0 { compatible = "regulator-fixed"; regulator-name = "3V3";