| Message ID | 20130417072029.GF7923@elgon.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed 17 April 2013 09:20:30 Dan Carpenter wrote: > Because they're signed, "is_video" and "is_audio" can be 0 and -1 > instead of 0 and 1 as intended. It doesn't cause a bug, but it makes > Sparse complain: > drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield > drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Thanks! Hans > > diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-priv.h > index 8bde187..6e16af7 100644 > --- a/drivers/staging/media/go7007/go7007-priv.h > +++ b/drivers/staging/media/go7007/go7007-priv.h > @@ -91,8 +91,8 @@ struct go7007_board_info { > int num_i2c_devs; > struct go_i2c { > const char *type; > - int is_video:1; > - int is_audio:1; > + unsigned int is_video:1; > + unsigned int is_audio:1; > int addr; > u32 flags; > } i2c_devs[5]; > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/media/go7007/go7007-priv.h b/drivers/staging/media/go7007/go7007-priv.h index 8bde187..6e16af7 100644 --- a/drivers/staging/media/go7007/go7007-priv.h +++ b/drivers/staging/media/go7007/go7007-priv.h @@ -91,8 +91,8 @@ struct go7007_board_info { int num_i2c_devs; struct go_i2c { const char *type; - int is_video:1; - int is_audio:1; + unsigned int is_video:1; + unsigned int is_audio:1; int addr; u32 flags; } i2c_devs[5];
Because they're signed, "is_video" and "is_audio" can be 0 and -1 instead of 0 and 1 as intended. It doesn't cause a bug, but it makes Sparse complain: drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html