| Message ID | 20130422115243.GD10797@arwen.pp.htv.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Monday 22 April 2013 05:22 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 22, 2013 at 11:21:49AM +0300, Felipe Balbi wrote: >>> -Kevin Hilman <khilman@ti.com> >>> +Kevin Hilman <khilman@deeprootsystems.com> >>> >>> On 04/19/2013 07:12 PM, Tony Lindgren wrote: >>>> * Rob Herring <robherring2@gmail.com> [130418 20:11]: >>>>> Current errors in linux-next for ARM multi-platform randconfig builds. >>>>> >>>>> Rob >>>>> >>>>> arch/arm/mach-omap2/built-in.o:dss-common.c:(.init.text+0x6830): more undefined references to `usb_bind_phy' follow >>>> >>>> Felipe & Roger, can you guys take a look at the usb_bind_phy issue >>>> in linux next? I have not seen that in the multiplatform randconfigs >>>> I've built, but I have had some omap2+ specific things enabled there. >>> >>> These problems happen if USB_PHY is not enabled as a built-in driver. >>> I had pointed this out earlier [1] and Felipe should have a fix for it. >> >> yeah, ideally we wouldn't do any 'select' and just update defconfig with >> the necessary changes. We need the patch below to update defconfig and >> another patch to stub out usb_bind_phy when !USB_PHY. > > the stub is already there, this should fix the other part though: Denis had sent a patch for it 4 days back [1]. Lets use that instead. Thanks Kishon [1] - https://patchwork.kernel.org/patch/2460691/
Hi, On Mon, Apr 22, 2013 at 06:15:25PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 22 April 2013 05:22 PM, Felipe Balbi wrote: > >Hi, > > > >On Mon, Apr 22, 2013 at 11:21:49AM +0300, Felipe Balbi wrote: > >>>-Kevin Hilman <khilman@ti.com> > >>>+Kevin Hilman <khilman@deeprootsystems.com> > >>> > >>>On 04/19/2013 07:12 PM, Tony Lindgren wrote: > >>>>* Rob Herring <robherring2@gmail.com> [130418 20:11]: > >>>>>Current errors in linux-next for ARM multi-platform randconfig builds. > >>>>> > >>>>>Rob > >>>>> > >>>>>arch/arm/mach-omap2/built-in.o:dss-common.c:(.init.text+0x6830): more undefined references to `usb_bind_phy' follow > >>>> > >>>>Felipe & Roger, can you guys take a look at the usb_bind_phy issue > >>>>in linux next? I have not seen that in the multiplatform randconfigs > >>>>I've built, but I have had some omap2+ specific things enabled there. > >>> > >>>These problems happen if USB_PHY is not enabled as a built-in driver. > >>>I had pointed this out earlier [1] and Felipe should have a fix for it. > >> > >>yeah, ideally we wouldn't do any 'select' and just update defconfig with > >>the necessary changes. We need the patch below to update defconfig and > >>another patch to stub out usb_bind_phy when !USB_PHY. > > > >the stub is already there, this should fix the other part though: > > Denis had sent a patch for it 4 days back [1]. Lets use that instead. makes sense :-)
diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index f52c006..a9984c7 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -413,7 +413,7 @@ EXPORT_SYMBOL_GPL(usb_remove_phy); * * To be used by platform specific initialization code. */ -int __init usb_bind_phy(const char *dev_name, u8 index, +int usb_bind_phy(const char *dev_name, u8 index, const char *phy_dev_name) { struct usb_phy_bind *phy_bind;