| Message ID | 1364051211-24414-1-git-send-email-sebastian.hesselbarth@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Acked-by: Andrew Lunn <andrew@lunn.ch> > --- > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 2c3bdce..4fc9bca 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -556,7 +556,7 @@ config ARCH_IXP4XX > config ARCH_DOVE > bool "Marvell Dove" > select ARCH_REQUIRE_GPIOLIB > - select CPU_V7 > + select CPU_PJ4 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI > select PINCTRL > -- > 1.7.10.4 >
On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hmmm, I'm getting (with dove_defconfig): arch/arm/kernel/built-in.o: In function `iwmmxt_do': /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' make: *** [vmlinux] Error 1 thx, Jason.
On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote: > On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > > iWMMXt extensions on Dove. > > > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > --- > > Cc: Russell King <linux@arm.linux.org.uk> > > Cc: Jason Cooper <jason@lakedaemon.net> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > --- > > arch/arm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hmmm, I'm getting (with dove_defconfig): > > arch/arm/kernel/built-in.o: In function `iwmmxt_do': > /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' > /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' > make: *** [vmlinux] Error 1 Looks to me like PJ4 IWMMXT support wasn't properly tested out when it was submitted - it's possible to end up with pj4-cp0.c built without the IWMMXT code that it depends on being built...
On 03/28/2013 07:14 PM, Russell King - ARM Linux wrote: > On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote: >> On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: >>> The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using >>> CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable >>> iWMMXt extensions on Dove. >>> >>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> >>> --- >>> Cc: Russell King<linux@arm.linux.org.uk> >>> Cc: Jason Cooper<jason@lakedaemon.net> >>> Cc: Andrew Lunn<andrew@lunn.ch> >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> --- >>> arch/arm/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Hmmm, I'm getting (with dove_defconfig): >> >> arch/arm/kernel/built-in.o: In function `iwmmxt_do': >> /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' >> /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' >> make: *** [vmlinux] Error 1 > > Looks to me like PJ4 IWMMXT support wasn't properly tested out when it > was submitted - it's possible to end up with pj4-cp0.c built without > the IWMMXT code that it depends on being built... Russel, Jason, do we force iWMMXt on CPU_PJ4 or should there be some #ifdef'ery if IWMMXT is not selected? Sebastian
On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sebastian, It looks as though Russell's fix for IWMMXT made it in. Please place this patch in Russell's patch tracker. If you don't have the original thread, Andrew Lunn gave this an Acked-by. Now me as well: Acked-by: Jason Cooper <jason@lakedaemon.net> thx, Jason. > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 2c3bdce..4fc9bca 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -556,7 +556,7 @@ config ARCH_IXP4XX > config ARCH_DOVE > bool "Marvell Dove" > select ARCH_REQUIRE_GPIOLIB > - select CPU_V7 > + select CPU_PJ4 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI > select PINCTRL > -- > 1.7.10.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2c3bdce..4fc9bca 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -556,7 +556,7 @@ config ARCH_IXP4XX config ARCH_DOVE bool "Marvell Dove" select ARCH_REQUIRE_GPIOLIB - select CPU_V7 + select CPU_PJ4 select GENERIC_CLOCKEVENTS select MIGHT_HAVE_PCI select PINCTRL
The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable iWMMXt extensions on Dove. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> --- Cc: Russell King <linux@arm.linux.org.uk> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)