Message ID | 20130514093108.GA15129@arm.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Catalin, On 2013-05-14 10:31, Catalin Marinas wrote: > On Mon, May 13, 2013 at 05:20:55PM +0100, Benoit Lecardonnel wrote: > I think we could put of_clk_init() and of_platform_populate() calls > under the same arch_initcall() just to keep their relative order. > Something like this (could even use arch_initcall_sync in case we get > some other arch_initcall in the future) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > [...] Thanks for the patch, it works: the device is now probed properly. Tested-by: Benoit Lecardonnel <Benoit.Lecardonnel@synopsys.com>
diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 6a9a532..add6ea6 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -282,12 +282,13 @@ void __init setup_arch(char **cmdline_p) #endif } -static int __init arm64_of_clk_init(void) +static int __init arm64_device_init(void) { of_clk_init(NULL); + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); return 0; } -arch_initcall(arm64_of_clk_init); +arch_initcall(arm64_device_init); static DEFINE_PER_CPU(struct cpu, cpu_data); @@ -305,13 +306,6 @@ static int __init topology_init(void) } subsys_initcall(topology_init); -static int __init arm64_device_probe(void) -{ - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); - return 0; -} -device_initcall(arm64_device_probe); - static const char *hwcap_str[] = { "fp", "asimd",