| Message ID | 1369010702.23562.YahooMailNeo@web120304.mail.ne1.yahoo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 20.05.2013 02:45, schrieb Chris Rankin: > ----- Original Message ----- > >> I'm not familar with ir-keytable and the RC core. >> Mauro ? Can you take over ? ;) > This patch seems to "do the right thing"... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-). > > --- linux-3.9/drivers/media/usb/em28xx/em28xx-input.c.orig 2013-05-19 21:18:39.000000000 +0100 > +++ linux-3.9/drivers/media/usb/em28xx/em28xx-input.c 2013-05-20 01:36:51.000000000 +0100 > @@ -417,6 +417,7 @@ > *rc_type = RC_BIT_RC6_0; > } else if (*rc_type & RC_BIT_UNKNOWN) { > *rc_type = RC_BIT_UNKNOWN; > + return 0; > } else { > *rc_type = ir->rc_type; > return -EINVAL; > > This is against 3.9.3. > > Signed-off-by: Chris Rankin <rankincj@yahoo.com> No, this patch is wrong. Updating ir->rc_type with the new value of *rc_type is correct. Regards, Frank -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
----- Original Message ----- > This patch seems to "do the right thing"... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-). > > --- linux-3.9/drivers/media/usb/em28xx/em28xx-input.c.orig 2013-05-19 21:18:39.000000000 +0100 > +++ linux-3.9/drivers/media/usb/em28xx/em28xx-input.c 2013-05-20 01:36:51.000000000 +0100 > @@ -417,6 +417,7 @@ > *rc_type = RC_BIT_RC6_0; > } else if (*rc_type & RC_BIT_UNKNOWN) { > *rc_type = RC_BIT_UNKNOWN; > + return 0; > } else { > *rc_type = ir->rc_type; > return -EINVAL; > > This is against 3.9.3. > > Signed-off-by: Chris Rankin <rankincj@yahoo.com> > No, this patch is wrong. > Updating ir->rc_type with the new value of *rc_type is correct. Well, it restores 3.8 behaviour, i.e. em28xx not clobbering its "RC5" configuration when RC core subsequently calls ir_change_protocol() with *rc_type=RC_BIT_UNKNOWN. The ir->rc_type parameter is new to 3.9, by the looks of things. Cheers, Chris -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-3.9/drivers/media/usb/em28xx/em28xx-input.c.orig 2013-05-19 21:18:39.000000000 +0100 +++ linux-3.9/drivers/media/usb/em28xx/em28xx-input.c 2013-05-20 01:36:51.000000000 +0100 @@ -417,6 +417,7 @@ *rc_type = RC_BIT_RC6_0; } else if (*rc_type & RC_BIT_UNKNOWN) { *rc_type = RC_BIT_UNKNOWN; + return 0; } else { *rc_type = ir->rc_type; return -EINVAL;