| Message ID | 1368702961-4325-21-git-send-email-wsa@the-dreams.de (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
> -----Original Message----- > From: Wolfram Sang [mailto:wsa@the-dreams.de] > Sent: Thursday, May 16, 2013 7:16 PM > To: linux-kernel@vger.kernel.org > Cc: Wolfram Sang; Zhang, Rui; Eduardo Valentin; linux- > pm@vger.kernel.org > Subject: [PATCH 20/33] drivers/thermal: don't check resource with > devm_ioremap_resource > Importance: High > > devm_ioremap_resource does sanity checks on the given resource. No need > to duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> I'd prefer the RFC version, besides, I have two patches to fix armada_thermal.c and spear_thermal.c as well. Thus, RFC version applied to thermal -next tree. Thanks, rui > --- > drivers/thermal/armada_thermal.c | 10 ---------- > drivers/thermal/dove_thermal.c | 4 ---- > drivers/thermal/exynos_thermal.c | 5 ----- > 3 files changed, 19 deletions(-) > > diff --git a/drivers/thermal/armada_thermal.c > b/drivers/thermal/armada_thermal.c > index 5b4d75f..54ffd64 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -169,21 +169,11 @@ static int armada_thermal_probe(struct > platform_device *pdev) > return -ENOMEM; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get platform resource\n"); > - return -ENODEV; > - } > - > priv->sensor = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(priv->sensor)) > return PTR_ERR(priv->sensor); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get platform resource\n"); > - return -ENODEV; > - } > - > priv->control = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(priv->control)) > return PTR_ERR(priv->control); > diff --git a/drivers/thermal/dove_thermal.c > b/drivers/thermal/dove_thermal.c index 4b15a5f..a088d13 100644 > --- a/drivers/thermal/dove_thermal.c > +++ b/drivers/thermal/dove_thermal.c > @@ -149,10 +149,6 @@ static int dove_thermal_probe(struct > platform_device *pdev) > return PTR_ERR(priv->sensor); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get platform resource\n"); > - return -ENODEV; > - } > priv->control = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(priv->control)) > return PTR_ERR(priv->control); > diff --git a/drivers/thermal/exynos_thermal.c > b/drivers/thermal/exynos_thermal.c > index d20ce9e..788b1dd 100644 > --- a/drivers/thermal/exynos_thermal.c > +++ b/drivers/thermal/exynos_thermal.c > @@ -925,11 +925,6 @@ static int exynos_tmu_probe(struct platform_device > *pdev) > INIT_WORK(&data->irq_work, exynos_tmu_work); > > data->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!data->mem) { > - dev_err(&pdev->dev, "Failed to get platform resource\n"); > - return -ENOENT; > - } > - > data->base = devm_ioremap_resource(&pdev->dev, data->mem); > if (IS_ERR(data->base)) > return PTR_ERR(data->base); > -- > 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index 5b4d75f..54ffd64 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -169,21 +169,11 @@ static int armada_thermal_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Failed to get platform resource\n"); - return -ENODEV; - } - priv->sensor = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(priv->sensor)) return PTR_ERR(priv->sensor); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) { - dev_err(&pdev->dev, "Failed to get platform resource\n"); - return -ENODEV; - } - priv->control = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(priv->control)) return PTR_ERR(priv->control); diff --git a/drivers/thermal/dove_thermal.c b/drivers/thermal/dove_thermal.c index 4b15a5f..a088d13 100644 --- a/drivers/thermal/dove_thermal.c +++ b/drivers/thermal/dove_thermal.c @@ -149,10 +149,6 @@ static int dove_thermal_probe(struct platform_device *pdev) return PTR_ERR(priv->sensor); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) { - dev_err(&pdev->dev, "Failed to get platform resource\n"); - return -ENODEV; - } priv->control = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(priv->control)) return PTR_ERR(priv->control); diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c index d20ce9e..788b1dd 100644 --- a/drivers/thermal/exynos_thermal.c +++ b/drivers/thermal/exynos_thermal.c @@ -925,11 +925,6 @@ static int exynos_tmu_probe(struct platform_device *pdev) INIT_WORK(&data->irq_work, exynos_tmu_work); data->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!data->mem) { - dev_err(&pdev->dev, "Failed to get platform resource\n"); - return -ENOENT; - } - data->base = devm_ioremap_resource(&pdev->dev, data->mem); if (IS_ERR(data->base)) return PTR_ERR(data->base);
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- drivers/thermal/armada_thermal.c | 10 ---------- drivers/thermal/dove_thermal.c | 4 ---- drivers/thermal/exynos_thermal.c | 5 ----- 3 files changed, 19 deletions(-)