diff mbox

[2/2] scripts/config: fix assignment of parameters for short version of --*-after options

Message ID f0a94b2157c7bde8ec8a275d2f8f648f2e6b7c47.1368379475.git.chauplac@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Clement Chauplannaz May 12, 2013, 7:08 p.m. UTC
When --*-after options are used, two parameters are parsed from the
command-line before the adequate function is called:
  - the `before' option, after which the new option will be inserted,
  - the name of the option to enable/disable/modularise.

With the short version of --*-after options (namely -E, -D, -M), the
parsing step is not performed which leads to processing unset variables.

Add options -E, -D, -M to the test that triggers assignment of parameters
for --*-after options.

Signed-off-by: Clement Chauplannaz <chauplac@gmail.com>
---
 scripts/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN May 20, 2013, 3:55 p.m. UTC | #1
Clément, All,

On 2013-05-12 21:08 +0200, Clement Chauplannaz spake thusly:
> When --*-after options are used, two parameters are parsed from the
> command-line before the adequate function is called:
>   - the `before' option, after which the new option will be inserted,
>   - the name of the option to enable/disable/modularise.
> 
> With the short version of --*-after options (namely -E, -D, -M), the
> parsing step is not performed which leads to processing unset variables.
> 
> Add options -E, -D, -M to the test that triggers assignment of parameters
> for --*-after options.
> 
> Signed-off-by: Clement Chauplannaz <chauplac@gmail.com>

I've applied this to my tree in the branch yem-kconfig-rc-fixes, for
which I've just sent a pull-request to Michal. Thank you!

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/scripts/config b/scripts/config
index 6b3272e..567120a 100755
--- a/scripts/config
+++ b/scripts/config
@@ -107,7 +107,7 @@  while [ "$1" != "" ] ; do
 		;;
 	--refresh)
 		;;
-	--*-after)
+	--*-after|-E|-D|-M)
 		checkarg "$1"
 		A=$ARG
 		checkarg "$2"