| Message ID | 1369154510-4927-7-git-send-email-sebastian.hesselbarth@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: > This patch adds orion-eth and mvmdio device tree nodes for DT enabled > Dove boards. As there is only one ethernet controller on Dove, a default > phy node is also added with a note to set its reg property on a per-board > basis. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Changelog: > v3->v4: > - convert to new device tree binding > > Cc: David Miller <davem@davemloft.net> > Cc: Lennert Buytenhek <buytenh@wantstofly.org> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/dove-cubox.dts | 7 +++++++ > arch/arm/boot/dts/dove.dtsi | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts > index 7e3065a..02618fa 100644 > --- a/arch/arm/boot/dts/dove-cubox.dts > +++ b/arch/arm/boot/dts/dove-cubox.dts > @@ -49,6 +49,13 @@ > &uart0 { status = "okay"; }; > &sata0 { status = "okay"; }; > &i2c0 { status = "okay"; }; > +&mdio { status = "okay"; }; > +ð { status = "okay"; }; > + > +ðphy { > + compatible = "marvell,88e1310"; > + reg = <1>; > +}; > > &sdio0 { > status = "okay"; > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > index 6cab468..8612658 100644 > --- a/arch/arm/boot/dts/dove.dtsi > +++ b/arch/arm/boot/dts/dove.dtsi > @@ -258,5 +258,40 @@ > dmacap,xor; > }; > }; > + > + mdio: mdio-bus@72004 { > + compatible = "marvell,orion-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x72004 0x84>; > + interrupts = <30>; > + clocks = <&gate_clk 2>; > + status = "disabled"; > + > + ethphy: ethernet-phy { > + device-type = "ethernet-phy"; > + /* set phy address in board file */ > + }; > + }; > + > + eth: ethernet-controller@72000 { > + compatible = "marvell,orion-eth"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x72000 0x4000>; > + clocks = <&gate_clk 2>; > + marvell,tx-checksum-limit = <1600>; > + status = "disabled"; > + > + ethernet-port@0 { > + device_type = "network"; > + compatible = "marvell,orion-eth-port"; > + reg = <0>; > + interrupts = <29>; > + /* overwrite MAC address in bootloader */ > + local-mac-address = [00 00 00 00 00 00]; Hi Sebastian Its probably a good idea to set the local administration bit in this MAC address. i.e. first byte is 02. Andrew
On 05/21/2013 07:48 PM, Andrew Lunn wrote: > On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: >> This patch adds orion-eth and mvmdio device tree nodes for DT enabled >> Dove boards. As there is only one ethernet controller on Dove, a default >> phy node is also added with a note to set its reg property on a per-board >> basis. >> >> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> >> --- ... >> + ethernet-port@0 { >> + device_type = "network"; >> + compatible = "marvell,orion-eth-port"; >> + reg =<0>; >> + interrupts =<29>; >> + /* overwrite MAC address in bootloader */ >> + local-mac-address = [00 00 00 00 00 00]; > > Hi Sebastian > > Its probably a good idea to set the local administration bit in this > MAC address. i.e. first byte is 02. Andrew, we just need an invalid address here to trigger the default behavior of the driver and load the MAC address from its register. As PPC binding documentation also has all zero, I just took it. Sebastian
On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: > On 05/21/2013 07:48 PM, Andrew Lunn wrote: >> On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: >>> This patch adds orion-eth and mvmdio device tree nodes for DT enabled >>> Dove boards. As there is only one ethernet controller on Dove, a default >>> phy node is also added with a note to set its reg property on a per-board >>> basis. >>> >>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> >>> --- > ... >>> + ethernet-port@0 { >>> + device_type = "network"; >>> + compatible = "marvell,orion-eth-port"; >>> + reg =<0>; >>> + interrupts =<29>; >>> + /* overwrite MAC address in bootloader */ >>> + local-mac-address = [00 00 00 00 00 00]; >> >> Hi Sebastian >> >> Its probably a good idea to set the local administration bit in this >> MAC address. i.e. first byte is 02. > > Andrew, > > we just need an invalid address here to trigger the default behavior of > the driver and load the MAC address from its register. As PPC binding > documentation also has all zero, I just took it. The truth is in PPC case, often we set the real mac address with some variables like 'eth[x]addr' in u-boot prompt, then u-boot will parse that value to fill the dtb. At last the associated driver can get the actual mac address from the dtb. And especially for those older u-boot version, even you have to reset the 'local-mac-address' property in dts directly with the real mac address before generate the dtb since the older u-boot have no this ability to fill dtb again before pass the kernel. Tiejun
On 05/22/2013 12:04 PM, tiejun.chen wrote: > On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: >> On 05/21/2013 07:48 PM, Andrew Lunn wrote: >>> On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: >>>> This patch adds orion-eth and mvmdio device tree nodes for DT enabled >>>> Dove boards. As there is only one ethernet controller on Dove, a >>>> default >>>> phy node is also added with a note to set its reg property on a >>>> per-board >>>> basis. >>>> >>>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> >>>> --- >> ... >>>> + ethernet-port@0 { >>>> + device_type = "network"; >>>> + compatible = "marvell,orion-eth-port"; >>>> + reg =<0>; >>>> + interrupts =<29>; >>>> + /* overwrite MAC address in bootloader */ >>>> + local-mac-address = [00 00 00 00 00 00]; >>> >>> Hi Sebastian >>> >>> Its probably a good idea to set the local administration bit in this >>> MAC address. i.e. first byte is 02. >> >> Andrew, >> >> we just need an invalid address here to trigger the default behavior of >> the driver and load the MAC address from its register. As PPC binding >> documentation also has all zero, I just took it. > > The truth is in PPC case, often we set the real mac address with some > variables like 'eth[x]addr' in u-boot prompt, then u-boot will parse > that value to fill the dtb. At last the associated driver can get the > actual mac address from the dtb. And especially for those older u-boot > version, even you have to reset the 'local-mac-address' property in dts > directly with the real mac address before generate the dtb since the > older u-boot have no this ability to fill dtb again before pass the kernel. Tiejun, with Marvell SoCs it is no different, except that there is almost no dtb support in their u-boot. The default behavior of the driver always was to load the MAC address from its register if there is no valid overwrite value. Using an invalid address (and all zero above is invalid) will cause of_get_mac_address() to fail (which we allow), the corresponding platform_data will never be written, and cause the default behavior. We only need an invalid address passed initially on local-mac-address. DT aware boot loader will overwrite but DT agnositic boot loader will not. I can put any invalid MAC address in here, so I have chosen the very first I can think of. Sebastian
On Wed, May 22, 2013 at 12:13:58PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 12:04 PM, tiejun.chen wrote: > >On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: > >>On 05/21/2013 07:48 PM, Andrew Lunn wrote: > >>>On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: > >>>>This patch adds orion-eth and mvmdio device tree nodes for DT enabled > >>>>Dove boards. As there is only one ethernet controller on Dove, a > >>>>default > >>>>phy node is also added with a note to set its reg property on a > >>>>per-board > >>>>basis. > >>>> > >>>>Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> > >>>>--- > >>... > >>>>+ ethernet-port@0 { > >>>>+ device_type = "network"; > >>>>+ compatible = "marvell,orion-eth-port"; > >>>>+ reg =<0>; > >>>>+ interrupts =<29>; > >>>>+ /* overwrite MAC address in bootloader */ > >>>>+ local-mac-address = [00 00 00 00 00 00]; > >>> > >>>Hi Sebastian > >>> > >>>Its probably a good idea to set the local administration bit in this > >>>MAC address. i.e. first byte is 02. > >> > >>Andrew, > >> > >>we just need an invalid address here to trigger the default behavior of > >>the driver and load the MAC address from its register. As PPC binding > >>documentation also has all zero, I just took it. > > > >The truth is in PPC case, often we set the real mac address with some > >variables like 'eth[x]addr' in u-boot prompt, then u-boot will parse > >that value to fill the dtb. At last the associated driver can get the > >actual mac address from the dtb. And especially for those older u-boot > >version, even you have to reset the 'local-mac-address' property in dts > >directly with the real mac address before generate the dtb since the > >older u-boot have no this ability to fill dtb again before pass the kernel. > > Tiejun, > > with Marvell SoCs it is no different, except that there is almost no dtb > support in their u-boot. iirc, our solution to this was to parse the ATAGs for the mac addr and update the appended dtb. This way, module load and unload would work without loosing the mac address. I believe Jason Gunthorpe has a patch to atags_to_fdt() for this... This should allow us to get rid of the clocks hack. thx, Jason.
On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > iirc, our solution to this was to parse the ATAGs for the mac addr and > update the appended dtb. This way, module load and unload would work > without loosing the mac address. I believe Jason Gunthorpe has a patch > to atags_to_fdt() for this... This should allow us to get rid of the > clocks hack. Sorry, no, we don't use ATAGs here, our platforms start the kernel with a correct DTB that has the correct mac address to use. My patch was to have the driver accept it, and I think Sebastian has already got that functionality... Jason
On Wed, May 22, 2013 at 10:59:08AM -0600, Jason Gunthorpe wrote: > On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > > > iirc, our solution to this was to parse the ATAGs for the mac addr and > > update the appended dtb. This way, module load and unload would work > > without loosing the mac address. I believe Jason Gunthorpe has a patch > > to atags_to_fdt() for this... This should allow us to get rid of the > > clocks hack. > > Sorry, no, we don't use ATAGs here, our platforms start the kernel > with a correct DTB that has the correct mac address to use. My patch > was to have the driver accept it, and I think Sebastian has already > got that functionality... Yes, you're right. thx, Jason.
On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: >> iirc, our solution to this was to parse the ATAGs for the mac addr and >> update the appended dtb. This way, module load and unload would work >> without loosing the mac address. I believe Jason Gunthorpe has a patch >> to atags_to_fdt() for this... This should allow us to get rid of the >> clocks hack. > > Sorry, no, we don't use ATAGs here, our platforms start the kernel > with a correct DTB that has the correct mac address to use. My patch > was to have the driver accept it, and I think Sebastian has already > got that functionality... Not neccessary anyway, after talking Jason C in a Kirkwood-only workaround I prepared a patch that reads mac address registers early and stores it in the local-mac-address property. Just tested on Dockstar with gated clocks and modular DT mv643xx_eth. Will append to the DT mv643xx_eth patch set if a v5 will be required or as single patch prior Jason C taking in the ARM part of it otherwise. Sebastian
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > >On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > >>iirc, our solution to this was to parse the ATAGs for the mac addr and > >>update the appended dtb. This way, module load and unload would work > >>without loosing the mac address. I believe Jason Gunthorpe has a patch > >>to atags_to_fdt() for this... This should allow us to get rid of the > >>clocks hack. > > > >Sorry, no, we don't use ATAGs here, our platforms start the kernel > >with a correct DTB that has the correct mac address to use. My patch > >was to have the driver accept it, and I think Sebastian has already > >got that functionality... > > Not neccessary anyway, after talking Jason C in a Kirkwood-only > workaround I prepared a patch that reads mac address registers early > and stores it in the local-mac-address property. Sweet! > Just tested on Dockstar with gated clocks and modular DT mv643xx_eth. > > Will append to the DT mv643xx_eth patch set if a v5 will be required > or as single patch prior Jason C taking in the ARM part of it > otherwise. Please post, in-reply-to v4 is fine. thx, Jason.
On 05/22/2013 07:35 PM, Jason Cooper wrote: > On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: >> On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: >>> On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: >>>> iirc, our solution to this was to parse the ATAGs for the mac addr and >>>> update the appended dtb. This way, module load and unload would work >>>> without loosing the mac address. I believe Jason Gunthorpe has a patch >>>> to atags_to_fdt() for this... This should allow us to get rid of the >>>> clocks hack. >>> >>> Sorry, no, we don't use ATAGs here, our platforms start the kernel >>> with a correct DTB that has the correct mac address to use. My patch >>> was to have the driver accept it, and I think Sebastian has already >>> got that functionality... >> >> Not neccessary anyway, after talking Jason C in a Kirkwood-only >> workaround I prepared a patch that reads mac address registers early >> and stores it in the local-mac-address property. > > Sweet! > >> Just tested on Dockstar with gated clocks and modular DT mv643xx_eth. >> >> Will append to the DT mv643xx_eth patch set if a v5 will be required >> or as single patch prior Jason C taking in the ARM part of it >> otherwise. > > Please post, in-reply-to v4 is fine. Hmm, maybe a little bit too early. While restoring the MAC address now works, another bug arises which I guess is related with phy setup and aneg. Will investigate and update patch set accordingly. Sebastian
On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 07:35 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > >>>On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > >>>>iirc, our solution to this was to parse the ATAGs for the mac addr and > >>>>update the appended dtb. This way, module load and unload would work > >>>>without loosing the mac address. I believe Jason Gunthorpe has a patch > >>>>to atags_to_fdt() for this... This should allow us to get rid of the > >>>>clocks hack. > >>> > >>>Sorry, no, we don't use ATAGs here, our platforms start the kernel > >>>with a correct DTB that has the correct mac address to use. My patch > >>>was to have the driver accept it, and I think Sebastian has already > >>>got that functionality... > >> > >>Not neccessary anyway, after talking Jason C in a Kirkwood-only > >>workaround I prepared a patch that reads mac address registers early > >>and stores it in the local-mac-address property. > > > >Sweet! > > > >>Just tested on Dockstar with gated clocks and modular DT mv643xx_eth. > >> > >>Will append to the DT mv643xx_eth patch set if a v5 will be required > >>or as single patch prior Jason C taking in the ARM part of it > >>otherwise. > > > >Please post, in-reply-to v4 is fine. > > Hmm, maybe a little bit too early. While restoring the MAC address now > works, another bug arises which I guess is related with phy setup > and aneg. > > Will investigate and update patch set accordingly. Cool, chances are, we should be able to take that patch in by itself for this merge window... thx, Jason.
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > Not neccessary anyway, after talking Jason C in a Kirkwood-only > workaround I prepared a patch that reads mac address registers early > and stores it in the local-mac-address property. That sounds great, but, FWIW, our bootloaders don't set the MAC address registers. Does the work around only trigger if the local-mac-address property is 0? Jason
On 05/22/2013 07:48 PM, Jason Cooper wrote: > On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: >> Hmm, maybe a little bit too early. While restoring the MAC address now >> works, another bug arises which I guess is related with phy setup >> and aneg. >> >> Will investigate and update patch set accordingly. > > Cool, chances are, we should be able to take that patch in by itself for > this merge window... Which patch do you mean? The local-mac-address workaround will only be available for DT mv643xx_eth because it uses the DT node to store the MAC. Anyway, I found the bit that caused the other issue. It is the Clk125_Bypass_En bit in PORT_SERIAL_CONTROL1 register. What bothers me about it is: - Only Dove and Kirkwood have the bit, MV78x00 doesn't have it, Orion5x doesn't have the register at all. With ppc mv64x60 I can only guess, but think it is like in Orion5x. - Reset value of that bit should be 0, but after gating clock on Kirkwood it is set to 1 causing wrong port clock to be selected. Also Thomas Petazzoni confirmed that it is set after reset so either FS is wrong about it or BootROM messes with it. - Kirkwood and Dove FS tell me that port link must be down when you change the bit. As I can't be sure about how mv643xx_eth will behave on other platforms except Kirkwood and Dove when writing that register, I tend to force that bit to zero in the driver but only for those two by #ifdefs. Sebastian
On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 07:48 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>Hmm, maybe a little bit too early. While restoring the MAC address now > >>works, another bug arises which I guess is related with phy setup > >>and aneg. > >> > >>Will investigate and update patch set accordingly. > > > >Cool, chances are, we should be able to take that patch in by itself for > >this merge window... > > Which patch do you mean? The local-mac-address workaround will only be > available for DT mv643xx_eth because it uses the DT node to store the > MAC. I thought you were replacing the unconditional ethernet clock grabbing with reading the mac from the registers and updating the dtb? In mach-kirkwood/board-dt.c? confused. :-/ Jason.
On 05/22/2013 08:24 PM, Jason Gunthorpe wrote: > On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: >> Not neccessary anyway, after talking Jason C in a Kirkwood-only >> workaround I prepared a patch that reads mac address registers early >> and stores it in the local-mac-address property. > > That sounds great, but, FWIW, our bootloaders don't set the MAC > address registers. Does the work around only trigger if the > local-mac-address property is 0? I already thought about bootloaders not setting the register, but I will not start parsing 1001 places for a valid MAC only for those. Also reading the MAC address registers is default behavior of mv643xx_eth if no MAC address is passed through platform_data. But you are right, there is plenty of sanity checks in the workaround to ensure that local-mac-address is only overwritten by it when - you are on DT - there is no valid MAC address in that node (of_get_mac_address) - there is a local-mac-address property with a length of 6 bytes So this workaround only applies on DT booted kernels with no mac set in DT. Sebastian
On 05/22/2013 08:49 PM, Jason Cooper wrote: > On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: >> On 05/22/2013 07:48 PM, Jason Cooper wrote: >>> On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: >>>> Hmm, maybe a little bit too early. While restoring the MAC address now >>>> works, another bug arises which I guess is related with phy setup >>>> and aneg. >>>> >>>> Will investigate and update patch set accordingly. >>> >>> Cool, chances are, we should be able to take that patch in by itself for >>> this merge window... >> >> Which patch do you mean? The local-mac-address workaround will only be >> available for DT mv643xx_eth because it uses the DT node to store the >> MAC. > > I thought you were replacing the unconditional ethernet clock grabbing > with reading the mac from the registers and updating the dtb? In > mach-kirkwood/board-dt.c? True. But there is no node for ethernet controllers in kirkwood.dtsi yet. It will be there with mv643xx_eth DT patches applied and that is when the corresponding replacement patch should also be taken in. I was just confused about your referral to the merge window, because I guess it is up to David Miller to decide when/whether to take mv643xx_eth patches in. Sebastian
On Wed, May 22, 2013 at 08:55:01PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 08:49 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 07:48 PM, Jason Cooper wrote: > >>>On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>>>Hmm, maybe a little bit too early. While restoring the MAC address now > >>>>works, another bug arises which I guess is related with phy setup > >>>>and aneg. > >>>> > >>>>Will investigate and update patch set accordingly. > >>> > >>>Cool, chances are, we should be able to take that patch in by itself for > >>>this merge window... > >> > >>Which patch do you mean? The local-mac-address workaround will only be > >>available for DT mv643xx_eth because it uses the DT node to store the > >>MAC. > > > >I thought you were replacing the unconditional ethernet clock grabbing > >with reading the mac from the registers and updating the dtb? In > >mach-kirkwood/board-dt.c? > > True. But there is no node for ethernet controllers in kirkwood.dtsi > yet. It will be there with mv643xx_eth DT patches applied and that is > when the corresponding replacement patch should also be taken in. > > I was just confused about your referral to the merge window, because I > guess it is up to David Miller to decide when/whether to take > mv643xx_eth patches in. Ahh, no, that was me. I was contemplating adding the dt entries in this merge window at one point and must've got my wires crossed. Sorry for the confusion. thx, Jason.
On 05/22/2013 07:48 PM, Jason Cooper wrote: > On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: >> On 05/22/2013 07:35 PM, Jason Cooper wrote: >>> On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: >>>> Just tested on Dockstar with gated clocks and modular DT mv643xx_eth. >>>> >>>> Will append to the DT mv643xx_eth patch set if a v5 will be required >>>> or as single patch prior Jason C taking in the ARM part of it >>>> otherwise. >>> >>> Please post, in-reply-to v4 is fine. >> >> Hmm, maybe a little bit too early. While restoring the MAC address now >> works, another bug arises which I guess is related with phy setup >> and aneg. >> >> Will investigate and update patch set accordingly. Ok, have it working now by properly clearing CLK125_BYPASS_EN bit in PORT_SERIAL_CTRL1 register for Kirkwood only. I have two more patches ready that I will post as single patches in reply to v4. If David gives his ACK for the patch set and names a branch to base it on, I will send a v5 including all patches. Sebastian
diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts index 7e3065a..02618fa 100644 --- a/arch/arm/boot/dts/dove-cubox.dts +++ b/arch/arm/boot/dts/dove-cubox.dts @@ -49,6 +49,13 @@ &uart0 { status = "okay"; }; &sata0 { status = "okay"; }; &i2c0 { status = "okay"; }; +&mdio { status = "okay"; }; +ð { status = "okay"; }; + +ðphy { + compatible = "marvell,88e1310"; + reg = <1>; +}; &sdio0 { status = "okay"; diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi index 6cab468..8612658 100644 --- a/arch/arm/boot/dts/dove.dtsi +++ b/arch/arm/boot/dts/dove.dtsi @@ -258,5 +258,40 @@ dmacap,xor; }; }; + + mdio: mdio-bus@72004 { + compatible = "marvell,orion-mdio"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x72004 0x84>; + interrupts = <30>; + clocks = <&gate_clk 2>; + status = "disabled"; + + ethphy: ethernet-phy { + device-type = "ethernet-phy"; + /* set phy address in board file */ + }; + }; + + eth: ethernet-controller@72000 { + compatible = "marvell,orion-eth"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x72000 0x4000>; + clocks = <&gate_clk 2>; + marvell,tx-checksum-limit = <1600>; + status = "disabled"; + + ethernet-port@0 { + device_type = "network"; + compatible = "marvell,orion-eth-port"; + reg = <0>; + interrupts = <29>; + /* overwrite MAC address in bootloader */ + local-mac-address = [00 00 00 00 00 00]; + phy-handle = <ðphy>; + }; + }; }; };
This patch adds orion-eth and mvmdio device tree nodes for DT enabled Dove boards. As there is only one ethernet controller on Dove, a default phy node is also added with a note to set its reg property on a per-board basis. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> --- Changelog: v3->v4: - convert to new device tree binding Cc: David Miller <davem@davemloft.net> Cc: Lennert Buytenhek <buytenh@wantstofly.org> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/dove-cubox.dts | 7 +++++++ arch/arm/boot/dts/dove.dtsi | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)