diff mbox

[1/1] mmc: of_mmc_spi: fix card detect irq

Message ID 1369571337-9300-1-git-send-email-plagnioj@jcrosoft.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jean-Christophe PLAGNIOL-VILLARD May 26, 2013, 12:28 p.m. UTC
set missing irq type the IRQF_ONESHOT

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: stable <stable@vger.kernel.org> # 3.4+
Cc: linux-mmc@vger.kernel.org
---
 drivers/mmc/host/of_mmc_spi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sergei Shtylyov May 26, 2013, 7:13 p.m. UTC | #1
Hello.

On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:

> set missing irq type the IRQF_ONESHOT
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: stable <stable@vger.kernel.org> # 3.4+
> Cc: linux-mmc@vger.kernel.org
> ---
>   drivers/mmc/host/of_mmc_spi.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index d720b5e..cfb2e61 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
>   {
>   	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>   
> -	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> -				    dev_name(dev), mmc);
> +	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> +		IRQF_ONESHOT, dev_name(dev), mmc);

     Please don't change the indentation.

WBR, Sergei
Jean-Christophe PLAGNIOL-VILLARD May 27, 2013, 2:13 p.m. UTC | #2
On 23:13 Sun 26 May     , Sergei Shtylyov wrote:
> Hello.
> 
> On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> >set missing irq type the IRQF_ONESHOT
> >
> >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >Cc: stable <stable@vger.kernel.org> # 3.4+
> >Cc: linux-mmc@vger.kernel.org
> >---
> >  drivers/mmc/host/of_mmc_spi.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> >index d720b5e..cfb2e61 100644
> >--- a/drivers/mmc/host/of_mmc_spi.c
> >+++ b/drivers/mmc/host/of_mmc_spi.c
> >@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
> >  {
> >  	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
> >-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> >-				    dev_name(dev), mmc);
> >+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> >+		IRQF_ONESHOT, dev_name(dev), mmc);
> 
>     Please don't change the indentation.
too long > 80

Best Regards,
J.
Sergei Shtylyov May 27, 2013, 6:02 p.m. UTC | #3
Hello.

On 27-05-2013 18:13, Jean-Christophe PLAGNIOL-VILLARD wrote:

>>> set missing irq type the IRQF_ONESHOT

>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>>> Cc: stable <stable@vger.kernel.org> # 3.4+
>>> Cc: linux-mmc@vger.kernel.org
>>> ---
>>>   drivers/mmc/host/of_mmc_spi.c |    4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)

>>> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
>>> index d720b5e..cfb2e61 100644
>>> --- a/drivers/mmc/host/of_mmc_spi.c
>>> +++ b/drivers/mmc/host/of_mmc_spi.c
>>> @@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev,
>>>   {
>>>   	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>>> -	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
>>> -				    dev_name(dev), mmc);
>>> +	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
>>> +		IRQF_ONESHOT, dev_name(dev), mmc);

>>      Please don't change the indentation.

> too long > 80

     Reflow it then into several lines.

> Best Regards,
> J.

WBR, Sergei
diff mbox

Patch

diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index d720b5e..cfb2e61 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -74,8 +74,8 @@  static int of_mmc_spi_init(struct device *dev,
 {
 	struct of_mmc_spi *oms = to_of_mmc_spi(dev);
 
-	return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
-				    dev_name(dev), mmc);
+	return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+		IRQF_ONESHOT, dev_name(dev), mmc);
 }
 
 static void of_mmc_spi_exit(struct device *dev, void *mmc)