| Message ID | 1369725661-3114-1-git-send-email-yegorslists@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists@googlemail.com wrote: > From: Yegor Yefremov <yegorslists@googlemail.com> > > 'ick' was changed to 'hsotgusb_ick' > 'fck' was changed to 'hsotgusb_fck' > > Signed-off-by: Jan Luebbe <jlu@pengutronix.de> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> NAK. Fix your clock data.
On Tue, 2013-05-28 at 20:36 +0300, Felipe Balbi wrote: > On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists@googlemail.com wrote: > > From: Yegor Yefremov <yegorslists@googlemail.com> > > > > 'ick' was changed to 'hsotgusb_ick' > > 'fck' was changed to 'hsotgusb_fck' > > > > Signed-off-by: Jan Luebbe <jlu@pengutronix.de> > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > > NAK. Fix your clock data. Yegor, I'm not sure how my signed-off-by got here. It seems that you picked the patch up from this thread: http://marc.info/?l=linux-omap&m=134390141101734 Note that my mail contains no signed-off-by and the change is described as a work around. Regards, Jan
On Wed, May 29, 2013 at 11:36 AM, Jan Lübbe <jlu@pengutronix.de> wrote: > On Tue, 2013-05-28 at 20:36 +0300, Felipe Balbi wrote: >> On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists@googlemail.com wrote: >> > From: Yegor Yefremov <yegorslists@googlemail.com> >> > >> > 'ick' was changed to 'hsotgusb_ick' >> > 'fck' was changed to 'hsotgusb_fck' >> > >> > Signed-off-by: Jan Luebbe <jlu@pengutronix.de> >> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> >> >> NAK. Fix your clock data. > > Yegor, I'm not sure how my signed-off-by got here. It seems that you > picked the patch up from this thread: > http://marc.info/?l=linux-omap&m=134390141101734 > > Note that my mail contains no signed-off-by and the change is described > as a work around. I'll remove your SoB, when I post the next version. I just added it, because you provided the fix. Will contact you next time first. Have you worked on this SoC lately? Any pending patches? Yegor
On Tue, May 28, 2013 at 7:36 PM, Felipe Balbi <balbi@ti.com> wrote: > On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists@googlemail.com wrote: >> From: Yegor Yefremov <yegorslists@googlemail.com> >> >> 'ick' was changed to 'hsotgusb_ick' >> 'fck' was changed to 'hsotgusb_fck' >> >> Signed-off-by: Jan Luebbe <jlu@pengutronix.de> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > > NAK. Fix your clock data. Do you mean here arch/arm/mach-omap2/cclock3xxx_data.c? Yegor
On Wed, May 29, 2013 at 12:06:52PM +0200, Yegor Yefremov wrote: > On Tue, May 28, 2013 at 7:36 PM, Felipe Balbi <balbi@ti.com> wrote: > > On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists@googlemail.com wrote: > >> From: Yegor Yefremov <yegorslists@googlemail.com> > >> > >> 'ick' was changed to 'hsotgusb_ick' > >> 'fck' was changed to 'hsotgusb_fck' > >> > >> Signed-off-by: Jan Luebbe <jlu@pengutronix.de> > >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > > > > NAK. Fix your clock data. > > Do you mean here arch/arm/mach-omap2/cclock3xxx_data.c? yes
diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c index 2231850..92b5b23 100644 --- a/drivers/usb/musb/am35x.c +++ b/drivers/usb/musb/am35x.c @@ -477,14 +477,14 @@ static int am35x_probe(struct platform_device *pdev) goto err1; } - phy_clk = clk_get(&pdev->dev, "fck"); + phy_clk = clk_get(&pdev->dev, "hsotgusb_ick"); if (IS_ERR(phy_clk)) { dev_err(&pdev->dev, "failed to get PHY clock\n"); ret = PTR_ERR(phy_clk); goto err3; } - clk = clk_get(&pdev->dev, "ick"); + clk = clk_get(&pdev->dev, "hsotgusb_fck"); if (IS_ERR(clk)) { dev_err(&pdev->dev, "failed to get clock\n"); ret = PTR_ERR(clk);