| Message ID | 1369232581-18923-8-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, May 22, 2013 at 4:23 PM, Lee Jones <lee.jones@linaro.org> wrote: > Change compatible string to something more standard. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt b/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt > index 9a2f3f4..c3d8a89 100644 > --- a/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt > +++ b/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt > @@ -1,8 +1,8 @@ > ST Ericsson Nomadik pinmux controller > > Required properties: > -- compatible: "stericsson,nmk-pinctrl", "stericsson,nmk-pinctrl-db8540", > - "stericsson,nmk-pinctrl-stn8815" > +- compatible: "stericsson,db8500-pinctrl", "stericsson,db8540-pinctrl", > + "stericsson,stn8815-pinctrl" OK... > pinctrl@80157000 { > - compatible = "stericsson,nmk-pinctrl"; > + compatible = "stericsson,u8500-pinctrl"; This does not look like a supported compatible string? Yours, Linus Walleij
> > Required properties: > > -- compatible: "stericsson,nmk-pinctrl", "stericsson,nmk-pinctrl-db8540", > > - "stericsson,nmk-pinctrl-stn8815" > > +- compatible: "stericsson,db8500-pinctrl", "stericsson,db8540-pinctrl", > > + "stericsson,stn8815-pinctrl" > > OK... > > > pinctrl@80157000 { > > - compatible = "stericsson,nmk-pinctrl"; > > + compatible = "stericsson,u8500-pinctrl"; > > This does not look like a supported compatible string? Do you still think this, or did you change you mind? If so, what makes you think it? How does it differ from: compatible = "arm,cortex-a9-twd-timer"; compatible = "arm,rtc-pl031"; compatible = "stericsson,db8500-gpio", compatible = "stericsson,db8500-musb", compatible = "stericsson,db8500-dma40", compatible = "stericsson,db8500-prcmu"; compatible = "stericsson,db8500-prcmu-timer-4"; compatible = "stericsson,db8500-thermal"; compatible = "stericsson,db8500-prcmu-regulator";
On Tue, May 28, 2013 at 11:38 AM, Lee Jones <lee.jones@linaro.org> wrote: >> > Required properties: >> > -- compatible: "stericsson,nmk-pinctrl", "stericsson,nmk-pinctrl-db8540", >> > - "stericsson,nmk-pinctrl-stn8815" >> > +- compatible: "stericsson,db8500-pinctrl", "stericsson,db8540-pinctrl", >> > + "stericsson,stn8815-pinctrl" >> >> OK... >> >> > pinctrl@80157000 { >> > - compatible = "stericsson,nmk-pinctrl"; >> > + compatible = "stericsson,u8500-pinctrl"; >> >> This does not look like a supported compatible string? > > Do you still think this, or did you change you mind? Que? It is not among the listed compatible strings? > If so, what makes you think it? How does it differ from: > > compatible = "arm,cortex-a9-twd-timer"; > compatible = "arm,rtc-pl031"; > compatible = "stericsson,db8500-gpio", > compatible = "stericsson,db8500-musb", > compatible = "stericsson,db8500-dma40", > compatible = "stericsson,db8500-prcmu"; > compatible = "stericsson,db8500-prcmu-timer-4"; > compatible = "stericsson,db8500-thermal"; > compatible = "stericsson,db8500-prcmu-regulator"; It says u8500-pinctrl, not db8500-pinctrl. Could it be that you're not actually seeing your own typo? Yours, Linus Walleij
On Wed, 29 May 2013, Linus Walleij wrote: > On Tue, May 28, 2013 at 11:38 AM, Lee Jones <lee.jones@linaro.org> wrote: > >> > Required properties: > >> > -- compatible: "stericsson,nmk-pinctrl", "stericsson,nmk-pinctrl-db8540", > >> > - "stericsson,nmk-pinctrl-stn8815" > >> > +- compatible: "stericsson,db8500-pinctrl", "stericsson,db8540-pinctrl", > >> > + "stericsson,stn8815-pinctrl" > >> > >> OK... > >> > >> > pinctrl@80157000 { > >> > - compatible = "stericsson,nmk-pinctrl"; > >> > + compatible = "stericsson,u8500-pinctrl"; > >> > >> This does not look like a supported compatible string? > > > > Do you still think this, or did you change you mind? > > Que? It is not among the listed compatible strings? > > > If so, what makes you think it? How does it differ from: > > > > compatible = "arm,cortex-a9-twd-timer"; > > compatible = "arm,rtc-pl031"; > > compatible = "stericsson,db8500-gpio", > > compatible = "stericsson,db8500-musb", > > compatible = "stericsson,db8500-dma40", > > compatible = "stericsson,db8500-prcmu"; > > compatible = "stericsson,db8500-prcmu-timer-4"; > > compatible = "stericsson,db8500-thermal"; > > compatible = "stericsson,db8500-prcmu-regulator"; > > It says u8500-pinctrl, not db8500-pinctrl. > > Could it be that you're not actually seeing your own typo? Yes, that's exactly what happened. I thought you were mentioning the way it was laid out. I'll fixup.
diff --git a/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt b/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt index 9a2f3f4..c3d8a89 100644 --- a/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt +++ b/Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt @@ -1,8 +1,8 @@ ST Ericsson Nomadik pinmux controller Required properties: -- compatible: "stericsson,nmk-pinctrl", "stericsson,nmk-pinctrl-db8540", - "stericsson,nmk-pinctrl-stn8815" +- compatible: "stericsson,db8500-pinctrl", "stericsson,db8540-pinctrl", + "stericsson,stn8815-pinctrl" - reg: Should contain the register physical address and length of the PRCMU. Please refer to pinctrl-bindings.txt in this directory for details of the @@ -68,7 +68,7 @@ Optional subnode-properties: Example board file extract: pinctrl@80157000 { - compatible = "stericsson,nmk-pinctrl"; + compatible = "stericsson,u8500-pinctrl"; reg = <0x80157000 0x2000>; pinctrl-names = "default";
Change compatible string to something more standard. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- Documentation/devicetree/bindings/pinctrl/ste,nomadik.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)