diff mbox

dts: am33xx: Correct properties on gpmc node

Message ID 1369729497-11897-1-git-send-email-larsi@wh2.tu-dresden.de (mailing list archive)
State New, archived
Headers show

Commit Message

larsi@wh2.tu-dresden.de May 28, 2013, 8:24 a.m. UTC 
From: Lars Poeschel <poeschel@lemonage.de>

The gpmc driver is actually looking for "gpmc,num-cs" and
"gpmc,num-waitpins" properties in DT. The binding doc also states
this.
Correct the properties in the dts to provide the right values for the
gpmc driver.

Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
---
 arch/arm/boot/dts/am33xx.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard May 28, 2013, 9:50 a.m. UTC | #1 
>>>>> "Lars" == Lars Poeschel <larsi@wh2.tu-dresden.de> writes:

 Lars> From: Lars Poeschel <poeschel@lemonage.de>
 Lars> The gpmc driver is actually looking for "gpmc,num-cs" and
 Lars> "gpmc,num-waitpins" properties in DT. The binding doc also states
 Lars> this.
 Lars> Correct the properties in the dts to provide the right values for the
 Lars> gpmc driver.

 Lars> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>

Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
pekon gupta May 30, 2013, 6:44 a.m. UTC | #2 
> >>>>> "Lars" == Lars Poeschel <larsi@wh2.tu-dresden.de> writes:
> 
>  Lars> From: Lars Poeschel <poeschel@lemonage.de>
>  Lars> The gpmc driver is actually looking for "gpmc,num-cs" and
>  Lars> "gpmc,num-waitpins" properties in DT. The binding doc also states
>  Lars> this.
>  Lars> Correct the properties in the dts to provide the right values for the
>  Lars> gpmc driver.
> 
>  Lars> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> 
> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
> 
Acked-by: Pekon Gupta <pekon@ti.com>

My another patch [V3, 2/3] on same can be dropped, in lieu of this one..
http://www.spinics.net/lists/linux-omap/msg91167.html


with regards, pekon
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 1460d9b..8e1248f 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -409,8 +409,8 @@ 
 			ti,hwmods = "gpmc";
 			reg = <0x50000000 0x2000>;
 			interrupts = <100>;
-			num-cs = <7>;
-			num-waitpins = <2>;
+			gpmc,num-cs = <7>;
+			gpmc,num-waitpins = <2>;
 			#address-cells = <2>;
 			#size-cells = <1>;
 			status = "disabled";