diff mbox

ARM: dts: Update vdd_arm regulator

Message ID 1370516572-313-1-git-send-email-tushar.behera@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Tushar Behera June 6, 2013, 11:02 a.m. UTC
Cpufreq driver for EXYNOS4210 is not a platform driver, hence it is not
possible to provide the regulator supply name through DT bindings.
Since the cpufreq driver requires the regulator to be named as
'vdd_arm', the related regulator name should be kept same.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/boot/dts/exynos4210-origen.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tomasz Figa June 8, 2013, 11:52 a.m. UTC | #1
Hi Tushar,

On Thursday 06 of June 2013 16:32:52 Tushar Behera wrote:
> Cpufreq driver for EXYNOS4210 is not a platform driver, hence it is not
> possible to provide the regulator supply name through DT bindings.
> Since the cpufreq driver requires the regulator to be named as
> 'vdd_arm', the related regulator name should be kept same.
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4210-origen.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts index bcf8079..bd5f589 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -192,7 +192,7 @@
>  				};
> 
>  				buck1_reg: BUCK1 {
> -					regulator-name = "VDD_ARM_1.2V";
> +					regulator-name = "vdd_arm";

Yes, this is the hack I mentioned in my review of
[PATCH 0/2] Clock update for EXYNOS4210-CPUFREQ driver

Best regards,
Tomasz

>  					regulator-min-microvolt = 
<950000>;
>  					regulator-max-microvolt	= 
<1350000>;
>  					regulator-always-on;
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tushar Behera June 10, 2013, 3:44 a.m. UTC | #2
On 06/08/2013 05:22 PM, Tomasz Figa wrote:
> Hi Tushar,
> 
> On Thursday 06 of June 2013 16:32:52 Tushar Behera wrote:
>> Cpufreq driver for EXYNOS4210 is not a platform driver, hence it is not
>> possible to provide the regulator supply name through DT bindings.
>> Since the cpufreq driver requires the regulator to be named as
>> 'vdd_arm', the related regulator name should be kept same.
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos4210-origen.dts |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
>> b/arch/arm/boot/dts/exynos4210-origen.dts index bcf8079..bd5f589 100644
>> --- a/arch/arm/boot/dts/exynos4210-origen.dts
>> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
>> @@ -192,7 +192,7 @@
>>  				};
>>
>>  				buck1_reg: BUCK1 {
>> -					regulator-name = "VDD_ARM_1.2V";
>> +					regulator-name = "vdd_arm";
> 
> Yes, this is the hack I mentioned in my review of
> [PATCH 0/2] Clock update for EXYNOS4210-CPUFREQ driver
> 

We can hold this patch till we get to a conclusion for the above
mentioned patch set.


> Best regards,
> Tomasz
> 
>>  					regulator-min-microvolt = 
> <950000>;
>>  					regulator-max-microvolt	= 
> <1350000>;
>>  					regulator-always-on;
Tushar Behera June 20, 2013, 11:10 a.m. UTC | #3
On 06/10/2013 09:14 AM, Tushar Behera wrote:
> On 06/08/2013 05:22 PM, Tomasz Figa wrote:
>> Hi Tushar,
>>
>> On Thursday 06 of June 2013 16:32:52 Tushar Behera wrote:
>>> Cpufreq driver for EXYNOS4210 is not a platform driver, hence it is not
>>> possible to provide the regulator supply name through DT bindings.
>>> Since the cpufreq driver requires the regulator to be named as
>>> 'vdd_arm', the related regulator name should be kept same.
>>>
>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>> ---
>>>  arch/arm/boot/dts/exynos4210-origen.dts |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
>>> b/arch/arm/boot/dts/exynos4210-origen.dts index bcf8079..bd5f589 100644
>>> --- a/arch/arm/boot/dts/exynos4210-origen.dts
>>> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
>>> @@ -192,7 +192,7 @@
>>>  				};
>>>
>>>  				buck1_reg: BUCK1 {
>>> -					regulator-name = "VDD_ARM_1.2V";
>>> +					regulator-name = "vdd_arm";
>>
>> Yes, this is the hack I mentioned in my review of
>> [PATCH 0/2] Clock update for EXYNOS4210-CPUFREQ driver
>>
> 
> We can hold this patch till we get to a conclusion for the above
> mentioned patch set.
> 
Kukjin,

We have agreed to go ahead with this approach till the cpufreq driver
has not been modified.

Can you please take this patch now?
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index bcf8079..bd5f589 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -192,7 +192,7 @@ 
 				};
 
 				buck1_reg: BUCK1 {
-					regulator-name = "VDD_ARM_1.2V";
+					regulator-name = "vdd_arm";
 					regulator-min-microvolt = <950000>;
 					regulator-max-microvolt	= <1350000>;
 					regulator-always-on;