| Message ID | 000201ce631f$d4ad0d50$7e0727f0$@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday 07 June 2013 10:39:20 Jingoo Han wrote: > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > build warning when CONFIG_PM_SLEEP is not selected. This is because > sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when > the CONFIG_PM_SLEEP is enabled. > > drivers/video/backlight/backlight.c:211:12: warning: 'backlight_suspend' defined but not used [-Wunused-function] > drivers/video/backlight/backlight.c:225:12: warning: 'backlight_resume' defined but not used [-Wunused-function] > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> I forgot: Acked-by: Arnd Bergmann <arnd@arndb.de> -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/07/2013 04:25 AM, Arnd Bergmann wrote: > On Friday 07 June 2013 10:39:20 Jingoo Han wrote: >> Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following >> build warning when CONFIG_PM_SLEEP is not selected. This is because >> sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when >> the CONFIG_PM_SLEEP is enabled. >> >> drivers/video/backlight/backlight.c:211:12: warning: 'backlight_suspend' defined but not used [-Wunused-function] >> drivers/video/backlight/backlight.c:225:12: warning: 'backlight_resume' defined but not used [-Wunused-function] >> >> Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > I forgot: > > Acked-by: Arnd Bergmann <arnd@arndb.de> > Jingoo Han, and Arnd, Sorry I was on vacation all of last week. Thanks for fixing the problem. My apologies for introducing the warnings. I had CONFIG_PM and CONFIG_PM_SLEEP both enabled and didn't see this warning. I will be careful with subsequent patches in this area. -- Shuah Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) shuah.kh@samsung.com | (970) 672-0658 -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index cedbcbe..750807c 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -208,6 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, static struct class *backlight_class; +#ifdef CONFIG_PM_SLEEP static int backlight_suspend(struct device *dev) { struct backlight_device *bd = to_backlight_device(dev); @@ -235,6 +236,7 @@ static int backlight_resume(struct device *dev) return 0; } +#endif static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, backlight_resume);
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. drivers/video/backlight/backlight.c:211:12: warning: 'backlight_suspend' defined but not used [-Wunused-function] drivers/video/backlight/backlight.c:225:12: warning: 'backlight_resume' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/video/backlight/backlight.c | 2 ++ 1 file changed, 2 insertions(+)