| Message ID | 951463.86902.qm@web110810.mail.gq1.yahoo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, May 19, 2009 at 7:58 AM, Uri Shkolnik <urishk@yahoo.com> wrote: > > # HG changeset patch > # User Uri Shkolnik <uris@siano-ms.com> > # Date 1242734522 -10800 > # Node ID c74502f4c8e97bd9cec9656793bbabc11fb72ab4 > # Parent  315bc4b65b4f527c4f9bc4fe3290e10f07975437 > [09051_40] Siano - kconfig update > > From: Uri Shkolnik <uris@siano-ms.com> > > This patches comes to solve the comments on Siano's patch > 0905_10. It updates the kconfig to support multi-modules build. > Note that the dependency on dvb_core is for the (sms)dvb module > alone, since the drivers set may work with another adapter. > > Priority: normal > > Signed-off-by: Uri Shkolnik <uris@siano-ms.com> > > diff -r 315bc4b65b4f -r c74502f4c8e9 linux/drivers/media/dvb/siano/Kconfig > --- a/linux/drivers/media/dvb/siano/Kconfig   Sun May 17 12:28:55 2009 +0000 > +++ b/linux/drivers/media/dvb/siano/Kconfig   Tue May 19 15:02:02 2009 +0300 > @@ -2,25 +2,40 @@ >  # Siano Mobile Silicon Digital TV device configuration >  # > > -config DVB_SIANO_SMS1XXX > -    tristate "Siano SMS1XXX USB dongle support" > -    depends on DVB_CORE && USB > +config SMS_SIANO_MDTV > +    tristate "Siano SMS1xxx based MDTV receiver" > +    default m >     ---help--- > -     Choose Y here if you have a USB dongle with a SMS1XXX chipset. > +    Choose Y or M here if you have MDTV receiver with a Siano chipset. > > -     To compile this driver as a module, choose M here: the > -     module will be called sms1xxx. > +    To compile this driver as a module, choose M here > +    (The modules will be called smsmdtv). > > -config DVB_SIANO_SMS1XXX_SMS_IDS > -    bool "Enable support for Siano Mobile Silicon default USB IDs" > -    depends on DVB_SIANO_SMS1XXX > -    default y > +    Note: All dependents, if selected, will be part of this module. > + > +    Further documentation on this driver can be found on the WWW > +    at http://www.siano-ms.com/ > + > +if SMS_SIANO_MDTV > +menu "Siano module components" > + > +# Kernel sub systems support > +config SMS_DVB3_SUBSYS > +    tristate "DVB v.3 Subsystem support" > +    depends on DVB_CORE > +    default m if DVB_CORE >     ---help--- > -     Choose Y here if you have a USB dongle with a SMS1XXX chipset > -     that uses Siano Mobile Silicon's default usb vid:pid. > +    Choose if you would like to have DVB v.3 kernel sub-system support. > > -     Choose N here if you would prefer to use Siano's external driver. > +# Hardware interfaces support > > -     Further documentation on this driver can be found on the WWW at > -     <http://www.siano-ms.com/>. > +config SMS_USB_DRV > +    tristate "USB interface support" > +    depends on USB > +    default m if USB > +    ---help--- > +    Choose if you would like to have Siano's support for USB interface > > + > +endmenu > +endif # SMS_SIANO_MDTV > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > I have two concerns with this patch... Issue #1, I dont see why it's important to rename the Kconfig symbol from DVB_SIANO_SMS1XXX to SMS_SIANO_MDTV -- This will just cause breakage of "make oldconfig" in the kernel with no real benefit. Issue #2, a much bigger issue..... This patch implies that the Siano driver can be built *with* DVB "v3" support, or without it. Why would a linux user ever want to built this driver without support for the DVB API ? (that's a loaded question) ... Does Siano intend to push their proprietary API into the kernel? -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -r 315bc4b65b4f -r c74502f4c8e9 linux/drivers/media/dvb/siano/Kconfig --- a/linux/drivers/media/dvb/siano/Kconfig Sun May 17 12:28:55 2009 +0000 +++ b/linux/drivers/media/dvb/siano/Kconfig Tue May 19 15:02:02 2009 +0300 @@ -2,25 +2,40 @@ # Siano Mobile Silicon Digital TV device configuration # -config DVB_SIANO_SMS1XXX - tristate "Siano SMS1XXX USB dongle support" - depends on DVB_CORE && USB +config SMS_SIANO_MDTV + tristate "Siano SMS1xxx based MDTV receiver" + default m ---help--- - Choose Y here if you have a USB dongle with a SMS1XXX chipset. + Choose Y or M here if you have MDTV receiver with a Siano chipset. - To compile this driver as a module, choose M here: the - module will be called sms1xxx. + To compile this driver as a module, choose M here + (The modules will be called smsmdtv). -config DVB_SIANO_SMS1XXX_SMS_IDS - bool "Enable support for Siano Mobile Silicon default USB IDs" - depends on DVB_SIANO_SMS1XXX - default y + Note: All dependents, if selected, will be part of this module. + + Further documentation on this driver can be found on the WWW + at http://www.siano-ms.com/ + +if SMS_SIANO_MDTV +menu "Siano module components" + +# Kernel sub systems support +config SMS_DVB3_SUBSYS + tristate "DVB v.3 Subsystem support" + depends on DVB_CORE + default m if DVB_CORE ---help--- - Choose Y here if you have a USB dongle with a SMS1XXX chipset - that uses Siano Mobile Silicon's default usb vid:pid. + Choose if you would like to have DVB v.3 kernel sub-system support. - Choose N here if you would prefer to use Siano's external driver. +# Hardware interfaces support - Further documentation on this driver can be found on the WWW at - <http://www.siano-ms.com/>. +config SMS_USB_DRV + tristate "USB interface support" + depends on USB + default m if USB + ---help--- + Choose if you would like to have Siano's support for USB interface + +endmenu +endif # SMS_SIANO_MDTV