| Message ID | 1371040448-28742-2-git-send-email-jonas.jensen@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, This looks pretty good. I have mostly a bunch of nits below. Please feel free to cc arm@kernel.org (which goes to us arm-soc maintainers) on future postings. On Wed, Jun 12, 2013 at 02:34:06PM +0200, Jonas Jensen wrote: > > Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com> You should provide a commit message, ideally with a short introduction of the platform. > --- > arch/arm/Kconfig | 2 + > arch/arm/Makefile | 1 + > arch/arm/configs/moxart_uc7112lx_defconfig | 112 ++++++++++++++++++++++++++++ > arch/arm/mach-moxart/Kconfig | 28 +++++++ > arch/arm/mach-moxart/Makefile | 10 +++ > arch/arm/mach-moxart/idle.c | 21 +++++ > arch/arm/mach-moxart/moxart.c | 23 ++++++ > 7 files changed, 197 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/configs/moxart_uc7112lx_defconfig > create mode 100644 arch/arm/mach-moxart/Kconfig > create mode 100644 arch/arm/mach-moxart/Makefile > create mode 100644 arch/arm/mach-moxart/idle.c > create mode 100644 arch/arm/mach-moxart/moxart.c > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 0435a6a..b004ae0 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -937,6 +937,8 @@ source "arch/arm/mach-footbridge/Kconfig" > > source "arch/arm/mach-gemini/Kconfig" > > +source "arch/arm/mach-moxart/Kconfig" > + > source "arch/arm/mach-highbank/Kconfig" > > source "arch/arm/mach-integrator/Kconfig" > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 3380c4f..eb8f48e 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -148,6 +148,7 @@ machine-$(CONFIG_ARCH_DOVE) += dove > machine-$(CONFIG_ARCH_EBSA110) += ebsa110 > machine-$(CONFIG_ARCH_EP93XX) += ep93xx > machine-$(CONFIG_ARCH_GEMINI) += gemini > +machine-$(CONFIG_ARCH_MOXART) += moxart > machine-$(CONFIG_ARCH_HIGHBANK) += highbank > machine-$(CONFIG_ARCH_INTEGRATOR) += integrator > machine-$(CONFIG_ARCH_IOP13XX) += iop13xx > diff --git a/arch/arm/configs/moxart_uc7112lx_defconfig b/arch/arm/configs/moxart_uc7112lx_defconfig > new file mode 100644 > index 0000000..8d8f3a4 > --- /dev/null > +++ b/arch/arm/configs/moxart_uc7112lx_defconfig It'd be nice to keep the defconfig generic, and make sure to enable all boards in it -- we're generally OK with adding one defconfig per platform upstream but not more. > diff --git a/arch/arm/mach-moxart/Kconfig b/arch/arm/mach-moxart/Kconfig > new file mode 100644 > index 0000000..633ce74 > --- /dev/null > +++ b/arch/arm/mach-moxart/Kconfig > @@ -0,0 +1,28 @@ > +config ARCH_MOXART > + bool "MOXA ART SoC" if (ARCH_MULTI_V4) No parens needed > + select CPU_FA526 > + select ARM_DMA_MEM_BUFFERABLE > + select USE_OF > + select CLKSRC_OF > + select HAVE_CLK > + select COMMON_CLK > + select GENERIC_IRQ_CHIP > + select ARCH_REQUIRE_GPIOLIB > + help > + Say Y here if you want to run your kernel on hardware with a MOXA ART SoC. > + This is a Faraday FA526 ARMv4 32-bit 192 MHz processor with MMU and 16KB/8KB D/I-cache (UC-7112-LX) > + This perticular SoC is used on models UC-7101, UC-7112/UC-7110, IA240/IA241, IA3341. This should probably be line-wrapped so it doesn't get too wide when looking at the help text. > + > +if ARCH_MOXART > + > +menu "MOXA ART SoC Implementation" > + > +config MACH_UC7112LX > + bool "MOXA UC-7112-LX" > + depends on ARCH_MOXART Since the menu is already wrapped with if ARCH_MOXART, you don't need it here. > + help > + Say Y here if you intend to run this kernel on a MOXA UC-7112-LX embedded computer. Same here w.r.t wrapping > + > +endmenu > + > +endif > diff --git a/arch/arm/mach-moxart/Makefile b/arch/arm/mach-moxart/Makefile > new file mode 100644 > index 0000000..56d8984 > --- /dev/null > +++ b/arch/arm/mach-moxart/Makefile > @@ -0,0 +1,10 @@ > +# > +# Makefile for the linux kernel. > +# Stale comment, can just remove it. > + > +# Object file lists. > + > +obj-y := idle.o > + > +obj-$(CONFIG_MACH_UC7112LX) += moxart.o > + > diff --git a/arch/arm/mach-moxart/idle.c b/arch/arm/mach-moxart/idle.c > new file mode 100644 > index 0000000..73ed844 > --- /dev/null > +++ b/arch/arm/mach-moxart/idle.c > @@ -0,0 +1,21 @@ > +/* Copyright (C) 2013 Jonas Jensen <jonas.jensen@gmail.com> > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, > + * or (at your option) any later version. */ These are sort of non-standard format. While I can't tell you what copyright text to use (within reason), please format it similarly to how others do, please. > +#include <linux/init.h> > +#include <asm/system.h> > +#include <asm/proc-fns.h> arm_pm_idle is defined in <asm/system_misc.h>, so it's a good idea to include that directly. > + > +static void moxart_idle(void) > +{ > +} > + > +static int __init moxart_idle_init(void) > +{ > + arm_pm_idle = moxart_idle; > + return 0; > +} > + > +arch_initcall(moxart_idle_init); If you multiplatform enable this, then you need to have a check in moxart_idle_init() to make sure you're running on a moxart soc. Otherwise this will still be called and override the arm_pm_idle setting on other platforms as well. > diff --git a/arch/arm/mach-moxart/moxart.c b/arch/arm/mach-moxart/moxart.c > new file mode 100644 > index 0000000..ab70386 > --- /dev/null > +++ b/arch/arm/mach-moxart/moxart.c > @@ -0,0 +1,23 @@ > +/* Copyright (C) 2013 Jonas Jensen <jonas.jensen@gmail.com> > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, > + * or (at your option) any later version. */ Same here w.r.t. copyright formatting. > + > +#include <linux/kernel.h> > +#include <linux/init.h> > +#include <linux/io.h> > +#include <linux/of_platform.h> > +#include <linux/clk-provider.h> I'm guessing some of these will be needed later when you add more code, so it might not make sense to remove them just for that, but they sure aren't all needed now. :) > + > +#include <asm/mach/arch.h> > + > +static const char * const moxart_dt_compat[] = { > + "moxa,moxart-uc-7112-lx", > + NULL, > +}; > + > +DT_MACHINE_START(MOXART, "MOXA UC-7112-LX") > + .dt_compat = moxart_dt_compat, > +MACHINE_END > + > -- > 1.7.2.5 >
Hi, Thanks for the replies. What isn't commented below should already be fixed. I'll resubmit the entire set when it looks like there's nothing left to amend. On 13 June 2013 00:42, Olof Johansson <olof@lixom.net> wrote: > You should provide a commit message, ideally with a short introduction of the > platform. Will do. I was thinking I should do that, this is the first time I used git format-patch / git send-email. >> +++ b/arch/arm/configs/moxart_uc7112lx_defconfig > > It'd be nice to keep the defconfig generic, and make sure to enable all boards > in it -- we're generally OK with adding one defconfig per platform upstream but > not more. Since MACH_UC7112LX is the only board right now, how can it "enable all boards"? One way I can think of is to remove CONFIG_MACH_UC7112LX=y from defconfig and have it (and all future boards) "default y" in arch/arm/mach-moxart/Kconfig. I focus on a single hardware, UC-7112-LX. There's at least one more board with only minor differences (RAM / flash size). But for now, MACH_UC7112LX is the one I have access to and can test. I think UC-7110 is already supported, that it would boot, just copy arch/arm/boot/dts/moxart-uc7112lx.dts and modify ranges for RAM and MTD. I want to leave this in a state where remaining hardware can easily be added, albeit by someone that isn't me :) > If you multiplatform enable this, then you need to have a check in > moxart_idle_init() to make sure you're running on a moxart soc. Otherwise this > will still be called and override the arm_pm_idle setting on other platforms as > well. I can't find a good example of how other platforms do this, is a DT lookup an accepted solution? : static const struct of_device_id moxart_match[] = { { .compatible = "moxa,moxart" }, { } }; static int __init moxart_idle_init(void) { struct device_node *node; node = of_find_matching_node(NULL, moxart_match); if (!node) return -ENODEV; arm_pm_idle = moxart_idle; return 0; } arch_initcall(moxart_idle_init); Best regards, Jonas
On Wednesday 12 June 2013 14:34:06 Jonas Jensen wrote: > diff --git a/arch/arm/mach-moxart/idle.c b/arch/arm/mach-moxart/idle.c > new file mode 100644 > index 0000000..73ed844 > --- /dev/null > +++ b/arch/arm/mach-moxart/idle.c > @@ -0,0 +1,21 @@ > +/* Copyright (C) 2013 Jonas Jensen <jonas.jensen@gmail.com> > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, > + * or (at your option) any later version. */ > + > +#include <linux/init.h> > +#include <asm/system.h> > +#include <asm/proc-fns.h> > + > +static void moxart_idle(void) > +{ > +} > + > +static int __init moxart_idle_init(void) > +{ > + arm_pm_idle = moxart_idle; > + return 0; > +} > + > +arch_initcall(moxart_idle_init); IIRC Russell suggested changing cpu_fa526_do_idle() to not call WFI instead, since the only other platform with fa526 has the same problem. Your change above is actually wrong and breaks non-fa526 platforms in a multiplatform kernel because it overrides arm_pm_idle without checking what machine it currently runs on. > diff --git a/arch/arm/mach-moxart/moxart.c b/arch/arm/mach-moxart/moxart.c > new file mode 100644 > index 0000000..ab70386 > --- /dev/null > +++ b/arch/arm/mach-moxart/moxart.c > @@ -0,0 +1,23 @@ > +/* Copyright (C) 2013 Jonas Jensen <jonas.jensen@gmail.com> > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, > + * or (at your option) any later version. */ > + > +#include <linux/kernel.h> > +#include <linux/init.h> > +#include <linux/io.h> > +#include <linux/of_platform.h> > +#include <linux/clk-provider.h> Most of these are probably unneeded now. > +#include <asm/mach/arch.h> > + > +static const char * const moxart_dt_compat[] = { > + "moxa,moxart-uc-7112-lx", > + NULL, > +}; > + > +DT_MACHINE_START(MOXART, "MOXA UC-7112-LX") > + .dt_compat = moxart_dt_compat, > +MACHINE_END If the .dt_compat fields is the only field in the machine descriptor, you can leave out the entire descriptor! Olof, do you have a preference to how we want to handle this? The only advantage of having this file at all is to have the "MOXA UC-7112-LX" string in /proc/cpuinfo. Should we just remove the entire directory or leave it as the trivial file above? Arnd
On Fri, Jun 14, 2013 at 7:47 AM, Arnd Bergmann <arnd@arndb.de> wrote: arch.h> >> + >> +static const char * const moxart_dt_compat[] = { >> + "moxa,moxart-uc-7112-lx", >> + NULL, >> +}; >> + >> +DT_MACHINE_START(MOXART, "MOXA UC-7112-LX") >> + .dt_compat = moxart_dt_compat, >> +MACHINE_END > > If the .dt_compat fields is the only field in the machine descriptor, > you can leave out the entire descriptor! > > Olof, do you have a preference to how we want to handle this? The > only advantage of having this file at all is to have the > "MOXA UC-7112-LX" string in /proc/cpuinfo. > Should we just remove the entire directory or leave it as the trivial > file above? I sort of presumed that there might be need for _some_ platform code later on, just not quite yet, so I didn't want to be quite that drastic. I suppose leaving it with the trivial file for now is OK, and we can make a sweeping change down the road in case we want to clean up and consolidate all the trivial platforms. -Olof
On Friday 14 June 2013 09:41:36 Olof Johansson wrote: > I sort of presumed that there might be need for _some_ platform code > later on, just not quite yet, so I didn't want to be quite that > drastic. I suppose leaving it with the trivial file for now is OK, and > we can make a sweeping change down the road in case we want to clean > up and consolidate all the trivial platforms. Yes, good idea. Arnd
Hi, On Fri, Jun 14, 2013 at 04:33:29PM +0200, Jonas Jensen wrote: > Hi, > > Thanks for the replies. > > What isn't commented below should already be fixed. I'll resubmit the > entire set when it looks like there's nothing left to amend. > > On 13 June 2013 00:42, Olof Johansson <olof@lixom.net> wrote: > > You should provide a commit message, ideally with a short introduction of the > > platform. > > Will do. I was thinking I should do that, this is the first time I > used git format-patch / git send-email. > > >> +++ b/arch/arm/configs/moxart_uc7112lx_defconfig > > > > It'd be nice to keep the defconfig generic, and make sure to enable all boards > > in it -- we're generally OK with adding one defconfig per platform upstream but > > not more. > > Since MACH_UC7112LX is the only board right now, how can it "enable all boards"? Yeah, that was more with respect to future use of the defconfig. So keeping it generic in name for now (moxart_defconfig) is really all I am asking for. > One way I can think of is to remove CONFIG_MACH_UC7112LX=y from > defconfig and have it (and all future boards) "default y" in > arch/arm/mach-moxart/Kconfig. Enabling it in the defconfig is just fine, no need to change anything there at this time. > I focus on a single hardware, UC-7112-LX. There's at least one more > board with only minor differences (RAM / flash size). But for now, > MACH_UC7112LX is the one I have access to and can test. I think > UC-7110 is already supported, that it would boot, just copy > arch/arm/boot/dts/moxart-uc7112lx.dts and modify ranges for RAM and > MTD. I want to leave this in a state where remaining hardware can > easily be added, albeit by someone that isn't me :) Sure, that's a fair stance. > > If you multiplatform enable this, then you need to have a check in > > moxart_idle_init() to make sure you're running on a moxart soc. Otherwise this > > will still be called and override the arm_pm_idle setting on other platforms as > > well. > > I can't find a good example of how other platforms do this, is a DT > lookup an accepted solution? : > > static const struct of_device_id moxart_match[] = { > { .compatible = "moxa,moxart" }, > { } > }; > > static int __init moxart_idle_init(void) > { > struct device_node *node; > > node = of_find_matching_node(NULL, moxart_match); > if (!node) > return -ENODEV; > > arm_pm_idle = moxart_idle; > return 0; > } > > arch_initcall(moxart_idle_init); Easiest of all is if you have a "moxa,moxart" compatible field as the most-specific one for your machine, then you can just do: ... { if (!of_machine_is_compatible("moxa,moxart")) return -ENODEV; arm_pm_idle = moxart_idle; return 0; } -Olof
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 0435a6a..b004ae0 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -937,6 +937,8 @@ source "arch/arm/mach-footbridge/Kconfig" source "arch/arm/mach-gemini/Kconfig" +source "arch/arm/mach-moxart/Kconfig" + source "arch/arm/mach-highbank/Kconfig" source "arch/arm/mach-integrator/Kconfig" diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 3380c4f..eb8f48e 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -148,6 +148,7 @@ machine-$(CONFIG_ARCH_DOVE) += dove machine-$(CONFIG_ARCH_EBSA110) += ebsa110 machine-$(CONFIG_ARCH_EP93XX) += ep93xx machine-$(CONFIG_ARCH_GEMINI) += gemini +machine-$(CONFIG_ARCH_MOXART) += moxart machine-$(CONFIG_ARCH_HIGHBANK) += highbank machine-$(CONFIG_ARCH_INTEGRATOR) += integrator machine-$(CONFIG_ARCH_IOP13XX) += iop13xx diff --git a/arch/arm/configs/moxart_uc7112lx_defconfig b/arch/arm/configs/moxart_uc7112lx_defconfig new file mode 100644 index 0000000..8d8f3a4 --- /dev/null +++ b/arch/arm/configs/moxart_uc7112lx_defconfig @@ -0,0 +1,112 @@ +# CONFIG_LOCALVERSION_AUTO is not set +# CONFIG_SWAP is not set +CONFIG_SYSVIPC=y +CONFIG_IKCONFIG=y +CONFIG_IKCONFIG_PROC=y +CONFIG_SYSCTL_SYSCALL=y +# CONFIG_ELF_CORE is not set +# CONFIG_BASE_FULL is not set +# CONFIG_SIGNALFD is not set +# CONFIG_TIMERFD is not set +# CONFIG_EVENTFD is not set +# CONFIG_AIO is not set +CONFIG_EMBEDDED=y +# CONFIG_VM_EVENT_COUNTERS is not set +# CONFIG_SLUB_DEBUG is not set +# CONFIG_COMPAT_BRK is not set +# CONFIG_LBDAF is not set +# CONFIG_BLK_DEV_BSG is not set +# CONFIG_IOSCHED_DEADLINE is not set +CONFIG_ARCH_MULTI_V4=y +# CONFIG_ARCH_MULTI_V7 is not set +CONFIG_ARCH_MOXART=y +CONFIG_MACH_UC7112LX=y +CONFIG_PREEMPT=y +CONFIG_AEABI=y +# CONFIG_OABI_COMPAT is not set +# CONFIG_ATAGS is not set +CONFIG_ARM_APPENDED_DTB=y +CONFIG_NET=y +CONFIG_UNIX=y +CONFIG_INET=y +# CONFIG_INET_XFRM_MODE_TRANSPORT is not set +# CONFIG_INET_XFRM_MODE_TUNNEL is not set +# CONFIG_INET_XFRM_MODE_BEET is not set +# CONFIG_INET_LRO is not set +# CONFIG_INET_DIAG is not set +# CONFIG_IPV6 is not set +# CONFIG_WIRELESS is not set +CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" +CONFIG_DEVTMPFS=y +CONFIG_DEVTMPFS_MOUNT=y +# CONFIG_PREVENT_FIRMWARE_BUILD is not set +# CONFIG_FW_LOADER is not set +CONFIG_MTD=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_CFI=y +CONFIG_MTD_CFI_ADV_OPTIONS=y +CONFIG_MTD_CFI_GEOMETRY=y +CONFIG_MTD_CFI_INTELEXT=y +CONFIG_MTD_COMPLEX_MAPPINGS=y +CONFIG_MTD_PHYSMAP=y +CONFIG_MTD_PHYSMAP_OF=y +CONFIG_PROC_DEVICETREE=y +CONFIG_NETDEVICES=y +# CONFIG_NET_CADENCE is not set +# CONFIG_NET_VENDOR_BROADCOM is not set +# CONFIG_NET_VENDOR_CIRRUS is not set +# CONFIG_NET_VENDOR_FARADAY is not set +# CONFIG_NET_VENDOR_INTEL is not set +# CONFIG_NET_VENDOR_MARVELL is not set +# CONFIG_NET_VENDOR_MICREL is not set +# CONFIG_NET_VENDOR_NATSEMI is not set +# CONFIG_NET_VENDOR_SEEQ is not set +# CONFIG_NET_VENDOR_SMSC is not set +# CONFIG_NET_VENDOR_STMICRO is not set +# CONFIG_NET_VENDOR_WIZNET is not set +CONFIG_ARM_MOXART_ETHER=y +# CONFIG_WLAN is not set +# CONFIG_INPUT is not set +# CONFIG_SERIO is not set +# CONFIG_VT is not set +# CONFIG_LEGACY_PTYS is not set +CONFIG_MOXA_SMARTIO=y +# CONFIG_DEVKMEM is not set +CONFIG_SERIAL_8250=y +CONFIG_SERIAL_8250_CONSOLE=y +CONFIG_SERIAL_8250_NR_UARTS=1 +CONFIG_SERIAL_8250_RUNTIME_UARTS=1 +CONFIG_SERIAL_8250_EXTENDED=y +CONFIG_SERIAL_8250_SHARE_IRQ=y +CONFIG_SERIAL_OF_PLATFORM=y +# CONFIG_HW_RANDOM is not set +CONFIG_GPIO_MOXART=y +# CONFIG_HWMON is not set +CONFIG_WATCHDOG=y +CONFIG_MOXART_WDT=y +# CONFIG_USB_SUPPORT is not set +CONFIG_MMC=y +CONFIG_MMC_SDHCI_MOXART=y +CONFIG_RTC_CLASS=y +CONFIG_RTC_DRV_MOXART=y +CONFIG_DMADEVICES=y +CONFIG_MOXART_DMA=y +# CONFIG_IOMMU_SUPPORT is not set +CONFIG_EXT3_FS=y +CONFIG_TMPFS=y +CONFIG_JFFS2_FS=y +CONFIG_PRINTK_TIME=y +# CONFIG_ENABLE_WARN_DEPRECATED is not set +# CONFIG_ENABLE_MUST_CHECK is not set +CONFIG_MAGIC_SYSRQ=y +CONFIG_DEBUG_SHIRQ=y +CONFIG_DETECT_HUNG_TASK=y +# CONFIG_SCHED_DEBUG is not set +# CONFIG_DEBUG_PREEMPT is not set +CONFIG_PROVE_LOCKING=y +CONFIG_DEBUG_INFO=y +CONFIG_DEBUG_MEMORY_INIT=y +# CONFIG_FTRACE is not set +CONFIG_DEBUG_LL=y +CONFIG_EARLY_PRINTK=y +CONFIG_KEYS=y diff --git a/arch/arm/mach-moxart/Kconfig b/arch/arm/mach-moxart/Kconfig new file mode 100644 index 0000000..633ce74 --- /dev/null +++ b/arch/arm/mach-moxart/Kconfig @@ -0,0 +1,28 @@ +config ARCH_MOXART + bool "MOXA ART SoC" if (ARCH_MULTI_V4) + select CPU_FA526 + select ARM_DMA_MEM_BUFFERABLE + select USE_OF + select CLKSRC_OF + select HAVE_CLK + select COMMON_CLK + select GENERIC_IRQ_CHIP + select ARCH_REQUIRE_GPIOLIB + help + Say Y here if you want to run your kernel on hardware with a MOXA ART SoC. + This is a Faraday FA526 ARMv4 32-bit 192 MHz processor with MMU and 16KB/8KB D/I-cache (UC-7112-LX) + This perticular SoC is used on models UC-7101, UC-7112/UC-7110, IA240/IA241, IA3341. + +if ARCH_MOXART + +menu "MOXA ART SoC Implementation" + +config MACH_UC7112LX + bool "MOXA UC-7112-LX" + depends on ARCH_MOXART + help + Say Y here if you intend to run this kernel on a MOXA UC-7112-LX embedded computer. + +endmenu + +endif diff --git a/arch/arm/mach-moxart/Makefile b/arch/arm/mach-moxart/Makefile new file mode 100644 index 0000000..56d8984 --- /dev/null +++ b/arch/arm/mach-moxart/Makefile @@ -0,0 +1,10 @@ +# +# Makefile for the linux kernel. +# + +# Object file lists. + +obj-y := idle.o + +obj-$(CONFIG_MACH_UC7112LX) += moxart.o + diff --git a/arch/arm/mach-moxart/idle.c b/arch/arm/mach-moxart/idle.c new file mode 100644 index 0000000..73ed844 --- /dev/null +++ b/arch/arm/mach-moxart/idle.c @@ -0,0 +1,21 @@ +/* Copyright (C) 2013 Jonas Jensen <jonas.jensen@gmail.com> + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, + * or (at your option) any later version. */ + +#include <linux/init.h> +#include <asm/system.h> +#include <asm/proc-fns.h> + +static void moxart_idle(void) +{ +} + +static int __init moxart_idle_init(void) +{ + arm_pm_idle = moxart_idle; + return 0; +} + +arch_initcall(moxart_idle_init); diff --git a/arch/arm/mach-moxart/moxart.c b/arch/arm/mach-moxart/moxart.c new file mode 100644 index 0000000..ab70386 --- /dev/null +++ b/arch/arm/mach-moxart/moxart.c @@ -0,0 +1,23 @@ +/* Copyright (C) 2013 Jonas Jensen <jonas.jensen@gmail.com> + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, + * or (at your option) any later version. */ + +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/io.h> +#include <linux/of_platform.h> +#include <linux/clk-provider.h> + +#include <asm/mach/arch.h> + +static const char * const moxart_dt_compat[] = { + "moxa,moxart-uc-7112-lx", + NULL, +}; + +DT_MACHINE_START(MOXART, "MOXA UC-7112-LX") + .dt_compat = moxart_dt_compat, +MACHINE_END +
Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com> --- arch/arm/Kconfig | 2 + arch/arm/Makefile | 1 + arch/arm/configs/moxart_uc7112lx_defconfig | 112 ++++++++++++++++++++++++++++ arch/arm/mach-moxart/Kconfig | 28 +++++++ arch/arm/mach-moxart/Makefile | 10 +++ arch/arm/mach-moxart/idle.c | 21 +++++ arch/arm/mach-moxart/moxart.c | 23 ++++++ 7 files changed, 197 insertions(+), 0 deletions(-) create mode 100644 arch/arm/configs/moxart_uc7112lx_defconfig create mode 100644 arch/arm/mach-moxart/Kconfig create mode 100644 arch/arm/mach-moxart/Makefile create mode 100644 arch/arm/mach-moxart/idle.c create mode 100644 arch/arm/mach-moxart/moxart.c