| Message ID | 1370795767-9769-6-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Maxime, El 09/06/13 13:36, Maxime Ripard escribió: > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 75 ++++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts Please add this on the sunxi target in arch/arm/boot/dts/Makefile so it gets built on make dtbs. (snip) > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&led_pins_olinuxino>; > + > + power { > + gpios = <&pio 4 3 0>; > + default-state = "on"; > + }; Also, as discussed on IRC, I think it would be wise to change the name on the LED node. The schematics have a 'power' led already that is hard-wired to 3.3v, and this led node that you are declaring is referred as 'led1' there. I suppose 'green' would be a suitable name to keep consistency with other sunxi boards (namely cubieboard). Other than that, my OLinuXino worked just fine after applying this patchset, so Tested-by: Emilio López <emilio@elopez.com.ar> Thanks! Emilio
Hi Emilio, On Fri, Jun 14, 2013 at 03:09:49PM -0300, Emilio López wrote: > Hi Maxime, > > El 09/06/13 13:36, Maxime Ripard escribió: > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > --- > > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 75 ++++++++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts > > Please add this on the sunxi target in arch/arm/boot/dts/Makefile so it > gets built on make dtbs. > > (snip) > > > + leds { > > + compatible = "gpio-leds"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&led_pins_olinuxino>; > > + > > + power { > > + gpios = <&pio 4 3 0>; > > + default-state = "on"; > > + }; > > Also, as discussed on IRC, I think it would be wise to change the name > on the LED node. The schematics have a 'power' led already that is > hard-wired to 3.3v, and this led node that you are declaring is referred > as 'led1' there. I suppose 'green' would be a suitable name to keep > consistency with other sunxi boards (namely cubieboard). > > Other than that, my OLinuXino worked just fine after applying this > patchset, so > > Tested-by: Emilio López <emilio@elopez.com.ar> Thanks for your comments and the test. I'll send a v2. Maxime
diff --git a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts new file mode 100644 index 0000000..73ad65e --- /dev/null +++ b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts @@ -0,0 +1,75 @@ +/* + * Copyright 2013 Maxime Ripard + * + * Maxime Ripard <maxime.ripard@free-electrons.com> + * + * The code contained herein is licensed under the GNU General Public + * License. You may obtain a copy of the GNU General Public License + * Version 2 or later at the following locations: + * + * http://www.opensource.org/licenses/gpl-license.html + * http://www.gnu.org/copyleft/gpl.html + */ + +/dts-v1/; +/include/ "sun5i-a10s.dtsi" + +/ { + model = "Olimex A10s-Olinuxino Micro"; + compatible = "olimex,a10s-olinuxino-micro", "allwinner,sun5i-a10s"; + + soc@01c20000 { + emac: ethernet@01c0b000 { + pinctrl-names = "default"; + pinctrl-0 = <&emac_pins_a>; + phy = <&phy1>; + status = "okay"; + }; + + mdio@01c0b080 { + status = "okay"; + + phy1: ethernet-phy@1 { + reg = <1>; + }; + }; + + pinctrl@01c20800 { + led_pins_olinuxino: led_pins@0 { + allwinner,pins = "PE3"; + allwinner,function = "gpio_out"; + allwinner,drive = <1>; + allwinner,pull = <0>; + }; + }; + + uart0: serial@01c28000 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pins_a>; + status = "okay"; + }; + + uart2: serial@01c28800 { + pinctrl-names = "default"; + pinctrl-0 = <&uart2_pins_a>; + status = "okay"; + }; + + uart3: serial@01c28c00 { + pinctrl-names = "default"; + pinctrl-0 = <&uart3_pins_a>; + status = "okay"; + }; + }; + + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&led_pins_olinuxino>; + + power { + gpios = <&pio 4 3 0>; + default-state = "on"; + }; + }; +};
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 75 ++++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts