diff mbox

ARM: OMAP3EVM: Marking omap3_evm_display_init() with CONFIG_BROKEN

Message ID 1371120838-29599-1-git-send-email-lokeshvutla@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lokesh Vutla June 13, 2013, 10:53 a.m. UTC
On 37xx EVM non-dt boot fails with current mainline,
because of broken GPIO numbering in the board file
that uses hardcoded GPIOs.

So marking omap3_evm_display_init() with CONFIG_BROKEN
for now as suggested by Tony as per the below link:
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg90399.html

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/mach-omap2/board-omap3evm.c |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Paul Walmsley June 14, 2013, 2:38 a.m. UTC | #1
On Thu, 13 Jun 2013, Lokesh Vutla wrote:

> On 37xx EVM non-dt boot fails with current mainline,
> because of broken GPIO numbering in the board file
> that uses hardcoded GPIOs.
> 
> So marking omap3_evm_display_init() with CONFIG_BROKEN
> for now as suggested by Tony as per the below link:
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg90399.html
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> ---

Tested-by: Paul Walmsley <paul@pwsan.com>

- Paul
Tony Lindgren June 18, 2013, 10:11 a.m. UTC | #2
* Paul Walmsley <paul@pwsan.com> [130613 19:44]:
> On Thu, 13 Jun 2013, Lokesh Vutla wrote:
> 
> > On 37xx EVM non-dt boot fails with current mainline,
> > because of broken GPIO numbering in the board file
> > that uses hardcoded GPIOs.
> > 
> > So marking omap3_evm_display_init() with CONFIG_BROKEN
> > for now as suggested by Tony as per the below link:
> > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg90399.html
> > 
> > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> ---
> 
> Tested-by: Paul Walmsley <paul@pwsan.com>

Thanks applying into omap-for-v3.11/board.

Regards,

Tony
Paul Walmsley June 18, 2013, 11:23 a.m. UTC | #3
On Tue, 18 Jun 2013, Tony Lindgren wrote:

> * Paul Walmsley <paul@pwsan.com> [130613 19:44]:
> > On Thu, 13 Jun 2013, Lokesh Vutla wrote:
> > 
> > > On 37xx EVM non-dt boot fails with current mainline,
> > > because of broken GPIO numbering in the board file
> > > that uses hardcoded GPIOs.
> > > 
> > > So marking omap3_evm_display_init() with CONFIG_BROKEN
> > > for now as suggested by Tony as per the below link:
> > > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg90399.html
> > > 
> > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> ---
> > 
> > Tested-by: Paul Walmsley <paul@pwsan.com>
> 
> Thanks applying into omap-for-v3.11/board.

This one is probably a candidate for v3.10-rc...  Otherwise 37xx EVM won't 
boot on v3.10.


- Paul
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index f76d0de..278bf25 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -174,6 +174,7 @@  static struct panel_sharp_ls037v7dw01_data omap3_evm_lcd_data = {
 	.ud_gpio = OMAP3EVM_LCD_PANEL_UD,
 };
 
+#ifdef CONFIG_BROKEN
 static void __init omap3_evm_display_init(void)
 {
 	int r;
@@ -193,6 +194,7 @@  static void __init omap3_evm_display_init(void)
 	else
 		gpio_set_value_cansleep(OMAP3EVM_LCD_PANEL_BKLIGHT_GPIO, 1);
 }
+#endif
 
 static struct omap_dss_device omap3_evm_lcd_device = {
 	.name			= "lcd",
@@ -715,7 +717,9 @@  static void __init omap3_evm_init(void)
 
 	omap_ads7846_init(1, OMAP3_EVM_TS_GPIO, 310, NULL);
 	omap3evm_init_smsc911x();
+#ifdef CONFIG_BROKEN
 	omap3_evm_display_init();
+#endif
 	omap3_evm_wl12xx_init();
 	omap_twl4030_audio_init("omap3evm", NULL);
 }