diff mbox

gpio: rcar: fix gpio_rcar_of_table

Message ID 201306191750.43755.arnd@arndb.de (mailing list archive)
State Accepted
Headers show

Commit Message

Arnd Bergmann June 19, 2013, 3:50 p.m. UTC
The device table needs to be terminated with an empty element.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
---
I've just added this patch on top of the arm-soc next/drivers branch
that introduced the build warning.

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Simon Horman June 20, 2013, 12:50 a.m. UTC | #1
On Wed, Jun 19, 2013 at 05:50:43PM +0200, Arnd Bergmann wrote:
> The device table needs to be terminated with an empty element.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> ---
> I've just added this patch on top of the arm-soc next/drivers branch
> that introduced the build warning.

Thanks, have you pushed it there or do I need to add it and
send a pull-request?

> 
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 5a693dd..f332753 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -437,6 +437,7 @@ static const struct of_device_id gpio_rcar_of_table[] = {
>  	{
>  		.compatible = "renesas,gpio-rcar",
>  	},
> +	{ },
>  };
>  
>  MODULE_DEVICE_TABLE(of, gpio_rcar_of_table);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart June 20, 2013, 8:05 a.m. UTC | #2
Hi Arnd,

On Wednesday 19 June 2013 17:50:43 Arnd Bergmann wrote:
> The device table needs to be terminated with an empty element.

Oops, thanks for the patch.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> I've just added this patch on top of the arm-soc next/drivers branch
> that introduced the build warning.
> 
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 5a693dd..f332753 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -437,6 +437,7 @@ static const struct of_device_id gpio_rcar_of_table[] =
> { {
>  		.compatible = "renesas,gpio-rcar",
>  	},
> +	{ },
>  };
> 
>  MODULE_DEVICE_TABLE(of, gpio_rcar_of_table);
Arnd Bergmann June 20, 2013, 10:19 a.m. UTC | #3
On Thursday 20 June 2013, Simon Horman wrote:
> 
> On Wed, Jun 19, 2013 at 05:50:43PM +0200, Arnd Bergmann wrote:
> > The device table needs to be terminated with an empty element.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Cc: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > I've just added this patch on top of the arm-soc next/drivers branch
> > that introduced the build warning.
> 
> Thanks, have you pushed it there or do I need to add it and
> send a pull-request?

I've applied this directly.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman June 20, 2013, noon UTC | #4
On Thu, Jun 20, 2013 at 12:19:25PM +0200, Arnd Bergmann wrote:
> On Thursday 20 June 2013, Simon Horman wrote:
> > 
> > On Wed, Jun 19, 2013 at 05:50:43PM +0200, Arnd Bergmann wrote:
> > > The device table needs to be terminated with an empty element.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > Cc: Simon Horman <horms+renesas@verge.net.au>
> > > ---
> > > I've just added this patch on top of the arm-soc next/drivers branch
> > > that introduced the build warning.
> > 
> > Thanks, have you pushed it there or do I need to add it and
> > send a pull-request?
> 
> I've applied this directly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 5a693dd..f332753 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -437,6 +437,7 @@  static const struct of_device_id gpio_rcar_of_table[] = {
 	{
 		.compatible = "renesas,gpio-rcar",
 	},
+	{ },
 };
 
 MODULE_DEVICE_TABLE(of, gpio_rcar_of_table);