diff mbox

[4/6] ARM: dts: imx27: Add 1-wire

Message ID 1371739815-6666-5-git-send-email-mpa@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Markus Pargmann June 20, 2013, 2:50 p.m. UTC 
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Alexander Shiyan June 20, 2013, 3:17 p.m. UTC | #1 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx27.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 044004a..e883e77 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -110,6 +110,14 @@
>  				clock-names = "ipg", "per";
>  			};
>  
> +			owire: owire@10009000 {
> +				compatible = "fsl,imx21-owire";

I think you should use "fsl,imx27-owire", "fsl,imx21-owire" here.

> +				reg = <0x10009000 0x1000>;
> +				clocks = <&clks 35>;
> +				clock-names = "ipg";
> +				status = "disabled";
> +			};
> +
>  			uart1: serial@1000a000 {
>  				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
>  				reg = <0x1000a000 0x1000>;
> -- 


---
Markus Pargmann June 20, 2013, 3:44 p.m. UTC | #2 
On Thu, Jun 20, 2013 at 07:17:34PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx27.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index 044004a..e883e77 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -110,6 +110,14 @@
> >  				clock-names = "ipg", "per";
> >  			};
> >  
> > +			owire: owire@10009000 {
> > +				compatible = "fsl,imx21-owire";
> 
> I think you should use "fsl,imx27-owire", "fsl,imx21-owire" here.

Fixed, thank you

Markus

> 
> > +				reg = <0x10009000 0x1000>;
> > +				clocks = <&clks 35>;
> > +				clock-names = "ipg";
> > +				status = "disabled";
> > +			};
> > +
> >  			uart1: serial@1000a000 {
> >  				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
> >  				reg = <0x1000a000 0x1000>;
> > -- 
> 
> 
> ---
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 044004a..e883e77 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -110,6 +110,14 @@ 
 				clock-names = "ipg", "per";
 			};
 
+			owire: owire@10009000 {
+				compatible = "fsl,imx21-owire";
+				reg = <0x10009000 0x1000>;
+				clocks = <&clks 35>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
 			uart1: serial@1000a000 {
 				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
 				reg = <0x1000a000 0x1000>;