diff mbox

drm/i915: don't scream into dmesg when a modeset fails

Message ID 1372151212-21155-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter June 25, 2013, 9:06 a.m. UTC
There are legit cases, e.g. when userspace asks for something
impossible. So tune it down to debug output like we do with all other
userspace-triggerable warnings.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66111#c5
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chris Wilson June 25, 2013, 9:10 a.m. UTC | #1
On Tue, Jun 25, 2013 at 11:06:52AM +0200, Daniel Vetter wrote:
> There are legit cases, e.g. when userspace asks for something
> impossible. So tune it down to debug output like we do with all other
> userspace-triggerable warnings.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66111#c5
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Daniel Vetter June 25, 2013, 9:39 a.m. UTC | #2
On Tue, Jun 25, 2013 at 10:10:49AM +0100, Chris Wilson wrote:
> On Tue, Jun 25, 2013 at 11:06:52AM +0200, Daniel Vetter wrote:
> > There are legit cases, e.g. when userspace asks for something
> > impossible. So tune it down to debug output like we do with all other
> > userspace-triggerable warnings.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66111#c5
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Queued for -next, thanks for the review.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index af2b5ab..d86336b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8721,8 +8721,8 @@  static int intel_crtc_set_config(struct drm_mode_set *set)
 		ret = intel_set_mode(set->crtc, set->mode,
 				     set->x, set->y, set->fb);
 		if (ret) {
-			DRM_ERROR("failed to set mode on [CRTC:%d], err = %d\n",
-				  set->crtc->base.id, ret);
+			DRM_DEBUG_KMS("failed to set mode on [CRTC:%d], err = %d\n",
+				      set->crtc->base.id, ret);
 			goto fail;
 		}
 	} else if (config->fb_changed) {