| Message ID | 1372174706-5459-2-git-send-email-t.figa@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > This patch adds OF match table to the driver to allow instantiating it > using device tree. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> when will this driver get merged into dwc2 ?
On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote: > On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > > This patch adds OF match table to the driver to allow instantiating it > > using device tree. > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > when will this driver get merged into dwc2 ? What's dwc2? I can only see dwc3 in mainline kernel tree and it doesn't seem to be compatible with s3c-hsotg. Best regards, Tomasz
On Tue, Jun 25, 2013 at 10:57:06PM +0200, Tomasz Figa wrote: > On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote: > > On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > > > This patch adds OF match table to the driver to allow instantiating it > > > using device tree. > > > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > when will this driver get merged into dwc2 ? > > What's dwc2? I can only see dwc3 in mainline kernel tree and it doesn't > seem to be compatible with s3c-hsotg. drivers/staging/dwc2/ That's the same IP you're using Paul Zimmerman (now in Cc) is working towards getting that out of staging. It currently has only host mode, so plugging your code in there shouldn't be too difficult. OTOH, it might be better to make your code a device-only version of dwc2 (drivers/usb/dwc2) and have Paul move his host side to that instead.
On Wednesday 26 of June 2013 00:00:44 Felipe Balbi wrote: > On Tue, Jun 25, 2013 at 10:57:06PM +0200, Tomasz Figa wrote: > > On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote: > > > On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > > > > This patch adds OF match table to the driver to allow > > > > instantiating it > > > > using device tree. > > > > > > > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > > > when will this driver get merged into dwc2 ? > > > > What's dwc2? I can only see dwc3 in mainline kernel tree and it > > doesn't > > seem to be compatible with s3c-hsotg. > > drivers/staging/dwc2/ Oh right, staging, I forgot to check there. > That's the same IP you're using Paul Zimmerman (now in Cc) is working > towards getting that out of staging. It currently has only host mode, so > plugging your code in there shouldn't be too difficult. > > OTOH, it might be better to make your code a device-only version of dwc2 > (drivers/usb/dwc2) and have Paul move his host side to that instead. Hmm, I believe Lukasz Majewski and Marek Szyprowski (both on CC) should be able to say something more on this topic as I'm not really into USB drivers and just doing Device Tree enablement here. Best regards, Tomasz
Hi, On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > This patch adds OF match table to the driver to allow instantiating it > using device tree. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> I will take this one only, the others have no dependency on this. cheers
diff --git a/Documentation/devicetree/bindings/usb/samsung-hsotg.txt b/Documentation/devicetree/bindings/usb/samsung-hsotg.txt new file mode 100644 index 0000000..b83d428 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/samsung-hsotg.txt @@ -0,0 +1,40 @@ +Samsung High Speed USB OTG controller +----------------------------- + +The Samsung HSOTG IP can be found on Samsung SoCs, from S3C6400 onwards. +It gives functionality of OTG-compliant USB 2.0 host and device with +support for USB 2.0 high-speed (480Mbps) and full-speed (12 Mbps) +operation. + +Currently only device mode is supported. + +Binding details +----- + +Required properties: +- compatible: "samsung,s3c6400-hsotg" should be used for all currently + supported SoC, +- interrupt-parent: phandle for the interrupt controller to which the + interrupt signal of the HSOTG block is routed, +- interrupts: specifier of interrupt signal of interrupt controller, + according to bindings of interrupt controller, +- clocks: contains an array of clock specifiers: + - first entry: OTG clock +- clock-names: contains array of clock names: + - first entry: must be "otg" +- vusb_d-supply: phandle to voltage regulator of digital section, +- vusb_a-supply: phandle to voltage regulator of analog section. + +Example +----- + + hsotg@12480000 { + compatible = "samsung,s3c6400-hsotg"; + reg = <0x12480000 0x20000>; + interrupts = <0 71 0>; + clocks = <&clock 305>; + clock-names = "otg"; + vusb_d-supply = <&vusb_reg>; + vusb_a-supply = <&vusbdac_reg>; + }; + diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index af22f24..616ed51 100644 --- a/drivers/usb/gadget/s3c-hsotg.c +++ b/drivers/usb/gadget/s3c-hsotg.c @@ -29,6 +29,7 @@ #include <linux/slab.h> #include <linux/clk.h> #include <linux/regulator/consumer.h> +#include <linux/of_platform.h> #include <linux/usb/ch9.h> #include <linux/usb/gadget.h> @@ -3648,10 +3649,19 @@ static int s3c_hsotg_remove(struct platform_device *pdev) #define s3c_hsotg_resume NULL #endif +#ifdef CONFIG_OF +static const struct of_device_id s3c_hsotg_of_ids[] = { + { .compatible = "samsung,s3c6400-hsotg", }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, s3c_hsotg_of_ids); +#endif + static struct platform_driver s3c_hsotg_driver = { .driver = { .name = "s3c-hsotg", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(s3c_hsotg_of_ids), }, .probe = s3c_hsotg_probe, .remove = s3c_hsotg_remove,