diff mbox

[2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi

Message ID 001601ce73bf$9f2e9120$dd8bb360$@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jingoo Han June 28, 2013, 5:23 a.m. UTC
Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Comments

Kishon Vijay Abraham I June 28, 2013, 5:41 a.m. UTC | #1
Hi,

On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:
> Add PHY provider node for the DP PHY.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>   arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
>   1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 41cd625..d1d6e14 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,6 +614,12 @@
>   		interrupts = <0 94 0>;
>   	};
>
> +	dp_phy: video-phy@10040720 {
> +		compatible = "samsung,exynos5250-dp-video-phy";
> +		reg = <0x10040720 4>;
> +		#phy-cells = <1>;

phy-cells can be '0' here since this phy_provider implements only one PHY.

Thanks
Kishon
Jingoo Han June 28, 2013, 5:58 a.m. UTC | #2
On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:
> 
> Hi,
> 
> On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:
> > Add PHY provider node for the DP PHY.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> >   arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
> >   1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> > index 41cd625..d1d6e14 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -614,6 +614,12 @@
> >   		interrupts = <0 94 0>;
> >   	};
> >
> > +	dp_phy: video-phy@10040720 {
> > +		compatible = "samsung,exynos5250-dp-video-phy";
> > +		reg = <0x10040720 4>;
> > +		#phy-cells = <1>;
> 
> phy-cells can be '0' here since this phy_provider implements only one PHY.

Oh, thank you.
I will fix it.

Best regards,
Jingoo Han

> 
> Thanks
> Kishon
Jason Wang June 28, 2013, 6:06 a.m. UTC | #3
On 06/28/2013 01:58 PM, Jingoo Han wrote:
> On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:
>>> Add PHY provider node for the DP PHY.
>>>
>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>>> ---
>>>    arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
>>>    1 file changed, 8 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>>> index 41cd625..d1d6e14 100644
>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>> @@ -614,6 +614,12 @@
>>>    		interrupts = <0 94 0>;
>>>    	};
>>>
>>> +	dp_phy: video-phy@10040720 {
>>> +		compatible = "samsung,exynos5250-dp-video-phy";
>>> +		reg = <0x10040720 4>;
>>> +		#phy-cells = <1>;
>> phy-cells can be '0' here since this phy_provider implements only one PHY.
> Oh, thank you.
> I will fix it.
Don't forget to fix the corresponding description in the 
samsung,exynos5250-dp-video-phy.txt as well. :-)
> Best regards,
> Jingoo Han
>
>> Thanks
>> Kishon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
Jingoo Han June 28, 2013, 6:09 a.m. UTC | #4
On Friday, June 28, 2013 3:07 PM, Hui Wang wrote:
> On 06/28/2013 01:58 PM, Jingoo Han wrote:
> > On Friday, June 28, 2013 2:42 PM, Kishon Vijay Abraham I wrote:
> >> Hi,
> >>
> >> On Friday 28 June 2013 10:53 AM, Jingoo Han wrote:
> >>> Add PHY provider node for the DP PHY.
> >>>
> >>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >>> ---
> >>>    arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
> >>>    1 file changed, 8 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> >>> index 41cd625..d1d6e14 100644
> >>> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >>> @@ -614,6 +614,12 @@
> >>>    		interrupts = <0 94 0>;
> >>>    	};
> >>>
> >>> +	dp_phy: video-phy@10040720 {
> >>> +		compatible = "samsung,exynos5250-dp-video-phy";
> >>> +		reg = <0x10040720 4>;
> >>> +		#phy-cells = <1>;
> >> phy-cells can be '0' here since this phy_provider implements only one PHY.
> > Oh, thank you.
> > I will fix it.
> Don't forget to fix the corresponding description in the
> samsung,exynos5250-dp-video-phy.txt as well. :-)

Hi 

OK, I already fixed it. :)
Thank you for reminding me.

Best regards,
Jignoo Han

> > Best regards,
> > Jingoo Han
> >
> >> Thanks
> >> Kishon
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> >
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..d1d6e14 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -614,6 +614,12 @@ 
 		interrupts = <0 94 0>;
 	};
 
+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <1>;
+	};
+
 	dp-controller {
 		compatible = "samsung,exynos5-dp";
 		reg = <0x145b0000 0x1000>;
@@ -623,11 +629,8 @@ 
 		clock-names = "dp";
 		#address-cells = <1>;
 		#size-cells = <0>;
-
-		dptx-phy {
-			reg = <0x10040720>;
-			samsung,enable-mask = <1>;
-		};
+		phys = <&dp_phy 0>;
+		phy-names = "dp";
 	};
 
 	fimd {