| Message ID | 825827984.224981242990310267.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Michael Goldish wrote: > This makes sense, thanks. > > One thing though -- I don't know if it's even worth mentioning -- we always try to put a single space after a comma (I think the Python style guide recommends that but I'm not sure). Generally we try to follow the guide (http://www.python.org/dev/peps/pep-0008/) and as far as I know Autotest follows it too. > Strongly agree, Python's syntax allows us to write very pretty code, it makes sense to preserve this.
Avi Kivity wrote: > Michael Goldish wrote: >> This makes sense, thanks. >> >> One thing though -- I don't know if it's even worth mentioning -- we >> always try to put a single space after a comma (I think the Python >> style guide recommends that but I'm not sure). Generally we try to >> follow the guide (http://www.python.org/dev/peps/pep-0008/) and as far >> as I know Autotest follows it too. >> > > Strongly agree, Python's syntax allows us to write very pretty code, it > makes sense to preserve this. > Thanks for the advice new patch to follow shortly.... -D -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/client/tests/kvm_runtest_2/kvm_config.py b/client/tests/kvm_runtest_2/kvm_config.py index 4a1e7b4..29a63b7 100755 --- a/client/tests/kvm_runtest_2/kvm_config.py +++ b/client/tests/kvm_runtest_2/kvm_config.py @@ -94,7 +94,7 @@ class config: def split_and_strip(self, str, sep="="): """Split str and strip quotes from the resulting parts.""" - temp = str.split(sep) + temp = str.split(sep,1) for i in range(len(temp)): temp[i] = temp[i].strip() temp[i] = temp[i].strip("\"\'")
This makes sense, thanks. One thing though -- I don't know if it's even worth mentioning -- we always try to put a single space after a comma (I think the Python style guide recommends that but I'm not sure). Generally we try to follow the guide (http://www.python.org/dev/peps/pep-0008/) and as far as I know Autotest follows it too. ----- Original Message ----- From: "David Huff" <dhuff@redhat.com> To: kvm@vger.kernel.org Cc: "David Huff" <dhuff@redhat.com> Sent: Thursday, May 21, 2009 6:36:21 PM (GMT+0200) Auto-Detected Subject: [PATCH] [KVM_Autotest] Fix to allow for "=" in the "value" of a config parameter. fix modifies kvm_config.split_and_strip so it will only split once per line. example: kernel_args = "ks=floppy console=ttyS0 noacpi" --- client/tests/kvm_runtest_2/kvm_config.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)