| Message ID | 1372424577-8279-6-git-send-email-alexandre.belloni@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Alexandre On Fri, Jun 28, 2013 at 03:02:54PM +0200, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> With one minor comment, that applies to your other patches as well. > --- > arch/arm/boot/dts/imx28-cfa10037.dts | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/imx28-cfa10037.dts b/arch/arm/boot/dts/imx28-cfa10037.dts > index c2ef3a3..182b99f 100644 > --- a/arch/arm/boot/dts/imx28-cfa10037.dts > +++ b/arch/arm/boot/dts/imx28-cfa10037.dts > @@ -22,13 +22,19 @@ > apb@80000000 { > apbh@80000000 { > pinctrl@80018000 { > - pinctrl-names = "default", "default"; > - pinctrl-1 = <&hog_pins_cfa10037>; The pinctrl-name property isn't relevant since the 10036 patch. You should probably have ordered them the other way around: first the breakout board, then the 10036. Maxime
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Shawn, On 29/06/2013 09:05, Maxime Ripard wrote: >> --- >> arch/arm/boot/dts/imx28-cfa10037.dts | 19 ++++++++++++++----- >> 1 file changed, 14 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx28-cfa10037.dts b/arch/arm/boot/dts/imx28-cfa10037.dts >> index c2ef3a3..182b99f 100644 >> --- a/arch/arm/boot/dts/imx28-cfa10037.dts >> +++ b/arch/arm/boot/dts/imx28-cfa10037.dts >> @@ -22,13 +22,19 @@ >> apb@80000000 { >> apbh@80000000 { >> pinctrl@80018000 { >> - pinctrl-names = "default", "default"; >> - pinctrl-1 = <&hog_pins_cfa10037>; > > The pinctrl-name property isn't relevant since the 10036 patch. You > should probably have ordered them the other way around: first the > breakout board, then the 10036. Do you want me to send a reordered serie or will you do it when applying the patches ? You can just apply patch 4/8 last. thanks, - -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJR0FikAAoJEKbNnwlvZCyz40UQAMwmqHS1p0tY6MJ6fPy6rBK8 SH/a1afzKxudNxT5JzM4k5YR1V9TjJXnq658jcu0p5HiYpvCpgXDbde1QKJwf5Hg lZMw8hg2ogEvCOvaiOGbXc4qEReVWPV5xKw26ur7S8rwNg1AenDJw0tBZIjHzOUp yo1ZaGC5mV3MDzOcbZ1sfrMXCB2Alwa0zS5Mc1cKIj9d2uVp0U6feWAZ2+1iVcK8 Js23PEpMaagwAWxVjfMH2LThj/vxnM7lkOisaAsbnTyalW7ztdqUhzL4qqFQ7WrC D8gKgEo9cFTNJrfuwB09eVZmCW8/OqBC0uTH4StgneOwWsiRAn2UZPqwxW2BChik LeQI+1W67GzVFyuxwmipQyNOCU8iJOKST4a2wIgCiZ27iWPRX5TFOqSr2E1L/lzX Fdmjjjr9ezxbyFx/hOOvYxZtfCpeyFo0nHfnSU4JnAncC5pQqzgo2ZvvmoGFJE92 jVvhThOGh+glDk85/7Dt5PhXCPQWdwDxu8V6QlWD4RXfAAixq1vCo2odKjaC6P5W 2aEaBaT0oe1YKCKL7s/62gLNwwUtasZyJChhJikhV06aQt8qYdVyP7MYRZaXC8EZ LcRSAhj+IZUqykqW6VhBlxjxq5Q/HdzgUcwn0EKdhQ2blHhB5cdfQxFLXZpGPsoi b0+7VLLSM9VeofjhDB2Z =/A5s -----END PGP SIGNATURE-----
On Sun, Jun 30, 2013 at 06:11:16PM +0200, Alexandre Belloni wrote: > Do you want me to send a reordered serie or will you do it when applying > the patches ? You can just apply patch 4/8 last. Please resend, since you have some comments from Maxime on patch #2 unresolved? Shawn
On 01/07/2013 11:06, Shawn Guo wrote: > On Sun, Jun 30, 2013 at 06:11:16PM +0200, Alexandre Belloni wrote: >> Do you want me to send a reordered serie or will you do it when applying >> the patches ? You can just apply patch 4/8 last. > > Please resend, since you have some comments from Maxime on patch #2 > unresolved? > Oh right, forgot about that one, sorry. I will send v4. > Shawn >
diff --git a/arch/arm/boot/dts/imx28-cfa10037.dts b/arch/arm/boot/dts/imx28-cfa10037.dts index c2ef3a3..182b99f 100644 --- a/arch/arm/boot/dts/imx28-cfa10037.dts +++ b/arch/arm/boot/dts/imx28-cfa10037.dts @@ -22,13 +22,19 @@ apb@80000000 { apbh@80000000 { pinctrl@80018000 { - pinctrl-names = "default", "default"; - pinctrl-1 = <&hog_pins_cfa10037>; - - hog_pins_cfa10037: hog-10037@0 { + usb_pins_cfa10037: usb-10037@0 { reg = <0>; fsl,pinmux-ids = < 0x0073 /* MX28_PAD_GPMI_D7__GPIO_0_7 */ + >; + fsl,drive-strength = <0>; + fsl,voltage = <1>; + fsl,pull-up = <0>; + }; + + mac0_pins_cfa10037: mac0-10037@0 { + reg = <0>; + fsl,pinmux-ids = < 0x2153 /* MX28_PAD_SSP2_D5__GPIO_2_21 */ >; fsl,drive-strength = <0>; @@ -56,7 +62,8 @@ mac0: ethernet@800f0000 { phy-mode = "rmii"; pinctrl-names = "default"; - pinctrl-0 = <&mac0_pins_a>; + pinctrl-0 = <&mac0_pins_a + &mac0_pins_cfa10037>; phy-reset-gpios = <&gpio2 21 0>; phy-reset-duration = <100>; status = "okay"; @@ -68,6 +75,8 @@ reg_usb1_vbus: usb1_vbus { compatible = "regulator-fixed"; + pinctrl-names = "default"; + pinctrl-0 = <&usb_pins_cfa10037>; regulator-name = "usb1_vbus"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>;
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- arch/arm/boot/dts/imx28-cfa10037.dts | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)