diff mbox

[v9,01/10] ASoC: imx-pcm-dma: DT support

Message ID 1371734429-6081-2-git-send-email-mpa@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Markus Pargmann June 20, 2013, 1:20 p.m. UTC 
This patch removes the NO_DT flag. The pdev pointer may have a proper
of_node with the dmas property, so we can use it to request DMA
channels.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Tested-by: Shawn Guo <shawn.guo@linaro.org>
---

Notes:
    Changes in v6:
     - After rebasing onto Shawn's imx-pcm cleanups, this patch just consists of
       removing the NO_DT flag.
    
    Changes in v5:
     - Use dev.parent pointer to get the of_node.

 sound/soc/fsl/imx-pcm-dma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Timur Tabi June 23, 2013, 5:49 p.m. UTC | #1 
Markus Pargmann wrote:
> This patch removes the NO_DT flag. The pdev pointer may have a proper
> of_node with the dmas property, so we can use it to request DMA
> channels.
>
> Signed-off-by: Markus Pargmann<mpa@pengutronix.de>
> Tested-by: Shawn Guo<shawn.guo@linaro.org>
> ---

I won't have access to functioning hardware for another month or two, so I 
can't test to see if this patchset breaks PowerPC, but at least it does 
compile.  I'm a little worried that the DMA changes won't actually run on 
PowerPC, but I can't test that now.

So for the time being:

Acked-by: Timur Tabi <timur@tabi.org>
Mark Brown July 3, 2013, 4:02 p.m. UTC | #2 
On Thu, Jun 20, 2013 at 03:20:20PM +0200, Markus Pargmann wrote:
> This patch removes the NO_DT flag. The pdev pointer may have a proper
> of_node with the dmas property, so we can use it to request DMA
> channels.

Applied, thanks.
Markus Pargmann July 5, 2013, 1:56 p.m. UTC | #3 
On Sun, Jun 23, 2013 at 12:49:17PM -0500, Timur Tabi wrote:
> Markus Pargmann wrote:
> > This patch removes the NO_DT flag. The pdev pointer may have a proper
> > of_node with the dmas property, so we can use it to request DMA
> > channels.
> >
> > Signed-off-by: Markus Pargmann<mpa@pengutronix.de>
> > Tested-by: Shawn Guo<shawn.guo@linaro.org>
> > ---
> 
> I won't have access to functioning hardware for another month or two, so I 
> can't test to see if this patchset breaks PowerPC, but at least it does 
> compile.  I'm a little worried that the DMA changes won't actually run on 
> PowerPC, but I can't test that now.

The DMA channels should end up to be NULL on PowerPC within the generic
dmaengine pcm, so it should fall back to NO_DT automatically.

> 
> So for the time being:
> 
> Acked-by: Timur Tabi <timur@tabi.org>
> 
> -- 
> Timur Tabi
> 

Thanks,

Markus
diff mbox

Patch

diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c
index fde4d2e..f323ce0 100644
--- a/sound/soc/fsl/imx-pcm-dma.c
+++ b/sound/soc/fsl/imx-pcm-dma.c
@@ -64,7 +64,6 @@  int imx_pcm_dma_init(struct platform_device *pdev)
 {
 	return snd_dmaengine_pcm_register(&pdev->dev, &imx_dmaengine_pcm_config,
 		SND_DMAENGINE_PCM_FLAG_NO_RESIDUE |
-		SND_DMAENGINE_PCM_FLAG_NO_DT |
 		SND_DMAENGINE_PCM_FLAG_COMPAT);
 }
 EXPORT_SYMBOL_GPL(imx_pcm_dma_init);