diff mbox

[4/8] drm/omap: Remove redundant debugfs cleanup

Message ID 1373223745-9095-4-git-send-email-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson July 7, 2013, 7:02 p.m. UTC
All inode removal is handled for us by the core.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rob Clark <robdclark@gmail.com>
---
 drivers/gpu/drm/omapdrm/omap_debugfs.c | 10 ----------
 drivers/gpu/drm/omapdrm/omap_drv.c     |  1 -
 drivers/gpu/drm/omapdrm/omap_drv.h     |  1 -
 3 files changed, 12 deletions(-)

Comments

Rob Clark July 7, 2013, 11:40 p.m. UTC | #1
On Sun, Jul 7, 2013 at 3:02 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> All inode removal is handled for us by the core.

Acked-by: Rob Clark <robdclark@gmail.com>

> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rob Clark <robdclark@gmail.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_debugfs.c | 10 ----------
>  drivers/gpu/drm/omapdrm/omap_drv.c     |  1 -
>  drivers/gpu/drm/omapdrm/omap_drv.h     |  1 -
>  3 files changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c
> index c27f59d..6a11c2c 100644
> --- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
> +++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
> @@ -112,14 +112,4 @@ int omap_debugfs_init(struct drm_minor *minor)
>
>         return ret;
>  }
> -
> -void omap_debugfs_cleanup(struct drm_minor *minor)
> -{
> -       drm_debugfs_remove_files(omap_debugfs_list,
> -                       ARRAY_SIZE(omap_debugfs_list), minor);
> -       if (dmm_is_available())
> -               drm_debugfs_remove_files(omap_dmm_debugfs_list,
> -                               ARRAY_SIZE(omap_dmm_debugfs_list), minor);
> -}
> -
>  #endif
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 826586f..9a08219 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -607,7 +607,6 @@ static struct drm_driver omap_drm_driver = {
>                 .irq_handler = omap_irq_handler,
>  #ifdef CONFIG_DEBUG_FS
>                 .debugfs_init = omap_debugfs_init,
> -               .debugfs_cleanup = omap_debugfs_cleanup,
>  #endif
>                 .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>                 .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
> index 215a20d..27ca8f1 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.h
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.h
> @@ -129,7 +129,6 @@ struct omap_drm_private {
>
>  #ifdef CONFIG_DEBUG_FS
>  int omap_debugfs_init(struct drm_minor *minor);
> -void omap_debugfs_cleanup(struct drm_minor *minor);
>  void omap_framebuffer_describe(struct drm_framebuffer *fb, struct seq_file *m);
>  void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m);
>  void omap_gem_describe_objects(struct list_head *list, struct seq_file *m);
> --
> 1.8.3.2
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c
index c27f59d..6a11c2c 100644
--- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
+++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
@@ -112,14 +112,4 @@  int omap_debugfs_init(struct drm_minor *minor)
 
 	return ret;
 }
-
-void omap_debugfs_cleanup(struct drm_minor *minor)
-{
-	drm_debugfs_remove_files(omap_debugfs_list,
-			ARRAY_SIZE(omap_debugfs_list), minor);
-	if (dmm_is_available())
-		drm_debugfs_remove_files(omap_dmm_debugfs_list,
-				ARRAY_SIZE(omap_dmm_debugfs_list), minor);
-}
-
 #endif
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 826586f..9a08219 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -607,7 +607,6 @@  static struct drm_driver omap_drm_driver = {
 		.irq_handler = omap_irq_handler,
 #ifdef CONFIG_DEBUG_FS
 		.debugfs_init = omap_debugfs_init,
-		.debugfs_cleanup = omap_debugfs_cleanup,
 #endif
 		.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
 		.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h
index 215a20d..27ca8f1 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.h
+++ b/drivers/gpu/drm/omapdrm/omap_drv.h
@@ -129,7 +129,6 @@  struct omap_drm_private {
 
 #ifdef CONFIG_DEBUG_FS
 int omap_debugfs_init(struct drm_minor *minor);
-void omap_debugfs_cleanup(struct drm_minor *minor);
 void omap_framebuffer_describe(struct drm_framebuffer *fb, struct seq_file *m);
 void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m);
 void omap_gem_describe_objects(struct list_head *list, struct seq_file *m);