diff mbox

drm/rcar-du: Add missing dependency on CMA

Message ID 1373453534-6425-1-git-send-email-broonie@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Brown July 10, 2013, 10:52 a.m. UTC 
From: Mark Brown <broonie@linaro.org>

The driver uses CMA APIs so won't link if CMA is not being built.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/gpu/drm/rcar-du/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown July 10, 2013, 11:07 a.m. UTC | #1 
On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote:
> On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:

> >  config DRM_RCAR_DU
> >  	tristate "DRM Support for R-Car Display Unit"
> > -	depends on DRM && ARM
> > +	depends on DRM && ARM && CMA
> >  	select DRM_KMS_HELPER
> >  	select DRM_KMS_CMA_HELPER
> >  	select DRM_GEM_CMA_HELPER

> Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?

Sadly select doesn't do the right thing with dependencies - it just
ignores them.
diff mbox

Patch

diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index 72887df..e75575a 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -1,6 +1,6 @@ 
 config DRM_RCAR_DU
 	tristate "DRM Support for R-Car Display Unit"
-	depends on DRM && ARM
+	depends on DRM && ARM && CMA
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER