diff mbox

ARM: multiplatform: remove reference to ARCH_MULTI_V4

Message ID 1373746191.1359.37.camel@x61.thuisdomein (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Bolle July 13, 2013, 8:09 p.m. UTC
The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
("ARM: multiplatform: always pick one CPU type"). Remove the last
reference to it too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested.

1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
the ARM section of the Kconfig files is rather complicated for people,
like me, that aren't familiar with the way the ARM universe is divided
in architectures, machines, platforms, etc. That makes it hard to say
whether ARCH_MULTI_V4 was dropped on purpose or by accident.

 arch/arm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnd Bergmann July 14, 2013, 8:34 a.m. UTC | #1
On Saturday 13 July 2013, Paul Bolle wrote:
> The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
> ("ARM: multiplatform: always pick one CPU type"). Remove the last
> reference to it too.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Untested.
> 
> 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
> the ARM section of the Kconfig files is rather complicated for people,
> like me, that aren't familiar with the way the ARM universe is divided
> in architectures, machines, platforms, etc. That makes it hard to say
> whether ARCH_MULTI_V4 was dropped on purpose or by accident.

It was dropped on purpose because it is unused in 3.11 but it will
be used again in 3.12, so I wouldn't bother with your patch.

Thanks anyway for looking into unused symbols, I think checking for
unused code like this is very useful in general.

	Arnd
Paul Bolle Feb. 10, 2014, 1:20 a.m. UTC | #2
On Sun, 2013-07-14 at 10:34 +0200, Arnd Bergmann wrote:
> On Saturday 13 July 2013, Paul Bolle wrote:
> > The Kconfig symbol ARCH_MULTI_V4 was removed in commit 24e860fbfd
> > ("ARM: multiplatform: always pick one CPU type"). Remove the last
> > reference to it too.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) Untested.
> > 
> > 1) Commit 24e860fbfd is silent on the reason to drop ARCH_MULTI_V4. And
> > the ARM section of the Kconfig files is rather complicated for people,
> > like me, that aren't familiar with the way the ARM universe is divided
> > in architectures, machines, platforms, etc. That makes it hard to say
> > whether ARCH_MULTI_V4 was dropped on purpose or by accident.
> 
> It was dropped on purpose because it is unused in 3.11 but it will
> be used again in 3.12, so I wouldn't bother with your patch.
> 
> Thanks anyway for looking into unused symbols, I think checking for
> unused code like this is very useful in general.

We're now at v3.14-rc1 and ARCH_MULTI_V4 is still unused. Are there still plans to
use it again?


Paul Bolle
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0ac9be6..0746bc8 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -912,7 +912,7 @@  config ARCH_MULTI_V6_V7
 	bool
 
 config ARCH_MULTI_CPU_AUTO
-	def_bool !(ARCH_MULTI_V4 || ARCH_MULTI_V4T || ARCH_MULTI_V6_V7)
+	def_bool !(ARCH_MULTI_V4T || ARCH_MULTI_V6_V7)
 	select ARCH_MULTI_V5
 
 endmenu