| Message ID | 1373804812.1370.23.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jul 14, 2013 at 02:26:52PM +0200, Paul Bolle wrote: > Commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT for EXYNOS > SoCs") removed the Kconfig symbols MACH_SMDKV310 and MACH_SMDKC210. > Now remove the references to both of these symbols from the Kconfig > entry for SND_SOC_SAMSUNG_SMDK_WM9713. They're not needed anymore. Look at the code you are editing here: > - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210) > + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110) Simply removing the dependencies is not going to give the clearly intended effect here. The dependency on the DT only machine needs to be replaced with something, not just deleted, otherwise the driver can't be enabled in Kconfig. Also let me again remind you to submit patches with subject lines that are appropriate for the subsystem you're updating. I very nearly deleted this unread since it looks like a patch for arch/arm with no relationship with audio but in fact it doesn't touch arch/arm at all.
On Sun, 2013-07-14 at 13:45 +0100, Mark Brown wrote: > Look at the code you are editing here: > > > - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210) > > + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110) > > Simply removing the dependencies is not going to give the clearly > intended effect here. The dependency on the DT only machine needs to be > replaced with something, not just deleted, otherwise the driver can't be > enabled in Kconfig. I interpreted commit 383ffda2fa as a commit that just removed a lot of stuff: see its commit explanation and its diffstat (it adds one line and deletes over 900 lines). Moreover, after that commit the references to MACH_SMDKV310 and MACH_SMDKC210 both are nops. Deleting them can't possibly change anything. But, anyhow, what would be the symbols to use here? > Also let me again remind you to submit patches with subject lines that > are appropriate for the subsystem you're updating. I very nearly > deleted this unread since it looks like a patch for arch/arm with no > relationship with audio but in fact it doesn't touch arch/arm at all. I do try to use subject lines that are used in the sections I touch. I seem to remember that you asked me _once_, I think one or two years ago, to adjust to the system used for SoC. Since then you've received a number of patches from me that, as far as I can remember, always used that system. Besides, this patch was intended as a follow up to commit 383ffda2fa, to clean up two references it apparently forgot to remove, and therefor basically copied the subject line used in that commit. Paul Bolle
On Sun, Jul 14, 2013 at 03:18:16PM +0200, Paul Bolle wrote: > On Sun, 2013-07-14 at 13:45 +0100, Mark Brown wrote: > > Simply removing the dependencies is not going to give the clearly > > intended effect here. The dependency on the DT only machine needs to be > > replaced with something, not just deleted, otherwise the driver can't be > > enabled in Kconfig. > I interpreted commit 383ffda2fa as a commit that just removed a lot of Always provide human readable descriptions of commits in email. > stuff: see its commit explanation and its diffstat (it adds one line and > deletes over 900 lines). Moreover, after that commit the references to > MACH_SMDKV310 and MACH_SMDKC210 both are nops. Deleting them can't > possibly change anything. This still doesn't have much to do with your commit message or indicate much understanding of what the change is actually doing or why it might be a problem. > But, anyhow, what would be the symbols to use here? Well, let's think about this for a minute - what is going on when someone does a device tree conversion on a platform? What is replacing the board files? What would an equivalent change be for the audio driver? > Besides, this patch was intended as a follow up to commit 383ffda2fa, to > clean up two references it apparently forgot to remove, and therefor > basically copied the subject line used in that commit. That doesn't really help - putting in a completely irrelevant subject line is a really good way to get your patch ignored.
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 9855dfc..3d76659 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -136,7 +136,7 @@ config SND_SOC_SAMSUNG_RX1950_UDA1380 config SND_SOC_SAMSUNG_SMDK_WM9713 tristate "SoC AC97 Audio support for SMDK with WM9713" - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210) + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110) select SND_SOC_WM9713 select SND_SAMSUNG_AC97 help
Commit 383ffda2fa ("ARM: EXYNOS: no more support non-DT for EXYNOS SoCs") removed the Kconfig symbols MACH_SMDKV310 and MACH_SMDKC210. Now remove the references to both of these symbols from the Kconfig entry for SND_SOC_SAMSUNG_SMDK_WM9713. They're not needed anymore. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. sound/soc/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)