| Message ID | 1374226039-16943-2-git-send-email-oleksandr.kozaruk@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 19-07-2013 13:27, Oleksandr Kozaruk wrote: > GPADC is the general purpose ADC present on twl6030. > The dt data is interrupt used to trigger end of ADC > conversion. > Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com> > --- > arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi > index 2e3bd31..d7d4c28 100644 > --- a/arch/arm/boot/dts/twl6030.dtsi > +++ b/arch/arm/boot/dts/twl6030.dtsi > @@ -103,4 +103,10 @@ > compatible = "ti,twl6030-pwmled"; > #pwm-cells = <2>; > }; > + > + adc: gpadc { Read my lips: the node should be called just "adc", not "gpadc". WBR, Sergei
On 07/19/2013 05:39 PM, Sergei Shtylyov wrote: > Hello. > > On 19-07-2013 13:27, Oleksandr Kozaruk wrote: > >> GPADC is the general purpose ADC present on twl6030. >> The dt data is interrupt used to trigger end of ADC >> conversion. > >> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com> >> --- >> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) > >> diff --git a/arch/arm/boot/dts/twl6030.dtsi >> b/arch/arm/boot/dts/twl6030.dtsi >> index 2e3bd31..d7d4c28 100644 >> --- a/arch/arm/boot/dts/twl6030.dtsi >> +++ b/arch/arm/boot/dts/twl6030.dtsi >> @@ -103,4 +103,10 @@ >> compatible = "ti,twl6030-pwmled"; >> #pwm-cells = <2>; >> }; >> + >> + adc: gpadc { > > Read my lips: the node should be called just "adc", not "gpadc". ^^^^^^^^^^^^ Are you sure? Why? The name was selected according to the documentation on device "General purpose analog-to-digital converter (GPADC)". PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards, - grygorii
Hello. On 07/19/2013 07:40 PM, Grygorii Strashko wrote: >>> GPADC is the general purpose ADC present on twl6030. >>> The dt data is interrupt used to trigger end of ADC >>> conversion. >>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com> >>> --- >>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> diff --git a/arch/arm/boot/dts/twl6030.dtsi >>> b/arch/arm/boot/dts/twl6030.dtsi >>> index 2e3bd31..d7d4c28 100644 >>> --- a/arch/arm/boot/dts/twl6030.dtsi >>> +++ b/arch/arm/boot/dts/twl6030.dtsi >>> @@ -103,4 +103,10 @@ >>> compatible = "ti,twl6030-pwmled"; >>> #pwm-cells = <2>; >>> }; >>> + >>> + adc: gpadc { >> Read my lips: the node should be called just "adc", not "gpadc". > ^^^^^^^^^^^^ Are you sure? I didn't know how to express my disappointment from Oleksandr's inability to understand what I wanted to convey to him from 2 attempts... first, he changed the label instead of the node name, then he only dropped "twl6030_" prefix from the name. I should probably have been even more specific before. > Why? The name was selected according to the documentation on device "General > purpose analog-to-digital converter (GPADC)". Sigh, we simply don't care whether this ADC is general-purpose or not. The main thing it is ADC. > PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P GPIO is well known and established abbreviation, contrasted to GPADC. Moreover, ePAPR spec lists "gpio" as a generic node name. WBR, Sergei
Hi Sergei, On Fri, Jul 19, 2013 at 1:18 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > > On 07/19/2013 07:40 PM, Grygorii Strashko wrote: > >>>> GPADC is the general purpose ADC present on twl6030. >>>> The dt data is interrupt used to trigger end of ADC >>>> conversion. > > >>>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com> >>>> --- >>>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ >>>> 1 file changed, 6 insertions(+) > > >>>> diff --git a/arch/arm/boot/dts/twl6030.dtsi >>>> b/arch/arm/boot/dts/twl6030.dtsi >>>> index 2e3bd31..d7d4c28 100644 >>>> --- a/arch/arm/boot/dts/twl6030.dtsi >>>> +++ b/arch/arm/boot/dts/twl6030.dtsi >>>> @@ -103,4 +103,10 @@ >>>> compatible = "ti,twl6030-pwmled"; >>>> #pwm-cells = <2>; >>>> }; >>>> + >>>> + adc: gpadc { > > >>> Read my lips: the node should be called just "adc", not "gpadc". >> >> ^^^^^^^^^^^^ Are you sure? > > > I didn't know how to express my disappointment from Oleksandr's inability > to understand what I wanted to convey to him from 2 attempts... first, How would you comment the following code, v3.10-rc7: arch/arm/boot/dts/dbx5x0.dtsi, line 375 375 ab8500-gpadc { 376 compatible = "stericsson,ab8500-gpadc"; 377 interrupts = <32 IRQ_TYPE_LEVEL_HIGH arch/arm/boot/dts/dbx5x0.dtsi: ab8500-gpadc { arch/arm/boot/dts/dbx5x0.dtsi: compatible = "stericsson,ab8500-gpadc"; arch/arm/boot/dts/dbx5x0.dtsi: vddadc-supply = <&ab8500_ldo_tvout_reg>; arch/arm/boot/dts/sama5d3.dtsi: tsadcc: tsadcc@f8018000 { arch/arm/boot/dts/sama5d3.dtsi: compatible = "atmel,at91sam9x5-tsadcc"; arch/arm/boot/dts/sama5d3.dtsi: atmel,tsadcc_clock = <300000>; arch/arm/boot/dts/am33xx.dtsi: tscadc: tscadc@44e0d000 { arch/arm/boot/dts/am33xx.dtsi: compatible = "ti,am3359-tscadc"; arch/arm/boot/dts/am33xx.dtsi: ti,hwmods = "adc_tsc"; arch/arm/boot/dts/am33xx.dtsi: am335x_adc: adc { arch/arm/boot/dts/am33xx.dtsi: compatible = "ti,am3359-adc"; Regards, Sasha. > changed the label instead of the node name, then he only dropped "twl6030_" > prefix from the name. I should probably have been even more specific before. > > >> Why? The name was selected according to the documentation on device >> "General >> purpose analog-to-digital converter (GPADC)". > > > Sigh, we simply don't care whether this ADC is general-purpose or not. > The main thing it is ADC. > > >> PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P > > > GPIO is well known and established abbreviation, contrasted to GPADC. > Moreover, ePAPR spec lists "gpio" as a generic node name. > > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi index 2e3bd31..d7d4c28 100644 --- a/arch/arm/boot/dts/twl6030.dtsi +++ b/arch/arm/boot/dts/twl6030.dtsi @@ -103,4 +103,10 @@ compatible = "ti,twl6030-pwmled"; #pwm-cells = <2>; }; + + adc: gpadc { + compatible = "ti,twl6030-gpadc"; + interrupts = <3>; + #io-channel-cells = <1>; + }; };
GPADC is the general purpose ADC present on twl6030. The dt data is interrupt used to trigger end of ADC conversion. Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com> --- arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)