| Message ID | 1372228350-6375-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26 June 2013 12:02, Sachin Kamat <sachin.kamat@linaro.org> wrote: > 'vub300_init_card' is used only in this file. Make it > static. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/vub300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c > index cb9f361..e9028ad 100644 > --- a/drivers/mmc/host/vub300.c > +++ b/drivers/mmc/host/vub300.c > @@ -2079,7 +2079,7 @@ static void vub300_enable_sdio_irq(struct mmc_host *mmc, int enable) > kref_put(&vub300->kref, vub300_delete); > } > > -void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) > +static void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) > { /* NOT irq */ > struct vub300_mmc_host *vub300 = mmc_priv(mmc); > dev_info(&vub300->udev->dev, "NO host QUIRKS for this card\n"); > -- > 1.7.9.5 > Ping..
On 26 June 2013 12:02, Sachin Kamat <sachin.kamat@linaro.org> wrote: > 'vub300_init_card' is used only in this file. Make it > static. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/vub300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c > index cb9f361..e9028ad 100644 > --- a/drivers/mmc/host/vub300.c > +++ b/drivers/mmc/host/vub300.c > @@ -2079,7 +2079,7 @@ static void vub300_enable_sdio_irq(struct mmc_host *mmc, int enable) > kref_put(&vub300->kref, vub300_delete); > } > > -void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) > +static void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) > { /* NOT irq */ > struct vub300_mmc_host *vub300 = mmc_priv(mmc); > dev_info(&vub300->udev->dev, "NO host QUIRKS for this card\n"); > -- > 1.7.9.5 > Chris, Any comments on this patch?
Hi Sachin, On Wed, Jun 26 2013, Sachin Kamat wrote: > 'vub300_init_card' is used only in this file. Make it > static. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/mmc/host/vub300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c > index cb9f361..e9028ad 100644 > --- a/drivers/mmc/host/vub300.c > +++ b/drivers/mmc/host/vub300.c > @@ -2079,7 +2079,7 @@ static void vub300_enable_sdio_irq(struct mmc_host *mmc, int enable) > kref_put(&vub300->kref, vub300_delete); > } > > -void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) > +static void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) > { /* NOT irq */ > struct vub300_mmc_host *vub300 = mmc_priv(mmc); > dev_info(&vub300->udev->dev, "NO host QUIRKS for this card\n"); Thanks, pushed to mmc-next for 3.12. - Chris.
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index cb9f361..e9028ad 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c @@ -2079,7 +2079,7 @@ static void vub300_enable_sdio_irq(struct mmc_host *mmc, int enable) kref_put(&vub300->kref, vub300_delete); } -void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) +static void vub300_init_card(struct mmc_host *mmc, struct mmc_card *card) { /* NOT irq */ struct vub300_mmc_host *vub300 = mmc_priv(mmc); dev_info(&vub300->udev->dev, "NO host QUIRKS for this card\n");
'vub300_init_card' is used only in this file. Make it static. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/mmc/host/vub300.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)