| Message ID | 1374490361-25769-7-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Lee, On Monday 22 of July 2013 11:52:26 Lee Jones wrote: > Cc: Kukjin Kim <kgene.kim@samsung.com> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/exynos4210.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos4210.dtsi > b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644 > --- a/arch/arm/boot/dts/exynos4210.dtsi > +++ b/arch/arm/boot/dts/exynos4210.dtsi > @@ -72,7 +72,7 @@ > }; > }; > > - clock: clock-controller@0x10030000 { > + clock: clock-controller@10030000 { > compatible = "samsung,exynos4210-clock"; > reg = <0x10030000 0x20000>; > #clock-cells = <1>; This looks fine, but please fix commit message - it should be Exynos4210. Also some explanation why this change is needed would be good, even if it's obvious. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 22 Jul 2013, Tomasz Figa wrote: > Hi Lee, > > On Monday 22 of July 2013 11:52:26 Lee Jones wrote: > > Cc: Kukjin Kim <kgene.kim@samsung.com> > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/exynos4210.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos4210.dtsi > > b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644 > > --- a/arch/arm/boot/dts/exynos4210.dtsi > > +++ b/arch/arm/boot/dts/exynos4210.dtsi > > @@ -72,7 +72,7 @@ > > }; > > }; > > > > - clock: clock-controller@0x10030000 { > > + clock: clock-controller@10030000 { > > compatible = "samsung,exynos4210-clock"; > > reg = <0x10030000 0x20000>; > > #clock-cells = <1>; > > This looks fine, but please fix commit message - it should be Exynos4210. > Also some explanation why this change is needed would be good, even if > it's obvious. Hi Tomasz, I'm happy to fixup the $SUBJECT line, but do we really have to enter an explanation if it's obvious? Seems a little belt and braces. Kind regards, Lee
On Tuesday 23 of July 2013 09:55:52 Lee Jones wrote: > On Mon, 22 Jul 2013, Tomasz Figa wrote: > > Hi Lee, > > > > On Monday 22 of July 2013 11:52:26 Lee Jones wrote: > > > Cc: Kukjin Kim <kgene.kim@samsung.com> > > > Cc: linux-samsung-soc@vger.kernel.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > > > > arch/arm/boot/dts/exynos4210.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/exynos4210.dtsi > > > b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644 > > > --- a/arch/arm/boot/dts/exynos4210.dtsi > > > +++ b/arch/arm/boot/dts/exynos4210.dtsi > > > @@ -72,7 +72,7 @@ > > > > > > }; > > > > > > }; > > > > > > - clock: clock-controller@0x10030000 { > > > + clock: clock-controller@10030000 { > > > > > > compatible = "samsung,exynos4210-clock"; > > > reg = <0x10030000 0x20000>; > > > #clock-cells = <1>; > > > > This looks fine, but please fix commit message - it should be > > Exynos4210. Also some explanation why this change is needed would be > > good, even if it's obvious. > > Hi Tomasz, > > I'm happy to fixup the $SUBJECT line, but do we really have to enter > an explanation if it's obvious? Seems a little belt and braces. It's obvious for us, people working with device tree, but for people that usually don't it might not be. Something among following lines would be fine: This patch removes "0x" prefix from addresses in DT nodes for the sake of consistency with other nodes and assumed convention. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644 --- a/arch/arm/boot/dts/exynos4210.dtsi +++ b/arch/arm/boot/dts/exynos4210.dtsi @@ -72,7 +72,7 @@ }; }; - clock: clock-controller@0x10030000 { + clock: clock-controller@10030000 { compatible = "samsung,exynos4210-clock"; reg = <0x10030000 0x20000>; #clock-cells = <1>;
Cc: Kukjin Kim <kgene.kim@samsung.com> Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/exynos4210.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)