| Message ID | b8701d73538d37495b41ef465440a6d5f3018870.1374759923.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday, July 25, 2013 10:45 PM, Michal Simek wrote: > > regs_phys is phys_addr_t (u32 or u64). > Lets use %pa printk format specifier. > > Fixes compilation warning introduced by: > video: xilinxfb: Use drvdata->regs_phys instead of physaddr > (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> It looks good. Reviewed-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > Changes in v3: > - Fix commit message reported by Geert > > Changes in v2: > - Use %pa instead of casting > > ppc44x_defconfig > Fixes regressions in v3.11-rc2 > > --- > drivers/video/xilinxfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > index f3d4a69..6629b29 100644 > --- a/drivers/video/xilinxfb.c > +++ b/drivers/video/xilinxfb.c > @@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev, > > if (drvdata->flags & BUS_ACCESS_FLAG) { > /* Put a banner in the log (for DEBUG) */ > - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys, > - drvdata->regs); > + dev_dbg(dev, "regs: phys=%pa, virt=%p\n", > + &drvdata->regs_phys, drvdata->regs); > } > /* Put a banner in the log (for DEBUG) */ > dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n", > -- > 1.8.2.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25/07/13 16:45, Michal Simek wrote: > regs_phys is phys_addr_t (u32 or u64). > Lets use %pa printk format specifier. > > Fixes compilation warning introduced by: > video: xilinxfb: Use drvdata->regs_phys instead of physaddr > (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > Changes in v3: > - Fix commit message reported by Geert > > Changes in v2: > - Use %pa instead of casting > > ppc44x_defconfig > Fixes regressions in v3.11-rc2 > > --- > drivers/video/xilinxfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > index f3d4a69..6629b29 100644 > --- a/drivers/video/xilinxfb.c > +++ b/drivers/video/xilinxfb.c > @@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev, > > if (drvdata->flags & BUS_ACCESS_FLAG) { > /* Put a banner in the log (for DEBUG) */ > - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys, > - drvdata->regs); > + dev_dbg(dev, "regs: phys=%pa, virt=%p\n", > + &drvdata->regs_phys, drvdata->regs); > } > /* Put a banner in the log (for DEBUG) */ > dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n", > -- > 1.8.2.3 > Thanks, I've applied this into my 3.12/fbdev branch. Tomi
On 26/07/13 10:33, Tomi Valkeinen wrote: > On 25/07/13 16:45, Michal Simek wrote: >> regs_phys is phys_addr_t (u32 or u64). >> Lets use %pa printk format specifier. >> >> Fixes compilation warning introduced by: >> video: xilinxfb: Use drvdata->regs_phys instead of physaddr >> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Thanks, I've applied this into my 3.12/fbdev branch. Actually, let's put this into 3.11-fixes/fbdev branch. Tomi
On 07/26/2013 09:35 AM, Tomi Valkeinen wrote: > On 26/07/13 10:33, Tomi Valkeinen wrote: >> On 25/07/13 16:45, Michal Simek wrote: >>> regs_phys is phys_addr_t (u32 or u64). >>> Lets use %pa printk format specifier. >>> >>> Fixes compilation warning introduced by: >>> video: xilinxfb: Use drvdata->regs_phys instead of physaddr >>> (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) >>> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > >> Thanks, I've applied this into my 3.12/fbdev branch. > > Actually, let's put this into 3.11-fixes/fbdev branch. > Thanks, Michal
diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c index f3d4a69..6629b29 100644 --- a/drivers/video/xilinxfb.c +++ b/drivers/video/xilinxfb.c @@ -341,8 +341,8 @@ static int xilinxfb_assign(struct platform_device *pdev, if (drvdata->flags & BUS_ACCESS_FLAG) { /* Put a banner in the log (for DEBUG) */ - dev_dbg(dev, "regs: phys=%x, virt=%p\n", drvdata->regs_phys, - drvdata->regs); + dev_dbg(dev, "regs: phys=%pa, virt=%p\n", + &drvdata->regs_phys, drvdata->regs); } /* Put a banner in the log (for DEBUG) */ dev_dbg(dev, "fb: phys=%llx, virt=%p, size=%x\n",
regs_phys is phys_addr_t (u32 or u64). Lets use %pa printk format specifier. Fixes compilation warning introduced by: video: xilinxfb: Use drvdata->regs_phys instead of physaddr (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- Changes in v3: - Fix commit message reported by Geert Changes in v2: - Use %pa instead of casting ppc44x_defconfig Fixes regressions in v3.11-rc2 --- drivers/video/xilinxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.2.3