[RESEND] clk: export __clk_get_flags for modular clock providers

Commit Message

Sebastian Hesselbarth April 15, 2013, 6:59 a.m. UTC

The common clock api provides some helpers for clk-providers but does
not export these helpers. This hinders clk-providers to be built as modules.
This patch adds __clk_get_flags() to the list of exported symbols.

Signed-off-by: Sebastian Hesselbarth <[e-mail]>
---
Cc: Mike Turquette <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
---
 drivers/clk/clk.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Luciano Coelho July 4, 2013, 8:45 p.m. UTC | #1

Hi,

On 04/15/2013 09:59 AM, Sebastian Hesselbarth wrote:
> The common clock api provides some helpers for clk-providers but does
> not export these helpers. This hinders clk-providers to be built as modules.
> This patch adds __clk_get_flags() to the list of exported symbols.
>
> Signed-off-by: Sebastian Hesselbarth <[e-mail]>
> ---
> Cc: Mike Turquette <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> ---
>   drivers/clk/clk.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index ed87b24..3e478b8 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
>   {
>   	return !clk ? 0 : clk->flags;
>   }
> +EXPORT_SYMBOL_GPL(__clk_get_flags);
>
>   bool __clk_is_enabled(struct clk *clk)
>   {
>

I think this got merged slightly wrong.  The EXPORT_SYMBOL_GPL macro 
came under clk_unprepare_unused_subtree() instead of under 
__clk_get_flags():


Of course this is not that important, but it's a bit confusing when you 
look at the code.

--
Cheers,
Luca.

Mike Turquette July 30, 2013, 11:03 p.m. UTC | #2

Quoting Luciano Coelho (2013-07-04 13:45:27)
> Hi,
> 
> On 04/15/2013 09:59 AM, Sebastian Hesselbarth wrote:
> > The common clock api provides some helpers for clk-providers but does
> > not export these helpers. This hinders clk-providers to be built as modules.
> > This patch adds __clk_get_flags() to the list of exported symbols.
> >
> > Signed-off-by: Sebastian Hesselbarth <[e-mail]>
> > ---
> > Cc: Mike Turquette <[e-mail]>
> > Cc: [e-mail]
> > Cc: [e-mail]
> > ---
> >   drivers/clk/clk.c |    1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index ed87b24..3e478b8 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
> >   {
> >       return !clk ? 0 : clk->flags;
> >   }
> > +EXPORT_SYMBOL_GPL(__clk_get_flags);
> >
> >   bool __clk_is_enabled(struct clk *clk)
> >   {
> >
> 
> I think this got merged slightly wrong.  The EXPORT_SYMBOL_GPL macro 
> came under clk_unprepare_unused_subtree() instead of under 
> __clk_get_flags():
> 
> 
> Of course this is not that important, but it's a bit confusing when you 
> look at the code.

Thanks for pointing this out. I've fixed it up.

Regards,
Mike

> 
> --
> Cheers,
> Luca.

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ed87b24..3e478b8 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -450,6 +450,7 @@  unsigned long __clk_get_flags(struct clk *clk)
 {
 	return !clk ? 0 : clk->flags;
 }
+EXPORT_SYMBOL_GPL(__clk_get_flags);
 
 bool __clk_is_enabled(struct clk *clk)
 {