diff mbox

leds: leds-netxbig: depends on ARCH_KIRKWOOD

Message ID 1375479274-9942-1-git-send-email-simon.guinot@sequanux.org (mailing list archive)
State New, archived
Headers show

Commit Message

Simon Guinot Aug. 2, 2013, 9:34 p.m. UTC
With the DT conversion, the board Kconfig symbols MACH_ are going to be
removed. In order to prepare this removal, this patch replaces alls the
machines dependencies for leds-netxbig by ARCH_KIRKWOOD.

Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
---
Thomas,

Please, insert this patch in your series before the patch named:
[PATCHv2 7/9] ARM: kirkwood: convert LaCie Net{2, 5}Big v2 platforms to DT

Simon

 drivers/leds/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Cooper Aug. 3, 2013, 2:12 p.m. UTC | #1
On Fri, Aug 02, 2013 at 11:34:34PM +0200, Simon Guinot wrote:
> With the DT conversion, the board Kconfig symbols MACH_ are going to be
> removed. In order to prepare this removal, this patch replaces alls the
> machines dependencies for leds-netxbig by ARCH_KIRKWOOD.
> 
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> ---
> Thomas,
> 
> Please, insert this patch in your series before the patch named:
> [PATCHv2 7/9] ARM: kirkwood: convert LaCie Net{2, 5}Big v2 platforms to DT

Nah, this should go through linux-leds.

Acked-by: Jason Cooper <jason@lakedaemon.net>

thx,

Jason.

>  drivers/leds/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 0e41460..7226696 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -407,8 +407,8 @@ config LEDS_NS2
>  
>  config LEDS_NETXBIG
>  	tristate "LED support for Big Network series LEDs"
> -	depends on MACH_NET2BIG_V2 || MACH_NET5BIG_V2
>  	depends on LEDS_CLASS
> +	depends on ARCH_KIRKWOOD
>  	default y
>  	help
>  	  This option enable support for LEDs found on the LaCie 2Big
> -- 
> 1.7.10.4
>
Bryan Wu Aug. 5, 2013, 10:52 p.m. UTC | #2
On Sat, Aug 3, 2013 at 7:12 AM, Jason Cooper <jason@lakedaemon.net> wrote:
> On Fri, Aug 02, 2013 at 11:34:34PM +0200, Simon Guinot wrote:
>> With the DT conversion, the board Kconfig symbols MACH_ are going to be
>> removed. In order to prepare this removal, this patch replaces alls the
>> machines dependencies for leds-netxbig by ARCH_KIRKWOOD.
>>
>> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
>> ---
>> Thomas,
>>
>> Please, insert this patch in your series before the patch named:
>> [PATCHv2 7/9] ARM: kirkwood: convert LaCie Net{2, 5}Big v2 platforms to DT
>
> Nah, this should go through linux-leds.
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>
>

I can merge this patch through my tree but when will that kirkwood
patch be merged?
How about merge this with those kirkwood patches with my ack:

Acked-by: Bryan Wu <cooloney@gmail.com>

Thanks,
-Bryan

>
>>  drivers/leds/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 0e41460..7226696 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -407,8 +407,8 @@ config LEDS_NS2
>>
>>  config LEDS_NETXBIG
>>       tristate "LED support for Big Network series LEDs"
>> -     depends on MACH_NET2BIG_V2 || MACH_NET5BIG_V2
>>       depends on LEDS_CLASS
>> +     depends on ARCH_KIRKWOOD
>>       default y
>>       help
>>         This option enable support for LEDs found on the LaCie 2Big
>> --
>> 1.7.10.4
>>
Jason Cooper Aug. 6, 2013, 12:17 p.m. UTC | #3
Bryan,

On Mon, Aug 05, 2013 at 03:52:35PM -0700, Bryan Wu wrote:
> On Sat, Aug 3, 2013 at 7:12 AM, Jason Cooper <jason@lakedaemon.net> wrote:
> > On Fri, Aug 02, 2013 at 11:34:34PM +0200, Simon Guinot wrote:
> >> With the DT conversion, the board Kconfig symbols MACH_ are going to be
> >> removed. In order to prepare this removal, this patch replaces alls the
> >> machines dependencies for leds-netxbig by ARCH_KIRKWOOD.
> >>
> >> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> >> ---
> >> Thomas,
> >>
> >> Please, insert this patch in your series before the patch named:
> >> [PATCHv2 7/9] ARM: kirkwood: convert LaCie Net{2, 5}Big v2 platforms to DT
> >
> > Nah, this should go through linux-leds.
> >
> > Acked-by: Jason Cooper <jason@lakedaemon.net>
> >
> 
> I can merge this patch through my tree but when will that kirkwood
> patch be merged?

It's okay, it falls in the same category as the other patch you merged.
There's no dependency between this patch and the rest of this series,
despite the above request to insert.

thx,

Jason.

> How about merge this with those kirkwood patches with my ack:
> 
> Acked-by: Bryan Wu <cooloney@gmail.com>

No, no, no.  I'm trying to encourage patches to go through the
proper trees when possible.  :-P

> >
> >>  drivers/leds/Kconfig |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> >> index 0e41460..7226696 100644
> >> --- a/drivers/leds/Kconfig
> >> +++ b/drivers/leds/Kconfig
> >> @@ -407,8 +407,8 @@ config LEDS_NS2
> >>
> >>  config LEDS_NETXBIG
> >>       tristate "LED support for Big Network series LEDs"
> >> -     depends on MACH_NET2BIG_V2 || MACH_NET5BIG_V2
> >>       depends on LEDS_CLASS
> >> +     depends on ARCH_KIRKWOOD
> >>       default y
> >>       help
> >>         This option enable support for LEDs found on the LaCie 2Big
> >> --
> >> 1.7.10.4
> >>
Bryan Wu Aug. 6, 2013, 5:40 p.m. UTC | #4
On Tue, Aug 6, 2013 at 5:17 AM, Jason Cooper <jason@lakedaemon.net> wrote:
> Bryan,
>
> On Mon, Aug 05, 2013 at 03:52:35PM -0700, Bryan Wu wrote:
>> On Sat, Aug 3, 2013 at 7:12 AM, Jason Cooper <jason@lakedaemon.net> wrote:
>> > On Fri, Aug 02, 2013 at 11:34:34PM +0200, Simon Guinot wrote:
>> >> With the DT conversion, the board Kconfig symbols MACH_ are going to be
>> >> removed. In order to prepare this removal, this patch replaces alls the
>> >> machines dependencies for leds-netxbig by ARCH_KIRKWOOD.
>> >>
>> >> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
>> >> ---
>> >> Thomas,
>> >>
>> >> Please, insert this patch in your series before the patch named:
>> >> [PATCHv2 7/9] ARM: kirkwood: convert LaCie Net{2, 5}Big v2 platforms to DT
>> >
>> > Nah, this should go through linux-leds.
>> >
>> > Acked-by: Jason Cooper <jason@lakedaemon.net>
>> >
>>
>> I can merge this patch through my tree but when will that kirkwood
>> patch be merged?
>
> It's okay, it falls in the same category as the other patch you merged.
> There's no dependency between this patch and the rest of this series,
> despite the above request to insert.
>
> thx,
>
> Jason.
>
>> How about merge this with those kirkwood patches with my ack:
>>
>> Acked-by: Bryan Wu <cooloney@gmail.com>
>
> No, no, no.  I'm trying to encourage patches to go through the
> proper trees when possible.  :-P
>

No problem, merged already.

-Bryan

>> >
>> >>  drivers/leds/Kconfig |    2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> >> index 0e41460..7226696 100644
>> >> --- a/drivers/leds/Kconfig
>> >> +++ b/drivers/leds/Kconfig
>> >> @@ -407,8 +407,8 @@ config LEDS_NS2
>> >>
>> >>  config LEDS_NETXBIG
>> >>       tristate "LED support for Big Network series LEDs"
>> >> -     depends on MACH_NET2BIG_V2 || MACH_NET5BIG_V2
>> >>       depends on LEDS_CLASS
>> >> +     depends on ARCH_KIRKWOOD
>> >>       default y
>> >>       help
>> >>         This option enable support for LEDs found on the LaCie 2Big
>> >> --
>> >> 1.7.10.4
>> >>
diff mbox

Patch

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 0e41460..7226696 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -407,8 +407,8 @@  config LEDS_NS2
 
 config LEDS_NETXBIG
 	tristate "LED support for Big Network series LEDs"
-	depends on MACH_NET2BIG_V2 || MACH_NET5BIG_V2
 	depends on LEDS_CLASS
+	depends on ARCH_KIRKWOOD
 	default y
 	help
 	  This option enable support for LEDs found on the LaCie 2Big