diff mbox

[5/7] drm/radeon: remove stale gem->driver_private access

Message ID 1376485640-711-6-git-send-email-dh.herrmann@gmail.com (mailing list archive)
State Accepted
Headers show

Commit Message

David Herrmann Aug. 14, 2013, 1:07 p.m. UTC
This field is never read. No need to set it in radeon. Besides, DRM gem
core clears it during setup, anyway.

Cc: Dave Airlie <airlied@gmail.com>
Cc: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_object.c | 1 -
 drivers/gpu/drm/radeon/radeon_prime.c  | 1 -
 2 files changed, 2 deletions(-)

Comments

Alex Deucher Aug. 14, 2013, 1:23 p.m. UTC | #1
On Wed, Aug 14, 2013 at 9:07 AM, David Herrmann <dh.herrmann@gmail.com> wrote:
> This field is never read. No need to set it in radeon. Besides, DRM gem
> core clears it during setup, anyway.
>
> Cc: Dave Airlie <airlied@gmail.com>
> Cc: Alex Deucher <alexdeucher@gmail.com>
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/radeon/radeon_object.c | 1 -
>  drivers/gpu/drm/radeon/radeon_prime.c  | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 2020bf4..c0fa4aa 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -142,7 +142,6 @@ int radeon_bo_create(struct radeon_device *rdev,
>                 return r;
>         }
>         bo->rdev = rdev;
> -       bo->gem_base.driver_private = NULL;
>         bo->surface_reg = -1;
>         INIT_LIST_HEAD(&bo->list);
>         INIT_LIST_HEAD(&bo->va);
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index 65b9eab..2007456 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -68,7 +68,6 @@ struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
>                                RADEON_GEM_DOMAIN_GTT, sg, &bo);
>         if (ret)
>                 return ERR_PTR(ret);
> -       bo->gem_base.driver_private = bo;
>
>         mutex_lock(&rdev->gem.mutex);
>         list_add_tail(&bo->list, &rdev->gem.objects);
> --
> 1.8.3.4
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index 2020bf4..c0fa4aa 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -142,7 +142,6 @@  int radeon_bo_create(struct radeon_device *rdev,
 		return r;
 	}
 	bo->rdev = rdev;
-	bo->gem_base.driver_private = NULL;
 	bo->surface_reg = -1;
 	INIT_LIST_HEAD(&bo->list);
 	INIT_LIST_HEAD(&bo->va);
diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
index 65b9eab..2007456 100644
--- a/drivers/gpu/drm/radeon/radeon_prime.c
+++ b/drivers/gpu/drm/radeon/radeon_prime.c
@@ -68,7 +68,6 @@  struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
 			       RADEON_GEM_DOMAIN_GTT, sg, &bo);
 	if (ret)
 		return ERR_PTR(ret);
-	bo->gem_base.driver_private = bo;
 
 	mutex_lock(&rdev->gem.mutex);
 	list_add_tail(&bo->list, &rdev->gem.objects);